From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2A7F3D410D for ; Tue, 28 Apr 2026 09:42:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777369379; cv=none; b=IUJ1wyb8zkIQIal92XsDvOtx9npL5WFsh4OG2Z5aYGoPYvb+jIVtZxDsE1hGSL9TUL1pN+aA/dwPqUhR/NuF4IyXeZv8C1I+LHr8fzBnw7cLBZi9OyYxBo4qdVGVIQLNYg8oSd76X7d9QWg8PJueWy9HV5jAU9gd+pq0poIDh4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777369379; c=relaxed/simple; bh=p8Nv0AJoTta5EMpsjb7JOmpE8H5YhktE42ZUJI1zgRw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=NuhndV1XOCGHcdVw8HfGxu4mLBkNIR5jWFykkH8Lm6PEygY0xkmQ7Hq4aRA9f6VjSPn9xpgojM83r9VlBeoP45AILv/RxTCcNgKz51I56KSZnpg7A815W7q2EE6pnRZvVWZYQTTv3qZk65ajgOmjPrtw9CG7NkCj0KPwZjzYI4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CAGNKr26; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CAGNKr26" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9900AC2BCB7 for ; Tue, 28 Apr 2026 09:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777369378; bh=p8Nv0AJoTta5EMpsjb7JOmpE8H5YhktE42ZUJI1zgRw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=CAGNKr26cUeT5HAiyKc2K3chcRHBw7C7WpyNZdpPX99El6jXpyiszvphYeq0SFCA+ sG0WubbC6HwsSx0ZE7ymc3Tl3xbzTRroiM7YpM0EH1yMiZ+CTshpfUWwRHcaYPk7Wk XnETXIbT/gw0kLptYlAHnp4I1HPmvNVPsktQ2Crq1nwjlbUgU7G9uQ8vfyjhl0f+Mr JTPzfNTwfJKtonc9WVl/EhEfAwiwPqz4CLqvFDfy386FPUWEbURMVx99BfxZD8Ytic 2cRsKv73dVjAuXKW+0s4C8TnbKWSyBQ5m2nBLYHo2QhwFx2ws1BAVaIJpBM0kgnDzd i/Jdp9AHSmPFQ== Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-38e9653b580so124401161fa.2 for ; Tue, 28 Apr 2026 02:42:58 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ9/u3OFNh4mLu2lA6uexK/iSwgaqhqs02/4bdi3fkxrbrMwnQWq6G6gBb4hpZSKjoG5keuSizLvHjoTXwc=@vger.kernel.org X-Gm-Message-State: AOJu0YxbLAIzISJopUzRel4RKqC/aHqdn85VR9WWEiqu09InzhWCbBV/ Y/JXIzkzD+vrdj6dvr34h5Oi4mYtYTww03PZpYy/myEzrph0XP90P7n3ouQqgUUhwSd/AyF1xSr xY7ST3pXrALHP3Z7G+IuJiyhlRNMj+Wo= X-Received: by 2002:a2e:bc11:0:b0:38c:562b:9bb6 with SMTP id 38308e7fff4ca-39240d1f9bamr8432241fa.15.1777369377303; Tue, 28 Apr 2026 02:42:57 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260420-pinconf-v1-1-82f8276d8aec@gmail.com> In-Reply-To: <20260420-pinconf-v1-1-82f8276d8aec@gmail.com> From: Linus Walleij Date: Tue, 28 Apr 2026 11:42:44 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AVHnY4Idm6EHTtMScZdydO2A6TPmYvJ1MfBTf9NLYxUfXvnpkhcSF6iKRWa6Ec0 Message-ID: Subject: Re: [PATCH] pinctrl: pinconf-generic: fix properties bitmap leak in parse_fw_cfg() To: Felix Gu Cc: Conor Dooley , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 20, 2026 at 12:56=E2=80=AFPM Felix Gu wrote= : > In parse_fw_cfg(), if fwnode_property_match_property_string() fails with > -ENOENT, the code returns directly and leaks the bitmap. > > Use __free(bitmap) for automatic cleanup to fix the leak. > > Fixes: 9c105255108b ("pinctrl: pinconf-generic: perform basic checks on p= incfg properties") > Signed-off-by: Felix Gu Very elegant Felix, thanks! Patch applied. Yours, Linus Walleij