mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Walleij <linusw@kernel.org>
To: Alban Bedel <alban.bedel@lht.dlh.de>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <brgl@kernel.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: gpio: Add CAT9532 GPIO
Date: Tue, 15 Sep 2026 11:43:26 +0200	[thread overview]
Message-ID: <CAD++jLm0osL3KQVyk5-pVCv5eFbOY1V2BVRXdNf6rgwQJcLdgg@mail.gmail.com> (raw)
In-Reply-To: <20260915092046.931449-2-alban.bedel@lht.dlh.de>

Hi Alban,

thanks for your patch!

On Tue, Sep 15, 2026 at 11:21 AM Alban Bedel <alban.bedel@lht.dlh.de> wrote:

> Add devicetree binding document for CAT9532 LED dimmer as GPIO
> controller.
>
> Signed-off-by: Alban Bedel <alban.bedel@lht.dlh.de>
(...)
> +  ngpios:
> +    minimum: 1
> +    maximum: 16

ngpios is only used to lower the number of externally (on the package)
exposed GPIOs in SoC drivers, to avoid enumerating GPIOs not existing
on the physical package.

It has no place in a discrete circuit like this, don't even define this and
hardcode the GPIOs to 16 in the driver.

Yours,
Linus Walleij

  reply	other threads:[~2026-09-15  9:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  9:20 [PATCH 0/2] Support ON Semi CAT9532 Alban Bedel
2026-09-15  9:20 ` [PATCH 1/2] dt-bindings: gpio: Add CAT9532 GPIO Alban Bedel
2026-09-15  9:43   ` Linus Walleij [this message]
2026-09-15  9:47   ` Linus Walleij
2026-09-15 16:42   ` Conor Dooley
2026-09-15  9:20 ` [PATCH 2/2] gpio: Support ON Semi CAT9532 Alban Bedel
2026-09-15  9:51   ` Bartosz Golaszewski
2026-09-15  9:57     ` Bartosz Golaszewski
2026-09-15 13:48       ` Alban Bedel
2026-09-16  9:07         ` Bartosz Golaszewski
2026-09-15  9:59   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD++jLm0osL3KQVyk5-pVCv5eFbOY1V2BVRXdNf6rgwQJcLdgg@mail.gmail.com \
    --to=linusw@kernel.org \
    --cc=alban.bedel@lht.dlh.de \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®