From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF85039658E for ; Thu, 9 Apr 2026 08:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775722056; cv=none; b=XnpRlfiEQr+aD/IUb6wBBfFKsuxnIft7spl/r1e/dtw2S9onp3bxwP2PDdJITj2qHBmSVWaJRVYKoBu/LTpDPQBx/7tzgE/6jX/rS9swDyHX+5NcuVlBR9VCf5B9nu8ui3waroVk/IzJmqiOspXY7Xk4M+rjiynHgyQFYOpSHmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775722056; c=relaxed/simple; bh=LZBNqEFB1NNAudAGb3yCp5RdZJ1nCcVNqjcBmjGFoJo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=srzNEsywWVPcteV+VxgcNMAQUpgIf7qeN6EgEfCKTHlPgpyxSDfmpXFsdNVhz6h3bJjCDZHQBrM7g+PrnhKxpx/oUYCKfvsXJD3FJC+sG6LSWqH94ruu8kimsPg/CE758z7va+4WdUdWk+AUKiorelP2y+1CU9hSgxxvkUghrCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LHcbuAbi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LHcbuAbi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C57C4AF09 for ; Thu, 9 Apr 2026 08:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775722055; bh=LZBNqEFB1NNAudAGb3yCp5RdZJ1nCcVNqjcBmjGFoJo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LHcbuAbiWLfPq1Vx9L2xZz1mTbFSAv6AJj+1rEUGXxeudhYS0mTPSWgK4HqINM/Fo WMYfGBdb8eblI3L8OXalo8cE/XV/xIvbk/mA3ExghaaD74lmOC7t1R6MkDX/EZDUpF H7jlhtVtTj43/X2Wy2aoP8qUUJBjuaSyzuuXRcc59uP+0nrfTWG9SV+/0XxvUeBCWB OQ3XxkbNLiCaGNypLSbQD1Txy1Nd3UyBWzKhWy22+wO5QBqugDL1shiknQuzpTkGWy ksy59ppSUlROkcOEgSc2ifPDGn6iSpV5nhCJ9X50VAnc2auLz6UkIvfKJNx4F6VOvV qSJSSQjkfEE7w== Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-650182d19e0so549956d50.1 for ; Thu, 09 Apr 2026 01:07:35 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVSOAVY7246yO8KkFRoxpYcS3tY6Yan5OlhTeznIYcdKwOoer37arpJk5IHAjgMQqixsjKO7VDDPWj0s7g=@vger.kernel.org X-Gm-Message-State: AOJu0YzV+RNfJ/XY/UaCCb/JGdNam9uWVcC82duT8w63QumMUOrwR/MH GqeJywDycBpEarr2U8hXZo8V1fBzzX52PEW/QkIVgJGRA0kp4dc5VDev8AVaVP9V5oO4gzGzZjr ylT1VsdWBlCtwqANBxn7HoUz4mt2OJwI= X-Received: by 2002:a05:690e:440d:b0:649:bbf4:121b with SMTP id 956f58d0204a3-650486bf82emr18263002d50.2.1775722054841; Thu, 09 Apr 2026 01:07:34 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260407184805.807328-1-dev-josejavier.rodriguez@duagon.com> <20260407184805.807328-5-dev-josejavier.rodriguez@duagon.com> In-Reply-To: <20260407184805.807328-5-dev-josejavier.rodriguez@duagon.com> From: Linus Walleij Date: Thu, 9 Apr 2026 10:07:24 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AQROBzBkavb26-WDDLAuTxTNJd_i9vbiGYa7-KJ0vQBl_oWlwFNtOPje7S_8hmw Message-ID: Subject: Re: [RFC PATCH 4/5] gpio: mmio: convert accessors to generic register descriptors To: Jose Javier Rodriguez Barbarin Cc: brgl@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Jose, thanks for your patch! On Tue, Apr 7, 2026 at 8:49=E2=80=AFPM Jose Javier Rodriguez Barbarin wrote: > Convert the gpio-mmio accessors to use struct gpio_chip_reg instead of > the previous MMIO-only register type. > > This allows the same accessors to operate on both MMIO and PMIO > registers and aligns gpio-mmio with the updated gpio_generic_chip API. > > Signed-off-by: Jose Javier Rodriguez Barbarin This should work the same fine with a union as described per patch 1, and this is where that will start saving a bunch of memory. Possibly squash patch 1 into this patch? The new struct/union isn't used until here. Yours, Linus Walleij