From: Linus Walleij <linusw@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: Peter Rosin <peda@axentia.se>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
David Lechner <dlechner@baylibre.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] mux: gpio-mux: add enable GPIO support
Date: Mon, 19 Jan 2026 00:18:58 +0100 [thread overview]
Message-ID: <CAD++jLnTM2u0pD3EddbfpmAHY_SDb-cm+5kfEWWEF9o0i5LSmw@mail.gmail.com> (raw)
In-Reply-To: <20260116152621.75205-1-antoniu.miclaus@analog.com>
Hi Antoniu,
thanks for your patch!
On Fri, Jan 16, 2026 at 4:38 PM Antoniu Miclaus
<antoniu.miclaus@analog.com> wrote:
> This series adds optional enable GPIO support to the gpio-mux driver.
> The enable GPIO allows the multiplexer to be disabled before changing
> address lines and re-enabled after, preventing glitches that could
> briefly activate unintended channels during transitions.
>
> This feature is useful for devices like the Analog Devices ADG2404
> (4:1 mux) that require enable control for glitch-free operation. The
> binding documentation now includes ADG2404 as a supported device with
> a dedicated example.
Overall the idea is sound!
I don't know if "enable" is a good name for this GPIO though,
because as I understand it the signal passes through the mux even
if it is "disabled"?
I would call it "hold" and make it active low if it holds the mux
state when this signal is low.
hold-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
this will have the intended semantic.
Yours,
Linus Walleij
next prev parent reply other threads:[~2026-01-18 23:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 15:26 Antoniu Miclaus
2026-01-16 15:26 ` [PATCH v4 1/2] dt-bindings: mux: gpio-mux: add enable-gpios support Antoniu Miclaus
2026-01-16 16:04 ` Krzysztof Kozlowski
2026-01-16 15:26 ` [PATCH v4 2/2] mux: gpio-mux: add support for enable GPIO Antoniu Miclaus
2026-01-18 23:18 ` Linus Walleij [this message]
2026-01-20 14:28 ` [PATCH v4 0/2] mux: gpio-mux: add enable GPIO support Miclaus, Antoniu
2026-01-21 12:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD++jLnTM2u0pD3EddbfpmAHY_SDb-cm+5kfEWWEF9o0i5LSmw@mail.gmail.com \
--to=linusw@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=johan+linaro@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®