From: Cye Borg <cyborgyn@gmail.com>
To: "Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>
Cc: Jonathan Corbet <corbet@lwn.net>,
Federico Vaga <federico.vaga@vaga.pv.it>,
Alex Shi <alexs@kernel.org>, Yanteng Si <siyanteng@loongson.cn>,
Hu Haowen <src.res@email.cn>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Bagas Sanjaya <bagasdotme@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc-tw-discuss@lists.sourceforge.net,
linux-mips@vger.kernel.org
Subject: Re: [PATCH v3 08/15] MIPS: IP27: remove KV_MAGIC
Date: Fri, 11 Nov 2022 06:40:24 +0100 [thread overview]
Message-ID: <CAD4NMubS_DV0+1hgz3MEwNd4m9MUpUHXQ_EPJdd2MsgvMBSqpw@mail.gmail.com> (raw)
In-Reply-To: <60f6526fffa99416d2429dfb0b454148170cce8a.1668128257.git.nabijaczleweli@nabijaczleweli.xyz>
Just asking:
This code in SGI seems to help bring online other CPUs.
- Does it use the firmware to do it?
- Is there a possibility that the magic number in this case is used by
the firmware?
- If yes: do we break multiprocessing on SGI if we delete this
"useless relic", which is not referenced in the linux code elsewhere?
Best regards:
Barnabás Virágh
On Fri, Nov 11, 2022 at 2:15 AM Ahelenia Ziemiańska
<nabijaczleweli@nabijaczleweli.xyz> wrote:
>
> It appeared in the original import of SGI code in 2.4.0-test3pre8 and
> has never been used anywhere.
>
> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> ---
> Documentation/process/magic-number.rst | 1 -
> Documentation/translations/it_IT/process/magic-number.rst | 1 -
> Documentation/translations/zh_CN/process/magic-number.rst | 1 -
> Documentation/translations/zh_TW/process/magic-number.rst | 1 -
> arch/mips/include/asm/sn/klkernvars.h | 8 ++------
> arch/mips/sgi-ip27/ip27-klnuma.c | 1 -
> 6 files changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/process/magic-number.rst b/Documentation/process/magic-number.rst
> index 7dada7abc733..d8ffbc21872e 100644
> --- a/Documentation/process/magic-number.rst
> +++ b/Documentation/process/magic-number.rst
> @@ -72,7 +72,6 @@ APM_BIOS_MAGIC 0x4101 apm_user ``arch/x86/kerne
> FASYNC_MAGIC 0x4601 fasync_struct ``include/linux/fs.h``
> SLIP_MAGIC 0x5302 slip ``drivers/net/slip.h``
> HDLCDRV_MAGIC 0x5ac6e778 hdlcdrv_state ``include/linux/hdlcdrv.h``
> -KV_MAGIC 0x5f4b565f kernel_vars_s ``arch/mips/include/asm/sn/klkernvars.h``
> CCB_MAGIC 0xf2691ad2 ccb ``drivers/scsi/ncr53c8xx.c``
> QUEUE_MAGIC_FREE 0xf7e1c9a3 queue_entry ``drivers/scsi/arm/queue.c``
> QUEUE_MAGIC_USED 0xf7e1cc33 queue_entry ``drivers/scsi/arm/queue.c``
> diff --git a/Documentation/translations/it_IT/process/magic-number.rst b/Documentation/translations/it_IT/process/magic-number.rst
> index f9634a04d349..0e59704aa617 100644
> --- a/Documentation/translations/it_IT/process/magic-number.rst
> +++ b/Documentation/translations/it_IT/process/magic-number.rst
> @@ -78,7 +78,6 @@ APM_BIOS_MAGIC 0x4101 apm_user ``arch/x86/kerne
> FASYNC_MAGIC 0x4601 fasync_struct ``include/linux/fs.h``
> SLIP_MAGIC 0x5302 slip ``drivers/net/slip.h``
> HDLCDRV_MAGIC 0x5ac6e778 hdlcdrv_state ``include/linux/hdlcdrv.h``
> -KV_MAGIC 0x5f4b565f kernel_vars_s ``arch/mips/include/asm/sn/klkernvars.h``
> CCB_MAGIC 0xf2691ad2 ccb ``drivers/scsi/ncr53c8xx.c``
> QUEUE_MAGIC_FREE 0xf7e1c9a3 queue_entry ``drivers/scsi/arm/queue.c``
> QUEUE_MAGIC_USED 0xf7e1cc33 queue_entry ``drivers/scsi/arm/queue.c``
> diff --git a/Documentation/translations/zh_CN/process/magic-number.rst b/Documentation/translations/zh_CN/process/magic-number.rst
> index 966b9e6b1a46..17a73661ef17 100644
> --- a/Documentation/translations/zh_CN/process/magic-number.rst
> +++ b/Documentation/translations/zh_CN/process/magic-number.rst
> @@ -61,7 +61,6 @@ APM_BIOS_MAGIC 0x4101 apm_user ``arch/x86/kerne
> FASYNC_MAGIC 0x4601 fasync_struct ``include/linux/fs.h``
> SLIP_MAGIC 0x5302 slip ``drivers/net/slip.h``
> HDLCDRV_MAGIC 0x5ac6e778 hdlcdrv_state ``include/linux/hdlcdrv.h``
> -KV_MAGIC 0x5f4b565f kernel_vars_s ``arch/mips/include/asm/sn/klkernvars.h``
> CCB_MAGIC 0xf2691ad2 ccb ``drivers/scsi/ncr53c8xx.c``
> QUEUE_MAGIC_FREE 0xf7e1c9a3 queue_entry ``drivers/scsi/arm/queue.c``
> QUEUE_MAGIC_USED 0xf7e1cc33 queue_entry ``drivers/scsi/arm/queue.c``
> diff --git a/Documentation/translations/zh_TW/process/magic-number.rst b/Documentation/translations/zh_TW/process/magic-number.rst
> index f3e87a6b3a01..9d44d49b93bf 100644
> --- a/Documentation/translations/zh_TW/process/magic-number.rst
> +++ b/Documentation/translations/zh_TW/process/magic-number.rst
> @@ -64,7 +64,6 @@ APM_BIOS_MAGIC 0x4101 apm_user ``arch/x86/kerne
> FASYNC_MAGIC 0x4601 fasync_struct ``include/linux/fs.h``
> SLIP_MAGIC 0x5302 slip ``drivers/net/slip.h``
> HDLCDRV_MAGIC 0x5ac6e778 hdlcdrv_state ``include/linux/hdlcdrv.h``
> -KV_MAGIC 0x5f4b565f kernel_vars_s ``arch/mips/include/asm/sn/klkernvars.h``
> CCB_MAGIC 0xf2691ad2 ccb ``drivers/scsi/ncr53c8xx.c``
> QUEUE_MAGIC_FREE 0xf7e1c9a3 queue_entry ``drivers/scsi/arm/queue.c``
> QUEUE_MAGIC_USED 0xf7e1cc33 queue_entry ``drivers/scsi/arm/queue.c``
> diff --git a/arch/mips/include/asm/sn/klkernvars.h b/arch/mips/include/asm/sn/klkernvars.h
> index ea6b21795163..93d5eb873255 100644
> --- a/arch/mips/include/asm/sn/klkernvars.h
> +++ b/arch/mips/include/asm/sn/klkernvars.h
> @@ -6,18 +6,14 @@
> #ifndef __ASM_SN_KLKERNVARS_H
> #define __ASM_SN_KLKERNVARS_H
>
> -#define KV_MAGIC_OFFSET 0x0
> -#define KV_RO_NASID_OFFSET 0x4
> -#define KV_RW_NASID_OFFSET 0x6
> -
> -#define KV_MAGIC 0x5f4b565f
> +#define KV_RO_NASID_OFFSET 0x0
> +#define KV_RW_NASID_OFFSET 0x2
>
> #ifndef __ASSEMBLY__
>
> #include <asm/sn/types.h>
>
> typedef struct kern_vars_s {
> - int kv_magic;
> nasid_t kv_ro_nasid;
> nasid_t kv_rw_nasid;
> unsigned long kv_ro_baseaddr;
> diff --git a/arch/mips/sgi-ip27/ip27-klnuma.c b/arch/mips/sgi-ip27/ip27-klnuma.c
> index abd7a84df7dd..82bb7ac20ef8 100644
> --- a/arch/mips/sgi-ip27/ip27-klnuma.c
> +++ b/arch/mips/sgi-ip27/ip27-klnuma.c
> @@ -61,7 +61,6 @@ static __init void set_ktext_source(nasid_t client_nasid, nasid_t server_nasid)
>
> KERN_VARS_ADDR(client_nasid) = (unsigned long)kvp;
>
> - kvp->kv_magic = KV_MAGIC;
> kvp->kv_ro_nasid = server_nasid;
> kvp->kv_rw_nasid = master_nasid;
> kvp->kv_ro_baseaddr = NODE_CAC_BASE(server_nasid);
> --
> 2.30.2
next prev parent reply other threads:[~2022-11-11 5:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 1:13 [PATCH v3 00/15] magic-number.rst funeral rites Ahelenia Ziemiańska
2022-11-11 1:13 ` [PATCH v3 01/15] hamradio: baycom: remove BAYCOM_MAGIC Ahelenia Ziemiańska
2022-11-11 1:13 ` [PATCH v3 02/15] hamradio: yam: remove YAM_MAGIC Ahelenia Ziemiańska
2022-11-11 1:13 ` [PATCH v3 03/15] pcmcia: synclink_cs: remove MGSLPC_MAGIC Ahelenia Ziemiańska
2022-11-11 1:13 ` [PATCH v3 04/15] pcmcia: synclink_cs: remove dead paranoia_check, warn for missing line Ahelenia Ziemiańska
2022-11-11 1:13 ` [PATCH v3 05/15] coda: remove CODA_MAGIC Ahelenia Ziemiańska
2022-11-11 3:13 ` Jan Harkes
2022-11-11 1:14 ` [PATCH v3 06/15] Documentation: remove PG_MAGIC (not a magic number) Ahelenia Ziemiańska
2022-11-11 1:14 ` [PATCH v3 07/15] Documentation: remove NMI_MAGIC " Ahelenia Ziemiańska
2022-11-11 1:14 ` [PATCH v3 08/15] MIPS: IP27: remove KV_MAGIC Ahelenia Ziemiańska
2022-11-11 5:40 ` Cye Borg [this message]
[not found] ` <CAD4NMuYU6+JYGwCwDqGW5bTN8Rgg4SwseH9JKzjPAzsujBuCEw@mail.gmail.com>
2022-11-11 13:02 ` Thomas Bogendoerfer
2022-11-11 1:14 ` [PATCH v3 09/15] x86/APM: remove APM_BIOS_MAGIC Ahelenia Ziemiańska
2022-11-11 1:14 ` [PATCH v3 10/15] scsi: acorn: remove QUEUE_MAGIC_{FREE,USED} Ahelenia Ziemiańska
2022-11-11 1:14 ` [PATCH v3 11/15] hdlcdrv: remove HDLCDRV_MAGIC Ahelenia Ziemiańska
2022-11-11 1:14 ` [PATCH v3 12/15] drivers: net: slip: remove SLIP_MAGIC Ahelenia Ziemiańska
2022-11-11 1:14 ` [PATCH v3 13/15] fcntl: remove FASYNC_MAGIC Ahelenia Ziemiańska
2022-11-11 10:00 ` Jeff Layton
2022-11-11 1:14 ` [PATCH v3 14/15] scsi: ncr53c8xx: replace CCB_MAGIC with bool busy Ahelenia Ziemiańska
2022-11-11 1:14 ` [PATCH v3 15/15] Documentation: remove magic-number.rst Ahelenia Ziemiańska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD4NMubS_DV0+1hgz3MEwNd4m9MUpUHXQ_EPJdd2MsgvMBSqpw@mail.gmail.com \
--to=cyborgyn@gmail.com \
--cc=alexs@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=federico.vaga@vaga.pv.it \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc-tw-discuss@lists.sourceforge.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=siyanteng@loongson.cn \
--cc=src.res@email.cn \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®