From: Daniel Drake <drake@endlessm.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcel Holtmann <marcel@holtmann.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Linux Bluetooth mailing list <linux-bluetooth@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Leif Liddy <leif.linux@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"
Date: Thu, 21 Dec 2017 11:43:54 +0000 [thread overview]
Message-ID: <CAD8Lp47CEnQmDEwGDLZPpUcSS0Azf1ZO2zeuffYyDtwga2+Dqw@mail.gmail.com> (raw)
In-Reply-To: <20171220185308.GA176644@google.com>
On Wed, Dec 20, 2017 at 6:53 PM, Brian Norris <briannorris@chromium.org> wrote:
>
> On Wed, Dec 20, 2017 at 07:00:07PM +0800, Kai-Heng Feng wrote:
> > This commit causes a regression on some QCA ROME chips. The USB device
> > reset happens in btusb_open(), hence firmware loading gets interrupted.
>
> Oh, did you really confirm that's the root of the problem? I was only
> hypothesizing, with some informed observation and code review; but I
> didn't fully convince myself. If so, that's interesting.
I have the same doubt. Can you explain how/why firmware uploading and
btusb_open() overlap, and how this is avoided with your patch?
If they do overlap, is that not a bug in the stack that should be fixed instead?
If the fix belongs in btusb and this BTUSB_RESET_RESUME thing really
is problematic, should it be totally removed instead?
Daniel
next prev parent reply other threads:[~2017-12-21 11:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 11:00 Kai-Heng Feng
2017-12-20 11:00 ` [PATCH 2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth Kai-Heng Feng
2017-12-26 21:01 ` Marcel Holtmann
2017-12-27 12:52 ` Greg Kroah-Hartman
2017-12-28 11:59 ` Leif Liddy
2017-12-28 20:15 ` Marcel Holtmann
2017-12-20 18:53 ` [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume" Brian Norris
2017-12-21 11:43 ` Daniel Drake [this message]
2017-12-21 17:31 ` Brian Norris
2018-01-02 10:06 ` Kai Heng Feng
2017-12-26 21:00 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD8Lp47CEnQmDEwGDLZPpUcSS0Azf1ZO2zeuffYyDtwga2+Dqw@mail.gmail.com \
--to=drake@endlessm.com \
--cc=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=leif.linux@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®