From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 892FD26299 for ; Fri, 1 May 2026 00:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777593713; cv=none; b=oUYukl8LjTpi++Vi7fDn+aawJds2v4o+PMWOejQPoq4rYy69XEabpMlhSRbZmDgalq9O0Wd+86TYFRInMDUtuof5GR95NDlQMZnrEsCeRnHhNdpPjBrsdkybh2FlKJB1ZcTyKj1Ee8FgzqCuNIOAsB3LL0869gikwpftCj25B4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777593713; c=relaxed/simple; bh=K6HjmbNrmRNPQFoeUy4vXzHlo/g/A/oFQFErhjwT8ZI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=cThSuWcsJzjlDMPQcYhEJ7qRpE9SyyLuPCVEAV/tDjywe8BpFrW4gfaa81NaWVTvZh4oYTLvDN/PJz/NhciHnWoa4Cjwbz/BFmKezJYSNKxD9ZaB+H16V5NZzMkCU4frKt5dluyXDtEcnWlKHMHpi2AWc5jS0JPW4fR8qjlJ/BA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jSyYzR8O; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jSyYzR8O" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b9c01854477so217159566b.0 for ; Thu, 30 Apr 2026 17:01:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1777593709; x=1778198509; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E9C1umI5D1atr9W6hfkEvQCrhMpTXSs9QJYfV/9UKu8=; b=jSyYzR8O1AoOWn4qu26PWlQXsGI6AYOt7MTBiO7A7FSN9iSp1BOsnGKJdbfduojUA4 EiNHJ/jSvzn9xmBnhkTV1ynQuokT+artV3ZwtXNCCwKzgirkgqebhqZ4LbeXqbAEanIX 1RTC931LfI3hb+/9ykmOt7Sht4jUD5ty18TqM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777593709; x=1778198509; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=E9C1umI5D1atr9W6hfkEvQCrhMpTXSs9QJYfV/9UKu8=; b=UhIKvjP4+XlmM0QOS39hL86ymB+UAZbrBFKSQa0P8howRx2nv2/Po+prWM+vdtLwwB K9dnK72bTmiPMb2mPZ44ywgmPJTm+EIs9xZupXwJl++YINDfRrzLHmm6onRuUj1H993+ 04bbSWZySWPRAFWbIgEvoxAylsQKkEl7AFVFWiIc1vbKUWnaDn3RLL/8AOv7gHJoQURf 3/OyU81BVkJN709Cf7QDaUYcQbCHJPaVfjqr0HKKZSSMTyH76RO6PV8oT6NP1dkD/DhY j8LdRJcGqBGErVOz2ej2DLkahJwjAL8CBZnrUduR1APGqNC072ETgoobmwV39aBTgMHR 5BVA== X-Forwarded-Encrypted: i=1; AFNElJ+Sxg5FqLaknQHc4ipWZPJNcMkef95MmGOGRLlwxn0kC8qO/hdYwJRu4ZJbq9Qr71iHRt2L+zKHe8ZARmw=@vger.kernel.org X-Gm-Message-State: AOJu0YxI0JJT3gFQ4udEFPNXav0OEsFKIOQq48ISyPBjT9N3LRIDbop8 9cI3G3/87Oa/neWQFC1Ol1ls55+w/yGhN7veS6W3VRVBE2cPanf/plS3L/l/RqMjb0m2zEb/Pwb S5asWtNsT X-Gm-Gg: AeBDiesCrFR4cLCQXlyagxv7MDS66iiF4ixbDvU4iEBx5Ou54r7b6lgHc83VE1J3XyN e9bFc3K6NwXMHdJ7psJPnAuVsa4HW/wLMqsk0duJ2t3IwGcLKBoJnUvhfplg8/L3ub1Gy/6z44t aCc67aCs2zwVWcymzeqv8ETLoNwA0yvFYxWacbZLuZdjQhbaJsdiIRPJ6VUmlI123NfVCbDEt+Q 9YfY5OX9YXmIyY882btqLNbMDbT5/eqDWtX22jvBkGDav5P+CD/MEEmBbDtVl6+TDOQhuxoB/dx C/qqwYgeRCMjL0P/n0YnwiEzHtgKrOF/OU1yHMI/KDC1rCQzdxbvAGkbKJKNraTPfK6XIH9LeOR 1bV3ASKx4sxBWXvMe48cXNU0K2oPbbkK06YQ+9WdmHEu1w0rIVezO45HCgyFyEjRCeUDdQLdDUa DKBKXdTzGHG9Dmvxn8KsMQUa0G6JkUQVVlMBp3jabrjZqejCpqzqVrzVZHRdkAsVGnyYREBZIG X-Received: by 2002:a17:906:c113:b0:ba4:8288:b464 with SMTP id a640c23a62f3a-bbb68d11d4dmr316731866b.6.1777593709493; Thu, 30 Apr 2026 17:01:49 -0700 (PDT) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com. [209.85.218.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bbe6d06947fsm49534766b.37.2026.04.30.17.01.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 17:01:49 -0700 (PDT) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-bba0dde4f43so221607366b.3 for ; Thu, 30 Apr 2026 17:01:49 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ8yTZl6NtUH8UfB64+I9d19dCvXF+gjgboouJonJhb6YC81UV0fyW28dT/gRWmLx19wVyytsEzxV5GpM8k=@vger.kernel.org X-Received: by 2002:a05:6000:40e0:b0:43d:50c:6f18 with SMTP id ffacd0b85a97d-4493cc3fdadmr8678277f8f.11.1777593256152; Thu, 30 Apr 2026 16:54:16 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260428200712.2660635-1-briannorris@chromium.org> <20260428200712.2660635-2-briannorris@chromium.org> In-Reply-To: <20260428200712.2660635-2-briannorris@chromium.org> From: Doug Anderson Date: Thu, 30 Apr 2026 16:54:04 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AVHnY4ITNUkQNF1rYH2AzAfyi5kerkzeuZiwFrCYx_qZbGHsYv-60K7BAEKUu9M Message-ID: Subject: Re: [PATCH 1/7] arm64: dts: rockchip: Add #{address,size}-cells to Chromium-based /firmware To: Brian Norris Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Heiko Stuebner , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Konrad Dybcio , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tzung-Bi Shih , chrome-platform@lists.linux.dev, linux-rockchip@lists.infradead.org, Julius Werner , Alim Akhtar , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Tue, Apr 28, 2026 at 1:07=E2=80=AFPM Brian Norris wrote: > > Chromium/Depthcharge bootloaders may dynamically add a few device nodes > to a system's DTB under a /firmware node. A typical DT looks something > like the following: > > ## From a RK3399 Gru/Kevin Chromebook: > # find /sys/firmware/devicetree/base/firmware > /sys/firmware/devicetree/base/firmware > /sys/firmware/devicetree/base/firmware/coreboot > /sys/firmware/devicetree/base/firmware/coreboot/ram-code > /sys/firmware/devicetree/base/firmware/coreboot/compatible > /sys/firmware/devicetree/base/firmware/coreboot/board-id > /sys/firmware/devicetree/base/firmware/coreboot/reg > /sys/firmware/devicetree/base/firmware/coreboot/name > /sys/firmware/devicetree/base/firmware/chromeos > /sys/firmware/devicetree/base/firmware/chromeos/readonly-firmware-versi= on > /sys/firmware/devicetree/base/firmware/chromeos/active-ec-firmware > /sys/firmware/devicetree/base/firmware/chromeos/firmware-version > /sys/firmware/devicetree/base/firmware/chromeos/nonvolatile-context-sto= rage > /sys/firmware/devicetree/base/firmware/chromeos/vboot-shared-data > /sys/firmware/devicetree/base/firmware/chromeos/nonvolatile-context-siz= e > /sys/firmware/devicetree/base/firmware/chromeos/nonvolatile-context-off= set > /sys/firmware/devicetree/base/firmware/chromeos/hardware-id > /sys/firmware/devicetree/base/firmware/chromeos/compatible > /sys/firmware/devicetree/base/firmware/chromeos/firmware-type > /sys/firmware/devicetree/base/firmware/chromeos/fmap-offset > /sys/firmware/devicetree/base/firmware/chromeos/name > /sys/firmware/devicetree/base/firmware/ranges > /sys/firmware/devicetree/base/firmware/name > > The /firmware node has an empty 'ranges', but does not have > address/size-cells. > > Commit 6e5773d52f4a ("of/address: Fix WARN when attempting translating > non-translatable addresses") started requiring #address-cells for a > device's parent if we want to use the reg resource in a device node. > This leads to errors like the following: > > [ 7.763870] coreboot_table firmware:coreboot: probe with driver corebo= ot_table failed with error -22 > > Add appropriate #{address,size}-cells to work around the problem. > > Note that Google has also patched the Depthcharge bootloader source to > add {address,size}-cells [1], but bootloader updates are typically > delivered only via Google OS updates. Not all users install Google > software updates, and even if they do, Google may not produce updated > binaries for all/older devices. > > [1] https://lore.kernel.org/all/20241209092809.GA3246424@google.com/ > https://crrev.com/c/6051580 ("coreboot: Insert #address-cells and > #size-cells for firmware node") > > Closes: https://lore.kernel.org/all/aeKlYzTiL0OB1y3g@google.com/ > Fixes: 6e5773d52f4a ("of/address: Fix WARN when attempting translating no= n-translatable addresses") > Signed-off-by: Brian Norris Reviewed-by: Douglas Anderson