From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7E883939CE for ; Wed, 25 Feb 2026 11:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=170.10.129.124 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772018243; cv=pass; b=ulZkHKKEOxQsDUeFKMjcfpO1nW7bj3AbJzEm9z7/77U0KD4/tLtJzQe8XrtxwJ605+6aGuGKGQZwhSbHOqb5mLkivl3tTlpT40NmvZpTyz1sruCTF85l9OQqFwGNEuXONeV0NC02ym5wII3zYOpEDcdSsLxPLL0CefscI0ta3zg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772018243; c=relaxed/simple; bh=ScjPGYvbF+x5M24+r2PbaTr+5ESRsrvbiRntSZp43hw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=TjvCDZR8QImohVIdY8aPhv7Ne/bdlh6Mw92LAzOecOynY48cjAbC9ezsR2naqo7MttpWMETzvuy8P39bnvfzHzYTmZ7NTH9NYCfXg7YTfQSDJVcj0u+dQbsQLlr4bus+JRksv33dzL3H/i0ajt/lvX6aIR5PhPtNEmhR3oBTRNY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gHb6Zyci; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rh7+G9ff; arc=pass smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gHb6Zyci"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rh7+G9ff" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772018239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sJAgujioq3EwE7o85/KGFLew4sjYqJsiovhiUlVgoug=; b=gHb6ZycieLP+DLYomClFNWm3T5kdcqjby+2DZK1h1Qr6JIiB98HYRkfceRfMkf9qWBfRV7 tOltL79blFGK7JMwX8R83NLkxub4D9lCnQ4kpXWWYX8tqZRQpBjlhoAjc0a1Jl9GiwcZU2 vfjKumaWqsMkqgaU1CClnSBtG/wOPyw= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-LwOtr3KrOTaixx0M5B9Sjg-1; Wed, 25 Feb 2026 06:17:18 -0500 X-MC-Unique: LwOtr3KrOTaixx0M5B9Sjg-1 X-Mimecast-MFC-AGG-ID: LwOtr3KrOTaixx0M5B9Sjg_1772018238 Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-7d4c79fc40dso7896891a34.0 for ; Wed, 25 Feb 2026 03:17:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772018238; cv=none; d=google.com; s=arc-20240605; b=AgrVU2WoxfQN/fxsFaQT/SvhcxhiXTjfsck6f5+Uy+JEfKsqbTgY1g3eGolOYDhsDZ 3/cFnBUp71uqf+UKl+kEYhBgXFni7o+kMmdSMhjSaQF/2bZLtYw6OCwqkbEZqIYBVHag 25k0hhqNAH8V+VWOxzXcZ0qJ4hJU/bGb9Rl2xvUPFrfhvMxjkpufPGI5wVjox1Iy5qn8 jbAav8K7XcYzEVMj4XPL26oYBbh/FFScQIexp+GZK19+fDT5U+Zh4Hscddg161vJDw9b 0ATzpIM4UZ7J784PGDvtOp3Ry+lYbw0YwIKgHFLsOWMJN2AIAtAoFeL4MzfEo6oc3lG2 KVbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=sJAgujioq3EwE7o85/KGFLew4sjYqJsiovhiUlVgoug=; fh=bY1q2CKm/SExDTrTH91sw2kYz+BeSobeKwkDFqRUNmI=; b=WHxQCdUuOIs1aucydCJhoQovUCfKOZRCd6FuxqVjWUaORUa3odX9Er+DHA+aBKAhiE FlOf5dTo92KuKoSjEzOrTwR7v2c03u6rmiCXzrr0gYrmGtyzPF5hUwiLUHqVtl4Po53/ Cb/mOEFtmkL3QrjtlB1972auKUYXJ9BfnGb5bt4oKDBgEShqUYQxIw7S13w+4tS/559t fBvFhdFTGsNI2O0GaCa8s0DWTmiagK12oVRelUXcUwz+ISuUc+VEjVChHaGi46DlKmLo /th4mU9Aw5JD0DcrGfW9fJEZSgDD98udbTRxhPDjCWB37uxyokB6sYRZLEzEicagWcE5 2Ljw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772018238; x=1772623038; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sJAgujioq3EwE7o85/KGFLew4sjYqJsiovhiUlVgoug=; b=rh7+G9ffyqUcRxWmftxc3RlP4txxjzazQJxuLdguG8AxOQJt5pI19DbsaHuYY1lMOI rOQzvLwxFr8AXJ1pOBlwYYyUzhynlbtXOOAbfrdm1deunqfW8sg9Mt2pbNgQijRVc8yG f184E2HOr9cnZ5avaUrkHjabskiexp82uEW2YI5jIkpb1RrvF77iqa+ObOBQj8A75PW6 DmWfiTroCFCeTz+v0nTOOOWQ7nXoIxC5DisFfVz8AbBVRkIT0D1/gAY4/1rUhmzrZuzX 0+W7+qqW/jQnIIHG5UQIJERnvuIIabZIF2dvUQ+bLUpJg2eFU0Vu/uKKfO8w+W0zOJwy Jy5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772018238; x=1772623038; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sJAgujioq3EwE7o85/KGFLew4sjYqJsiovhiUlVgoug=; b=H2mLlTxUAkg3HO39z0DY94whW7OyVhspu0qV68empI84K/xHOQRnPfD+vP2H84ih/G Di+eZ2PtO7DCyXrjN1TesSukMu6WUqBD+s9UouIrbSaV3zT3+CIL8kGTEc8dex41g9IB YU8ckuL97bQPuBccuuBPebQSTtc7SYYYcc6PccESQAcYx6iDFaMTYzaTYQB/az/R/f+F UymOdAyBBo1BaFVImwgUA+Jak3myCTO7N0z2dKHK2iGqcRuCisUL42CN7Jat8aa2ERwa 8lqtJf+6DeH5S3/vfWRDsOVs2J4DSovIawn1T9aA10Rk564cSRnZQCG2689AnlBw+4Wj oXxQ== X-Forwarded-Encrypted: i=1; AJvYcCUyBzRVCIaCwPaZcgcVic1+1afJ9B/QTOgL6njQf8AyJtscsE1djw1gfq7cNbIxtNP8kCfAUZuQCuHTg9w=@vger.kernel.org X-Gm-Message-State: AOJu0YzfIPshbcedu3HWAEZgI5+b8Cz8mSAq53bKbTGTsfgYwA8enW92 Ni1N86qTdKpuHtxt5MwbtQuNi2sWq+CYShnCbqmHW7DxQA/5yFWoGfVjv3IcmnK92/hjwmQfsg2 xBR4t8WnS5ulyBLaFzy1SiO2lcvbGIVndmRfDeRVWoSsxZLOQ8Iqt5jeQg92+LHFfsezIv5HwB2 nICRmO0G46gUr7Uvb9TpkCZCp0/dOWnlV/5yk7w0nh X-Gm-Gg: ATEYQzzuIM31KxOb1Mhf/ifsmZj6RMFn/Wxjumqt3UvETo8pZPufuCOHYFCt+uCcbVu hR9JKSAoQ4Wyb139IlW8VSZv9tGeizYb55o3KP6i2RV3FQsHyX+M+ukl535IuVe2vQntYBZ1lon T5i8HngC1ba80KIF3kyIFlivitjlFau9nVER0UKYZSb+cs+4lu0ugDGHVCy6QZXuYxFBopBro56 2/QBQ== X-Received: by 2002:a05:6830:268f:b0:7cf:d108:65f with SMTP id 46e09a7af769-7d52be03c9bmr8085263a34.2.1772018237697; Wed, 25 Feb 2026 03:17:17 -0800 (PST) X-Received: by 2002:a05:6830:268f:b0:7cf:d108:65f with SMTP id 46e09a7af769-7d52be03c9bmr8085246a34.2.1772018237391; Wed, 25 Feb 2026 03:17:17 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260225100137.383527-1-poros@redhat.com> In-Reply-To: <20260225100137.383527-1-poros@redhat.com> From: Michal Schmidt Date: Wed, 25 Feb 2026 12:17:05 +0100 X-Gm-Features: AaiRm50bofXry4bxFntonEhNYGGknNqMfZsgOM_LWk9I1qmKjhrgXGt_4R_ORqo Message-ID: Subject: Re: [Intel-wired-lan] [PATCH iwl-net] iavf: fix VLAN filter lost on add/delete race To: Petr Oros Cc: netdev@vger.kernel.org, Przemek Kitszel , Eric Dumazet , Ahmed Zaki , Andrew Lunn , Tony Nguyen , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 25, 2026 at 11:02=E2=80=AFAM Petr Oros wrote= : > > When iavf_add_vlan() finds an existing filter in IAVF_VLAN_REMOVE > state, it transitions the filter to IAVF_VLAN_ACTIVE assuming the > pending delete can simply be cancelled. However, there is no guarantee > that iavf_del_vlans() has not already processed the delete AQ request > and removed the filter from the PF. In that case the filter remains in > the driver's list as IAVF_VLAN_ACTIVE but is no longer programmed on > the NIC. Since iavf_add_vlans() only picks up filters in > IAVF_VLAN_ADD state, the filter is never re-added, and spoof checking > drops all traffic for that VLAN. > > CPU0 CPU1 Workqueue > ---- ---- --------- > iavf_del_vlan(vlan 100) > f->state =3D REMOVE > schedule AQ_DEL_VLAN > iavf_add_vlan(vlan 100) > f->state =3D ACTIVE > iavf_del_vlans() > f is ACTIVE, skip > iavf_add_vlans() > f is ACTIVE, skip > > Filter is ACTIVE in driver but absent from NIC. I don't get it. If, as the diagram shows, iavf_del_vlans() skipped it, then how does the filter become absent from NIC? Michal > Transition to IAVF_VLAN_ADD instead and schedule > IAVF_FLAG_AQ_ADD_VLAN_FILTER so iavf_add_vlans() re-programs the > filter. A duplicate add is idempotent on the PF. > > Fixes: 0c0da0e95105 ("iavf: refactor VLAN filter states") > > Signed-off-by: Petr Oros > --- > drivers/net/ethernet/intel/iavf/iavf_main.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/et= hernet/intel/iavf/iavf_main.c > index 4b0fc8f354bc90..6046b93c7f3472 100644 > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > @@ -782,10 +782,13 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter= *adapter, > adapter->num_vlan_filters++; > iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_F= ILTER); > } else if (f->state =3D=3D IAVF_VLAN_REMOVE) { > - /* IAVF_VLAN_REMOVE means that VLAN wasn't yet removed. > - * We can safely only change the state here. > + /* Re-add the filter since we cannot tell whether the > + * pending delete has already been processed by the PF. > + * A duplicate add is harmless. > */ > - f->state =3D IAVF_VLAN_ACTIVE; > + f->state =3D IAVF_VLAN_ADD; > + iavf_schedule_aq_request(adapter, > + IAVF_FLAG_AQ_ADD_VLAN_FILTER); > } > > clearout: > -- > 2.52.0 >