From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 474242F12D6 for ; Tue, 18 Nov 2025 07:29:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763450943; cv=none; b=m+Dv+aQu04QKaeEYYI6ttsAzkWQmUptOP38nNWVPjZx1p86vxW9lLaYvIC2GpKaME76MhNlct0/LT7ReJvpDriZBwJE8wi7I8q3L9RrZzdX/kesRNb76Rpdmuyz0t701vi1fIirLZRq2MeRX4SFzDTOsl9FixfomXE9wk1VxBFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763450943; c=relaxed/simple; bh=70toKdk+d/xNXNS5e0pylcSzKrOv1XeMT95DFQkmNag=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=dAHVvXxAOvzyWJjgR9uPLuzY1M2aAoS4vvBmriI/DXKB7idPJwrV/TIAHwle3uF+23wKB8i71HFTC1eo204eXsDDnrIZ55bRevLWuC8HfGsfKHrK+kthSKmPytyET0tAsfIij2+PrcYviGTqLAmyAIvD2yyLKsUyYglsWyP3kxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WbuM80s1; arc=none smtp.client-ip=209.85.167.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WbuM80s1" Received: by mail-lf1-f68.google.com with SMTP id 2adb3069b0e04-59581e32163so5005475e87.1 for ; Mon, 17 Nov 2025 23:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763450939; x=1764055739; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FLjJBvcjdxGIbfuF3deEYGVfgeDIoTuMXGx329fUUGg=; b=WbuM80s1D+CW6b3hffzF1KIbX3PzxJngVJuUPWroQHDdTNTI9Etw07HFkpNl2wm6e4 dvI/WeAL6FpkBYyZfRvLAOvJTpGrt84ESQTc92/2LACa28eJljbgMRr0kGkTgFS3SYf4 BrLfVd3TBc6rRd2K4x4JHK+PGhOHVTxOU9iC6vmYq3P5Q0xiRkuVVZL8ZPGL72MessWx 8nWdODOzT+4aaqqJvG5gSOZNMj9XrGmeEMkeuS42hLiIZ6784Nlwd4cXkBgiWt+3F8QG Fyb7OO0UYn4OgH5ITpGmrZ/HNpjPBEayOctrLogbNUlKaP9QJoYUdxGb+qnAZ+MuYUpG c+bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763450939; x=1764055739; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FLjJBvcjdxGIbfuF3deEYGVfgeDIoTuMXGx329fUUGg=; b=B45rC1scmmBfS4zSiafBvSKGCP0BXc7/xvSDUWv3fBSr52TO4aP1wsiQK7VXk44dYK 1BAhovBXZkAQqOrsSjIGyahKnpjee5PRteijrd/QxXxOZLI97KLLVY5tNe6+Kn1Ts0Sf dNWMM1TzIFxzlQi3LAzt2VUMlQ7bJzmlkiFBHwRUBfJ1aWWNMez7lZjYuQcaAPrNC8pN m0/FSprar6dtCuwZz0mbPJY8Z99F+gqZjNZ61JIfiSvp2FKJxm1VubjNdY2y4Y2Hf9eB cDezXUyLmDYSUJhC52jugrXSeDbc/MTOBEiHytpcNRMiKvjYEUYynFOYFQTdatmOjQou CZQg== X-Forwarded-Encrypted: i=1; AJvYcCUl0c6lLSnAg/zjQHlPZX0ZnLN9gEkcgbiKBOeXYA2cRRM8xBXxLHK0/9e3o5dalTerBrykIG4cPI8kNso=@vger.kernel.org X-Gm-Message-State: AOJu0YzDUi9cN0Oy18ZHv17AaNo9GiZufr/4NJUmVoXdDKEEYsaSA8n3 EZG+IMPWIz7CkjHnpE1u89nbE6BANwIOy8VTBZtniN82us9SZemVX9jmQhhtz35yRWsP8WgSpJh IJ+FjBNAKTgMlPBIkfA6YXEuGAkOzcM8= X-Gm-Gg: ASbGnctACfUjd4sf0tlxU+SNYs8zsoe0LQb4ozCLupOGzu0cwcULpsVYEnWh7m8PxdA x/ORqf42IzVlUkvRvbxQZo4laH2rdAV6javv/UTBxMB0/K73QxACfU4I0V5I6HlGOxk1fjAMh1E CwwMazEzBLT7E+yY59TBSer2W0YHkTLvoYtEzVCY9G7q083srPJJ23O+npa8oxX9V8pCpY4w1GO rYJhJQ0KQUpolQw1wsuGi/7DL+r+HB082KZPMDY7uEC+lI17i7R/iDMDOhn X-Google-Smtp-Source: AGHT+IG6DEMKjBOyARk0+W/Yr7aQhUUGV+aAyrbedCQjNwC1feyiHTDZI0M5wWXWNnPmDUIWuj9E7OrzVlmP7cUgCFA= X-Received: by 2002:a05:6512:1550:10b0:595:90ee:f46c with SMTP id 2adb3069b0e04-59590eef56emr1622417e87.9.1763450939127; Mon, 17 Nov 2025 23:28:59 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251020024049.6877-1-hupu.gm@gmail.com> <20251020101523.GE281971@e132581.arm.com> In-Reply-To: From: hupu Date: Tue, 18 Nov 2025 15:28:47 +0800 X-Gm-Features: AWmQ_bnpaW1CjmQjlnuuO40DoPt0fulVUcpqccYk7DiY3VQyUhoIIXW67rggKzs Message-ID: Subject: Re: [PATCH] perf build: Support passing extra Clang options via EXTRA_BPF_FLAGS To: Leo Yan , Namhyung Kim Cc: acme@kernel.org, adrian.hunter@intel.com, alexander.shishkin@linux.intel.com, irogers@google.com, jolsa@kernel.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mark.rutland@arm.com, mingo@redhat.com, morbo@google.com, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, peterz@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leo and Namhyung, On Tue, Nov 18, 2025 at 3:18=E2=80=AFPM hupu wrote: > > I then added KHDR_INCLUDES to BPF_INCLUDE, pointing it to the kernel=E2= =80=99s > self-contained header directory so that the build prefers headers > provided by the kernel. > > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 47c906b807ef..65c6e871988b 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -1202,7 +1202,8 @@ endif > > CLANG_OPTIONS =3D -Wall > CLANG_SYS_INCLUDES =3D $(call get_sys_includes,$(CLANG),$(CLANG_TARGET_A= RCH)) > -BPF_INCLUDE :=3D -I$(SKEL_TMP_OUT)/.. -I$(LIBBPF_INCLUDE) $(CLANG_SYS_IN= CLUDES) > +KHDR_INCLUDES :=3D $(abspath $(OUTPUT)/../../usr/include) > +BPF_INCLUDE :=3D -I$(SKEL_TMP_OUT)/.. -I$(LIBBPF_INCLUDE) > -I$(KHDR_INCLUDES) $(CLANG_SYS_INCLUDES) > TOOLS_UAPI_INCLUDE :=3D -I$(srctree)/tools/include/uapi > > ifneq ($(WERROR),0) > > > With this change verified, perf compiles successfully even without > explicitly specifying the cross-toolchain sysroot in the compile > command. > As an additional suggestion, I=E2=80=99d prefer to keep both the above patc= h and the previously discussed PATCH v3, which would mean submitting two PRs. From my perspective, allowing users to pass custom compilation options via EXTRA_BPF_FLAGS is more flexible than only configuring headers, so I=E2=80=99d like to hear your thoughts. Thanks, hupu