mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Archit Anant <architanant5@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
	 dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	 linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] iio: adc: ad799x: cache regulator voltages during probe
Date: Thu, 19 Mar 2026 08:06:50 +0530	[thread overview]
Message-ID: <CADJHxWCcdNTj_76jomZPW9ifojj0iuWsWYUtWkYxbp7M4CBtpw@mail.gmail.com> (raw)
In-Reply-To: <abq5dbYrYuq5DQ5J@ashevche-desk.local>

On Wed, Mar 18, 2026 at 8:11 PM Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
>
> On Wed, Mar 18, 2026 at 02:57:14PM +0530, Archit Anant wrote:
> > Reading the regulator voltage via regulator_get_voltage() can be a slow
> > operation. Since the reference voltages for this ADC are not expected to
> > change at runtime, it is inefficient to query the regulator API every
> > time userspace reads the IIO_CHAN_INFO_SCALE attribute.
> >
> > Determine the active reference voltage (either VREF or VCC) during
> > probe() and cache it in the state structure. This improves the
> > performance of ad799x_read_raw() and removes the dependency on the
> > regulator pointers during fast-path reads.
>
> ...
>
> >       case IIO_CHAN_INFO_SCALE:
> > -             if (st->vref)
> > -                     ret = regulator_get_voltage(st->vref);
> > -             else
> > -                     ret = regulator_get_voltage(st->reg);
> > -
> > -             if (ret < 0)
> > -                     return ret;
> > -             *val = ret / 1000;
> > +             *val = st->vref_uV / MILLI;
>
> Not sure I understand properly this MILLI in conjunction with FRACTIONAL_LOG2
> below. Is this simply millivolts? Then we have "(MICRO / MILLI)" pattern as
> of today to show that in a better way.

My bad, I thought you wanted me to use either MICRO or MILLI i.e the
fitting one
instead of 1000. I see this is the preferred way to show unit conversions.
I'll redo in accordance with this pattern.

>
> >               *val2 = chan->scan_type.realbits;
> >               return IIO_VAL_FRACTIONAL_LOG2;
>
> --
> With Best Regards,
> Andy Shevchenko
>
>


-- 
Sincerely,
Archit Anant

  reply	other threads:[~2026-03-19  2:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  9:27 [PATCH v5 0/4] iio: adc: ad799x: modernize resource management Archit Anant
2026-03-18  9:27 ` [PATCH v5 1/4] iio: adc: ad799x: use local device pointer in probe Archit Anant
2026-03-18  9:27 ` [PATCH v5 2/4] iio: adc: ad799x: use a static buffer for scan data Archit Anant
2026-03-18  9:27 ` [PATCH v5 3/4] iio: adc: ad799x: cache regulator voltages during probe Archit Anant
2026-03-18 14:40   ` Andy Shevchenko
2026-03-19  2:36     ` Archit Anant [this message]
2026-03-21 18:27   ` Jonathan Cameron
2026-03-23  7:55     ` Andy Shevchenko
2026-03-23 12:22     ` Archit Anant
2026-03-23 14:39       ` David Lechner
2026-03-23 17:55         ` Jonathan Cameron
2026-03-24 17:20           ` Archit Anant
2026-03-18  9:27 ` [PATCH v5 4/4] iio: adc: ad799x: use devm_iio_device_register and drop remove() Archit Anant
2026-03-18 14:43   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADJHxWCcdNTj_76jomZPW9ifojj0iuWsWYUtWkYxbp7M4CBtpw@mail.gmail.com \
    --to=architanant5@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®