From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755628AbbIWVUV (ORCPT ); Wed, 23 Sep 2015 17:20:21 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:36727 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753386AbbIWVUS (ORCPT ); Wed, 23 Sep 2015 17:20:18 -0400 MIME-Version: 1.0 In-Reply-To: References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-14-git-send-email-sudeep.holla@arm.com> Date: Wed, 23 Sep 2015 16:20:16 -0500 X-Google-Sender-Auth: F2m1XjD2344ugd7x3S4hxtHP9sM Message-ID: Subject: Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag From: Li Yang To: Thomas Gleixner Cc: Manoil Claudiu , Sudeep Holla , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Rafael J. Wysocki" , "David S. Miller" , Kevin Hao , "netdev@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 11:51 AM, Thomas Gleixner wrote: > On Mon, 21 Sep 2015, Manoil Claudiu wrote: >> >The device is set as wakeup capable using proper wakeup API but the >> >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source >> >which is incorrect. >> > >> >This patch removes the use of IRQF_NO_SUSPEND flags replacing it with >> >enable_irq_wake instead. >> > >> >> What would be the purpose of IRQF_NO_SUSPEND flag then? The flag is a >> friendlier API compared to calling enable_irq_wake(). For older kernels, > > It's not an API, it's just a bandaid for lazy programmers. > >> on PPC architectures, the flag did the job. When did this change? Since >> when using IRQF_NO_SUSPEND is a "misuse"? > > It always was. Simply because IRQF_NO_SUSPEND has absolutely nothing > to do with wakeup interrupt sources. It's a flag which excludes the > interrupt from the suspend mechanism, but it does not flag it a wakeup > source. It was not very clear on the intended use of IRQF_NO_SUSPEND at the beginning as it was not documented anywhere. It's good that we have the Documentation/power/suspend-and-interrupts.txt to clarify that now. Regards, Leo