From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82B693E3C7C for ; Thu, 16 Apr 2026 15:38:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.210.44 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776353902; cv=pass; b=tfh7smab+nyNj2xMV+tVGCXz6Nz0Mlq8GtfYk4VXWKLg/ta7JpJmRuYw2b1Z3QZYDRsFHZwhyHUmAMi4m27F1O1JOmjl91ED0c7zHbWCVvrQJfYSAtn4Ze59K7da8NB5d4tYnCOyePus9+y2eQ5W5Z2HWD169cTIYWAKg6R28Dc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776353902; c=relaxed/simple; bh=AWxB0J1B6KAtOPYtjfiwdJN7ZhgoPpnQloeJYrsQ2O4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=P9+Xpz6szQR6Xq8FSV6LE3RZTWlsjMiOxdXe75fwhRSDi1BoCOgE8X/+tqnDy/pTLO29ZE0weZQtHghhzYnO5sbQZSpQrYzNw/QAolP3htvAUwaThRTvN+z5PwfiyK8vX9WC9YUlm/gQG4uUwImwcizNEKNsCA6ivMdD6g2DCDc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=SBa1ougG; arc=pass smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="SBa1ougG" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7dbbe75715dso459307a34.1 for ; Thu, 16 Apr 2026 08:38:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776353899; cv=none; d=google.com; s=arc-20240605; b=L8jjTyoQ7BMjJ+TOilll3ZkWJZPSM7i8odV4CBPrxxgREOPBxsVQ/nKWG3yJVahUEg W6UyVpj8hBukQkSOgiDZRaqW02nLW29jzcOHh8gMHqS8M/kNTZNm+a6Wi9tCwtURw35s rkfwutggr3AL05o5+0BWM/b4BiK3GIWvnZpskJigRBONMSCHoSM4IrVVz9dCUHTPB+Zx n7lUWXt+7q2GVuk0AmusJzp7Agye73alREKBOsA25Mop+pZ+i/lKbZWI8uUfkOruWPxl J5A6ErL43pD05yCDy5RsMtU0hhF+FMIEbsg3CVVa0F3CCgWab2eCUk+sfDxeQHNsR2hr zOqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=rO65poDPP2TbW/BEGrFidJzuG0j5NALbmB0fqJgYvtc=; fh=gloS88lmYg44rPKlbVX6Ffn91O6iZa11ns4UqieS+Dc=; b=G+ZShP/asqYMAIfjZJzc7/Y0vZN7Y2hBjrePlHCaL7fLor4na17jcEQG32uT9nazlM 60MBu/RbxxWS53FkS1r8+LsoNgpVqfJrPVFYKu+BOv0XNNngpM7UkDA0gG2JvCdfgSoi m5+VtzVr5HSIt+eIJvwrLKhgrsWknX5lracaIEiaB2YDK4I0fKtABfgzMUVy0k++Rm2W zxPEFj/M7xfLAmwvHun29QBBU2uuF2jiGf3J7WnLrMZ+P28awSsyPO0S+mfGcu0IPmqL Jt1d5/hJmrAgn+ttXsQF8LLduuXSUpyTFiUpp9uyoL7mHwFdVsldtKalFqrlyWReN1QE 3cBg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1776353899; x=1776958699; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rO65poDPP2TbW/BEGrFidJzuG0j5NALbmB0fqJgYvtc=; b=SBa1ougGt7Bbg/L4kED8H3h5MfaSe8zEW2zCVcyWDN6Dph84xWvhl9657MApRlQvt+ n4hhbkWh7aDtMVG1O3zmKxxi8yUriEd69bkIGjGtZOvogAH1YSO5+oMA63gAwidGkvT1 w3tYInhOu/43JJqgVP34tfL0GLwuk0sxSpio8tJwU8YX1McRG6w8dBzSf3aEjEF9Y0lF hm5IY8O+hZtkX/rkdqag9dLTITeYY281rH+B+YVYX+ufk5ignirYLwXzJf8Xmdn0HkYr QkPr3GWe+1drXt2wb4/7l+E2Ku3DNhLMOkPxV2GTXbNQOxEUIHHjFlQI6iZg92DVW3h0 ZWxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776353899; x=1776958699; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rO65poDPP2TbW/BEGrFidJzuG0j5NALbmB0fqJgYvtc=; b=aM7x7C4iWM5iCcDtVo6zC4WanOBzBjBczfUMB228raE/+HmnoZTfBLDU3KP2N32ums VLGiHM6Tfwa5cE0PFUSYtuyM5jC3lSDsyXAwjhSisRTaEhoRhIiHGm8d2FgKw0fJBs8t Ie8qDOtkyAvof00/jrJkw8jklxoYeFDwteEMxKVNdArSRq8xH3m7SMd7tlMIYBNLyKCQ 1boUY0yHLpzkX5t8+Ctsep8UVlg92s90n+57Z0h6xv1a034PK9e+KaHi39P3+2qgu16K St7wi/X1dtFhOaVBYBzg7FJI2NMSHlZjHxTV6p+QP3thS+OhrMfpwoGmx3gSfgxImGnI cC2Q== X-Forwarded-Encrypted: i=1; AFNElJ8P/4aHawMNpMzSFnmoOgcyPgGQL4pgcIAw9Pw4c0Vte3aPxZ/IZ9NYaw5nYxkd5S6hVG8Sji72Omx9Gh8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4VqzFK2lvV8fg/iBE+oI/uvi9MzQqd8oaZsadPWdE1fgnJqZX 5Qz8HMwg9PL3jwJUgfqrqomrrqNZ17GxhK22t687tuU48dclVGA1ImnD0HMjHgBSGQ1oijPSKTq HZbKbpsOsVKdhszY9HuA5Tbpvh8Fx6Ft54CYqg/oFEA== X-Gm-Gg: AeBDiev19g9mSDTB8GwEquJigF16tp+5ffFxhjRelNbrBOsrNwfTgwPrO9PPrLQyT99 q8TWmh2oYhfGDZFPUCEdp0hWBNunZVBbEhmVws8F9YB5U0PtfpwUbL1absVUbv96hbEe3TmuoV2 MCyqlHY8aWBhoZ/K9MewOhZSSFGW8tyjj+0zx2PCgHeyNusd+rxne1yiUBId6w0V+p8wgt8MxdD k+WNBO6Nys4+ycQMuPxBjJ/BOOst5mCNCWClxGyYxdje3YcUFovfvrQqUndXAuKYdNHOUjkt3Qw 5aXKmVH4EoFL9hZllA== X-Received: by 2002:a05:6830:348c:b0:7d9:b338:a669 with SMTP id 46e09a7af769-7dc83cf961dmr1163907a34.2.1776353898946; Thu, 16 Apr 2026 08:38:18 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260415210847.1730016-1-csander@purestorage.com> In-Reply-To: From: Caleb Sander Mateos Date: Thu, 16 Apr 2026 08:38:07 -0700 X-Gm-Features: AQROBzAYjsmVYKZSSCDVvPyzGlyPCSBq9VE4-_297gBMh499ii0YGZaNdUE1y0s Message-ID: Subject: Re: [PATCH v2] t10-pi: reduce ref tag code duplication To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Anuj Gupta Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 15, 2026 at 10:18=E2=80=AFPM Christoph Hellwig wrote: > > On Wed, Apr 15, 2026 at 03:08:47PM -0600, Caleb Sander Mateos wrote: > > #ifndef _LINUX_T10_PI_H > > #define _LINUX_T10_PI_H > > > > #include > > #include > > +#include > > We must have already gotten this implicitly given that the code > already uses lower_48_bits. lower_48_bits() is defined (and only used) in this header. Yes, wordpart.h is already transitively included by the other headers, but I think it's good practice for each file to explicitly include the headers defining all the items it uses. It reduces the risk that refactoring the other header files in the future will result in a compilation error here by dropping the transitive include. Thanks, Caleb