From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83163387590 for ; Mon, 12 Jan 2026 18:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.82.49 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768242578; cv=pass; b=k/1VdTVB1nXDSQOiXIYLEFhodhNrrNE38taSuaX2utOQeYKeu+vhFLdkcg59Pqw5H9wbnW8hCAsvL9mFOUMdQ3ufHw/iCrieN4/A3BjhHbIqaxvpH6CEwjxccOfDzZxPG/jSdu62ew2Fbp4V2dlh2Uc3bDXp5Xpfjch6RFaWVxU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768242578; c=relaxed/simple; bh=FUpHOPt4IEgZcX0r1LogNpavV3zSOIqpKbst42N5uaA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=F00JMudaqBnGaRgzhQM0TW37fpaS9w1mk+nxchBO/j3BeZTvdQpS6zV3SozZimu78MDUxnZlKJBApgziIPRehA3XxY9MJZNhUNk7SZ45N2PfNkrvPv2CHGfK9c45SU5fl/TAhWhv9p14eW7RPJHPDpvrbPdm420vmDGYKYpi4TE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=EWhXdRjy; arc=pass smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="EWhXdRjy" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-11ddccf4afdso464455c88.3 for ; Mon, 12 Jan 2026 10:29:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1768242576; cv=none; d=google.com; s=arc-20240605; b=fJXlA0vF8X8fRfnSNqYToBT7C6TL4JnInCVJM761zZf+gMkrcTgZr5lICmHDb9Fnih K/5jBdH8N9fTdz5grnNEj8d8GMXvba1Qna3NBwaea8InVb8bhHA36mhwlCFV9KnmMDro 1oZPzKOZ+wEfdb5Ia5PBxAOSKLpr2dNcZoSpAandXTD/eEDMiZLRpEwlyFaWiDpSWWZz u+J2LgIKvC87TWl5911Fl4yLJrMExLLGe/zBGlSkWndiSBd63JWYwgdjawYQbK0Q+psa MsuScKNi6bzdzaKS4175FQ8I8USUE+0hYb3dmkzr7bjNsymL7uZY1mOKp3jBBpCDK0r+ pbuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ogd853Kk4ubl3A3TV6d4A1RR6W2yCsORLXTCLFqIUIY=; fh=ep4Tdl8iMCyjmf6KZw3uv4TU/TSjxpFET7kMweceRX0=; b=RHb4hGMKdGD7JA++woJWxpCw0LvZ85moSM7/4vHmZn0qe2i43JA/RCy1pn8zZIJkI8 7MKBFAqdh5SfnDXcjwnaeiFzBWSiIprOR3udHdKprSNO0jzgmI7K7XYy2qLqJh/1n26+ tMHB4IAxLGt0FJAUM9LA5R7TOX2DYA8Seoh2qooSUJMKUDKCcG+8I3ixCsV/LQgBpJwP e6Zjx9OcC3JA4dc5sERR3qYpQvk84ewMuHQYmfUBzbLoXU8s6CCSCrvPezvt1x/RU8cV ygltB7oeEd/C8BtddUvdK8szrTESIhLUD3iPNakvHET50jW6Ea+m+j7bszdfSll5vIrD ahpw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1768242576; x=1768847376; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ogd853Kk4ubl3A3TV6d4A1RR6W2yCsORLXTCLFqIUIY=; b=EWhXdRjys9U8oWSyDTKqpLqI6y+xeaKZtwZpPmqFp5pxgmIr1Is4buV5af6J7vF4E4 7us5kPcrne6eIELwDZ5nX+iYfpFUAiTuUaqqH4D9Vy7W6OQKFzMt240v91xLlFjrzLqo gqy30lh+2VoCu6lNptgZYMqMXmFFbKaa202Eu88pEirKcOG21FmoYq+D5UJHAzCGwMRU sQ3EeCpDsUZ2CPUqudmt8uRHlmbg4Cejh26Fa0GV29HPXIUMQP59YRWfYg+SXlQ6L69L +8191zi939GwNNMzzRbSs22cghb7k8zQD+g65Hn9zmPLLlfvNbn9hCZlTUXGLVuWWwy9 dDmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768242576; x=1768847376; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ogd853Kk4ubl3A3TV6d4A1RR6W2yCsORLXTCLFqIUIY=; b=cbHylM5tv60xd0OOi9VKR46rqaF+b/vqzUU4nRaEP2zZy0S0yG4DU3q1ReJ0Ndircs DXzGUDbcN9XzX2ox4dOqmBCsNVJGrkOeaHVvEcZnoU6kL3xI0xQE0IoM6Qg3ZLi6zImz qY3GCNKovpUSh/SBAAijMCn00f82RkMSyyGPYHy/n36rAXJWubtWmDw89WMEJfovSTXj k9LBoHmOPvEW91NVuVN5mF2U9snf9h0tteLACbMAUdhgpNdFPtzwiDre5K+LGwE+VeNd qaaxXcw8SGGCg5IqXa7qQTfaJSw63hSiJZJOlp3CvL/aiYxWutqwoOnulQXbdBg8pjlw KY3Q== X-Forwarded-Encrypted: i=1; AJvYcCUhvEVWLlXKllhFTKstmtjd+qX2S44cEDXsrTSkw+AG0Grog2EGAlf73GfShDc/0uOJ+vVxOKuC1dLWwMI=@vger.kernel.org X-Gm-Message-State: AOJu0YyxEeTfRGwzSYwGcwxz6jtKbmtpPMpyovzODBDHDwpLoxXvYaRH IaH9hm0Cccugqpu4uA0QCyy9k8oF8IrnBqGepPGoV6yaui2yfwBxfG4mVc2eIVxVYnhEa53wc1p 4m29+FmgLkL/vlUsiNprJSNmhZEsuHrDYOLNd9bUX7g== X-Gm-Gg: AY/fxX75xrTy+wXMifa5KEoDVuCNRY4oWYK8kKLHKZlqia4dHO6Np8ou/eXdGVyi8bt Ys7V2tQk8vv3PJlgplui3ohqoO81kUJL1t1ko08PPH54qBM4+l8RsX6GLDr5YEzKEjKRBb0clax IHY+S4Q9RM4qMaJM6n/b/cA/nl2xj7t+MOhZ5sn7rry+kJ9cg8uxB0cJw1wAyYoWcTPV3v0j81p MZXkOJ9tZx7t3RO2ggK6w5TJJhBghpq4Xu1vgfEFBMpDJ7N9nYgGw3BDoZluJM3Eb4gsEy+ X-Google-Smtp-Source: AGHT+IHM5mdp2ESFbQnQHup/EVrjeLulpF3EjsgWvB8/FOYUzcdsyBgaH98XYKE3lyl6wNQPNUR2nsmM6vwuE9x3X7k= X-Received: by 2002:a05:7022:799:b0:119:e56b:46b7 with SMTP id a92af1059eb24-121f8abf499mr10911260c88.1.1768242575232; Mon, 12 Jan 2026 10:29:35 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260108091948.1099139-1-csander@purestorage.com> <20260108091948.1099139-9-csander@purestorage.com> In-Reply-To: From: Caleb Sander Mateos Date: Mon, 12 Jan 2026 10:29:23 -0800 X-Gm-Features: AZwV_Qide7yvit3jonWa-fQp0nnmgkkOuuK8FL6QKxDxsErOmM1S8B6V58DEkss Message-ID: Subject: Re: [PATCH v4 08/19] ublk: move offset check out of __ublk_check_and_get_req() To: alex+zkern@zazolabs.com Cc: Ming Lei , Jens Axboe , Shuah Khan , linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Stanley Zhang , Uday Shankar , "Martin K . Petersen" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 12, 2026 at 10:17=E2=80=AFAM Alexander Atanasov wrote: > > On 8.01.26 11:19, Caleb Sander Mateos wrote: > > __ublk_check_and_get_req() checks that the passed in offset is within > > the data length of the specified ublk request. However, only user copy > > (ublk_check_and_get_req()) supports accessing ublk request data at a > > nonzero offset. Zero-copy buffer registration (ublk_register_io_buf()) > > always passes 0 for the offset, so the check is unnecessary. Move the > > check from __ublk_check_and_get_req() to ublk_check_and_get_req(). > > > > Signed-off-by: Caleb Sander Mateos > > Reviewed-by: Ming Lei > > --- > > drivers/block/ublk_drv.c | 16 +++++++++------- > > 1 file changed, 9 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c > > index e7697dc4a812..8eefb838b563 100644 > > --- a/drivers/block/ublk_drv.c > > +++ b/drivers/block/ublk_drv.c > > @@ -253,11 +253,11 @@ struct ublk_params_header { > > > > [snip] > > > @@ -2603,13 +2603,10 @@ static inline struct request *__ublk_check_and_= get_req(struct ublk_device *ub, > > goto fail_put; > > > > if (!ublk_rq_has_data(req)) > > goto fail_put; > > > > - if (offset > blk_rq_bytes(req)) > > - goto fail_put; > > - > > return req; > > fail_put: > > ublk_put_req_ref(io, req); > > return NULL; > > } > > @@ -2687,14 +2684,19 @@ ublk_user_copy(struct kiocb *iocb, struct iov_i= ter *iter, int dir) > > > > if (tag >=3D ub->dev_info.queue_depth) > > return -EINVAL; > > > > io =3D &ubq->ios[tag]; > > - req =3D __ublk_check_and_get_req(ub, q_id, tag, io, buf_off); > > + req =3D __ublk_check_and_get_req(ub, q_id, tag, io); > > if (!req) > > return -EINVAL; > > > > + if (buf_off > blk_rq_bytes(req)) { > > + ret =3D -EINVAL; > > + goto out; > > + } > > + > > Offset is zero based, bytes are count so it should be >=3D here. > > It will work this way but for buf_off =3D=3D blk_rq_bytes(req) user will = get > 0 instead of EINVAL. This is the existing behavior in __ublk_check_and_get_req(). I agree allowing buf_off =3D=3D blk_rq_bytes(req) seems odd, but changing it now could break ublk servers relying on the current behavior. Best, Caleb > > static size_t ublk_copy_user_pages(const struct request *req, > unsigned offset, struct iov_iter *uiter, int dir) > { > size_t done =3D 0; > ... > rq_for_each_segment(bv, req, iter) { > ... > if (offset >=3D bv.bv_len) { > offset -=3D bv.bv_len; // bv_len is same as > blk_rq_bytes(req) > continue; // this breaks the loop when =3D=3D > } > ... > } > return done; // done is never incremented > } > > > if (!ublk_check_ubuf_dir(req, dir)) { > > ret =3D -EACCES; > > goto out; > > } > > > -- > have fun, > alex >