mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Samuel Abraham <abrahamadekunle50@gmail.com>
To: Erick Karanja <karanja99erick@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
	 philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: Rename variables
Date: Wed, 26 Mar 2025 09:05:55 +0100	[thread overview]
Message-ID: <CADYq+fa2T5k73ckaTgW36wM1BMNRQvYB+oO2fGYFOjvLH76WVw@mail.gmail.com> (raw)
In-Reply-To: <20250326072842.10344-1-karanja99erick@gmail.com>

On Wed, Mar 26, 2025 at 8:29 AM Erick Karanja <karanja99erick@gmail.com> wrote:
>
> Rename the variable `mediaStatus` to `media_status` and variable
> `lpsVal` to `lps_val` to adhere to Linux kernel coding
> standards by using snake_case instead of CamelCase.
>
> Fixes checkpatch.pl warning:
>         CHECK: Avoid CamelCase: <mediaStatus>
>         CHECK: Avoid CamelCase: <lpsVal>
>
> Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
> ---

Hello Erick, I think what Julia is explaining is that you should write
your changes in v2 here where I inserted
this message to you. Not to remove it entirely. Am I right Julia?

Adekunle

>  drivers/staging/rtl8723bs/core/rtw_btcoex.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> index d54095f50113..f4b19ef7b341 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> @@ -8,14 +8,14 @@
>  #include <rtw_btcoex.h>
>  #include <hal_btcoex.h>
>
> -void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus)
> +void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
>  {
> -       if ((mediaStatus == RT_MEDIA_CONNECT)
> +       if ((media_status == RT_MEDIA_CONNECT)
>                 && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
>                 rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
>         }
>
> -       hal_btcoex_MediaStatusNotify(padapter, mediaStatus);
> +       hal_btcoex_MediaStatusNotify(padapter, media_status);
>  }
>
>  void rtw_btcoex_HaltNotify(struct adapter *padapter)
> @@ -52,14 +52,14 @@ void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable)
>  void rtw_btcoex_LPS_Enter(struct adapter *padapter)
>  {
>         struct pwrctrl_priv *pwrpriv;
> -       u8 lpsVal;
> +       u8 lps_val;
>
>
>         pwrpriv = adapter_to_pwrctl(padapter);
>
>         pwrpriv->bpower_saving = true;
> -       lpsVal = hal_btcoex_LpsVal(padapter);
> -       rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lpsVal, "BTCOEX");
> +       lps_val = hal_btcoex_LpsVal(padapter);
> +       rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lps_val, "BTCOEX");
>  }
>
>  void rtw_btcoex_LPS_Leave(struct adapter *padapter)
> --
> 2.43.0
>
>

  reply	other threads:[~2025-03-26  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26  7:28 Erick Karanja
2025-03-26  8:05 ` Samuel Abraham [this message]
2025-03-26  8:15   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADYq+fa2T5k73ckaTgW36wM1BMNRQvYB+oO2fGYFOjvLH76WVw@mail.gmail.com \
    --to=abrahamadekunle50@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=karanja99erick@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®