From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A934358D37 for ; Wed, 29 Apr 2026 02:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.173 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777428116; cv=pass; b=ZFprL3vtlaugLHJYebHzIIrYIjRJTR/aaTnNmedFyRHr+FpQGxXQM8l/v/ctW90AbbWNe7/zQ4xSzDsrhsonBvfH4TqkWqiEwZY4VlzG73fTCtKsbRzYXoN9BwMpIAy2r0dHbbMcLHYKHwRFhTCTSMQOswnN42DtbYXc2qKaIOY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777428116; c=relaxed/simple; bh=gzUNhxZ3fhsVHj081BKhGFEpLe3M9C3PO0A0qmW6Peg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ct6qeBZiVc9F81IQLI4dSG87NhJ0DuCpec+noJgQ3emyAK+GJw/Fq7rqtmU0uWdgmcOjG/3ZfDY68Twdoekyb2l0h7Pn4GijUEvQkp/t04w5kVlfPDj57yrtVt9E137/Z3Yrqqp1wAZgVmE+HqPW48A+Qe3ulHj0b7cO1aM3GU0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JNHPLET1; arc=pass smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JNHPLET1" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-79db5e18ac6so5298647b3.1 for ; Tue, 28 Apr 2026 19:01:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777428114; cv=none; d=google.com; s=arc-20240605; b=B7FABdITdzjOUNAfic43sdpPsyC1kf/gvm54UvGf+GDiktO1BpBlQ6TpPK04JmZsw6 kZEP21nF9GiJ6GkVSIw/njiwaZaFfQzdRKtLdtCGFcwzcQyoYlbtWY+BQMfdZ18jxLO+ vLnoQ5AqheO/gMnnJoSzXO8NDDoGQCBgGzEqkOSae4dMNY/rXX3l758cluTaqZk7joto 6oOooYeVAxCcx9I+NbvH0WI3wJNcms+btvYsOu8l6LKAq7UWZHIqdklweiirQ2rzQt34 Nyiqu5vKEOtNxcZY/fD5H8y3EoJSvWznldsLc+LUDrwtoA5YR205OZubPr4J2ltIGzPv 0Mxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=WhiOa3S5gTJr0LR+yeY23Dq+ec8CEArjxBM7MxSqTIk=; fh=hr1JsQktec2LSwHOt0AXlQ5wElhTeKIeVx2A9K27sac=; b=R2KPLirf6V5haNE9vli32PyIr2biiAiljS8FnXR1KyiCGIzZjJ2og1ZYnZ3NRlGDYX tfAeVZ+9WLHVCz4SgdXgp36fGB9nCTy5nFPY0tTr7rF6SFrWEujwjILlB9NxmtB3jtqJ 87XT9Lu8HZq2ZZsgkaHR8xsNI9b4cc/1XZkdXdCX5DCAmMxIzv9npRICctBUVF9i8YOG gls3jgXztG2OIIO7P5bK7z4bIn2gIcwIBLFIfCjQmfQqsn3jAcpOnhwIs2G0+6wy8A5L Qqg7oCjQNbzW8RLuNRGzUev/UwpDfjxZ2kXmlK4vlh3gksCNkshGG+rZMDEqCzMBdTSq /B1w==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777428114; x=1778032914; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WhiOa3S5gTJr0LR+yeY23Dq+ec8CEArjxBM7MxSqTIk=; b=JNHPLET1ipY7DaD5FQuh59Zox22uT+R0p+5trxiKKRX2WF1PakhbcS01r1tjndLpL+ 61x5tZsX2suJxQgwhMtGdfu9wl8a5bGLOEdt8rIWIt5XsLtO+38asRlVZ046SJdrDEUR 01ULXQiX9DEymeRBzoQ2kB2OI1/5K6s3ozFG6cCP9QxfDgNQpvqzGvo6JxH+GkI9goXA ku2Ly9Ft8sb4HwZUAPmYGyG4ARzsin2mSNHYCF1Qf6cbhck9hMhCE56gw/MhHmu47zCY aCgWPAMiXLnGNYLLdAarOh7rh7uIwjDMWhoOcxLmGmFzFvKIXpqOpF6eSPLfewiTg4/L sRBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777428114; x=1778032914; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WhiOa3S5gTJr0LR+yeY23Dq+ec8CEArjxBM7MxSqTIk=; b=s9qoM8ABHdAmv71hrsVB/r7/vnSYSIKPjuxsDHRtqexjBnekFBm1sT9i8ya6Sn3OJZ bdcuS2RzFnOXp/mJWG3ZreJGt201aOdPOjGR0OCTxE6kjMnQh2Wd99c5+K6KzKPJrvKc ormkPgU7AWnRFyawQWBXI2tzJJS2soppf8nlQWk4n5aR91imJLpBV6DT4pbnuWYDHrV3 AMmBDe+EYxiL81oVOH5nCjQ5KnDZ2ak2uhnBCibD4G/eLoFz1mPxWqh93xX4kFaCwgO6 tkECdKYf4aFjeBne150kg5QJu8SKF4Tbcszpj9lvrmGEv1y9TVww+YJVG8p/p4F28XzK lrWQ== X-Forwarded-Encrypted: i=1; AFNElJ8aC+LvUgNjFEGSYqHM8PnfkDj7QnccWW4SMYl9Nn7QJy/omDqd1FZb9nFRr6BMVnY4pdLkR0eUq+AED3A=@vger.kernel.org X-Gm-Message-State: AOJu0YyxTZIv5HyKR+2m9A2fzpiQpHp8VCMVG/CiGTCp4mBiCunXpYHb peE/xXjzDp6PGuKVSBGMaAQPTikBuwJl4bu2pEIN4/Ii/pgkjrmsPzyuZzFVSWLHQywhWq1HA4z vbB6DaNoe71nXRlYj2Wvrcxu0xMCBcFE= X-Gm-Gg: AeBDiesOe1NkkigeVxi4X3O9RGl0iv2aHceUNnatEGupOc+gYv92Ay48H64pVWAUVWA 5JuhKfBGSUKmEpogvsM4pawxYdzY4pf13heFVOGwDJJn/SrWbKA5/TBPVLmVKuKv7syqYwIONox a9mOv4pPIsoZi/jzAtiscIcvQH20wtjhm4t1RJoIGfQS6QUiw2iZOL94eIFniYQEdLmAP4FXRWG 0XHihVPu4n6L5YPD+7f1gNfO4mqNctk+XAoxyaGZ7yj3YIhTYjSbpD7ZXpWinKI0fe+4uqMKvPW /BBYrRvDVNjGmq1ZYR6Jwh03wlNMSvn4bj3gorck6k+gclKf/hQXN/rZW7mwZABkZJThqK04HIf mWYBgaV4= X-Received: by 2002:a05:690c:6610:b0:7ba:ff4b:553e with SMTP id 00721157ae682-7bd23d468bbmr10495807b3.8.1777428112698; Tue, 28 Apr 2026 19:01:52 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260414020947.65905-1-kartikey406@gmail.com> In-Reply-To: <20260414020947.65905-1-kartikey406@gmail.com> From: Deepanshu Kartikey Date: Wed, 29 Apr 2026 07:31:40 +0530 X-Gm-Features: AVHnY4K1dTlwHvFNyxRAmA8eoedys5dPDggZK8_JRPj9HAqQmEbRIFf8AGQP_dM Message-ID: Subject: Re: [PATCH ipsec-next v3] xfrm: cleanup error path in xfrm_add_policy() To: steffen.klassert@secunet.com, herbert@gondor.apana.org.au, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, sd@queasysnail.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 14, 2026 at 7:39=E2=80=AFAM Deepanshu Kartikey wrote: > > Replace the open-coded manual cleanup in the error path of > xfrm_add_policy() with xfrm_policy_destroy(), which already > handles all the necessary cleanup internally. This is consistent > with how xfrm_policy_construct() handles its own error paths. > > The walk.dead flag must be set before calling xfrm_policy_destroy() > as required by BUG_ON(!policy->walk.dead). > > Signed-off-by: Deepanshu Kartikey > --- > v3: > - Changed prefix to ipsec-next as this is a cleanup > - Dropped syzbot references as suggested by Sabrina Dubroca > v2: > - Reworded commit message to reflect cleanup rather than bugfix > as suggested by Sabrina Dubroca > - Removed incorrect Fixes: and Closes: tags > - Corrected subject prefix to PATCH ipsec > --- > net/xfrm/xfrm_user.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c > index d56450f61669..ae144d1e4a65 100644 > --- a/net/xfrm/xfrm_user.c > +++ b/net/xfrm/xfrm_user.c > @@ -2267,9 +2267,8 @@ static int xfrm_add_policy(struct sk_buff *skb, str= uct nlmsghdr *nlh, > > if (err) { > xfrm_dev_policy_delete(xp); > - xfrm_dev_policy_free(xp); > - security_xfrm_policy_free(xp->security); > - kfree(xp); > + xp->walk.dead =3D 1; > + xfrm_policy_destroy(xp); > return err; > } > > -- > 2.43.0 > Gentle ping on this patch . Please let me know the status of this patch. If anything is required from my side Thanks