From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933100AbcITPvu (ORCPT ); Tue, 20 Sep 2016 11:51:50 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:34447 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933067AbcITPvs (ORCPT ); Tue, 20 Sep 2016 11:51:48 -0400 MIME-Version: 1.0 In-Reply-To: <20160920154931.22801-1-colin.king@canonical.com> References: <20160920154931.22801-1-colin.king@canonical.com> From: Alex Deucher Date: Tue, 20 Sep 2016 11:51:47 -0400 Message-ID: Subject: Re: [PATCH][V2] drm/amdgpu: avoid out of bounds access on array interrupt_status_offsets To: Colin King Cc: Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Ken Wang , Maling list - DRI developers , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2016 at 11:49 AM, Colin King wrote: > From: Colin Ian King > > The check for an out of bound index into array interrupt_status_offsets > is off-by-one. Fix this and also don't compared to a hard coded array > size but use adev->mode_info.num_hpd instead. > > Signed-off-by: Colin Ian King Applied! thanks, Alex > --- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c > index d3512f3..4ce4c1a 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c > @@ -2782,7 +2782,7 @@ static int dce_v6_0_hpd_irq(struct amdgpu_device *adev, > uint32_t disp_int, mask, int_control, tmp; > unsigned hpd; > > - if (entry->src_data > 6) { > + if (entry->src_data >= adev->mode_info.num_hpd) { > DRM_DEBUG("Unhandled interrupt: %d %d\n", entry->src_id, entry->src_data); > return 0; > } > -- > 2.9.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel