mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Martin <consume.noise@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Andrew Duggan <aduggan@synaptics.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Peter Hutterer <peter.hutterer@who-t.net>,
	linux-input <linux-input@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/7] Input: synaptics - Remove X250 from the topbuttonpad list
Date: Fri, 27 Feb 2015 11:22:04 +0100	[thread overview]
Message-ID: <CADscph1hyBDGS1Eh9_MSbZfE2sLy+SH+eC0wSNC+LEEt8WtFMg@mail.gmail.com> (raw)
In-Reply-To: <1423760953-30365-1-git-send-email-benjamin.tissoires@redhat.com>

On 12 February 2015 at 18:09, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> Lenovo X250 has a PnpID of LEN0046, but it does not have
> the top software button requirement.

Confirmed.

> For the record, Lenovo T450s and W541 have a PnpID of
> LEN200f and LEN004a, so they are not on the top software
> button list.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>
> Hi Dmitry,
>
> we got our hands on 3 new Lenovo laptops, and only one appears in the
> top buttonpad list. Again no need to CC stable this one I think.
>
> Cheers,
> Benjamin
>
>  drivers/input/mouse/synaptics.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 7267738..fa3d683 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -184,7 +184,6 @@ static const char * const topbuttonpad_pnp_ids[] = {
>         "LEN0041",
>         "LEN0042", /* Yoga */
>         "LEN0045",
> -       "LEN0046",
>         "LEN0047",
>         "LEN0049",
>         "LEN2000",
> --
> 2.1.0

Reviewed-by: Daniel Martin <consume.noise@gmail.com>

      reply	other threads:[~2015-02-27 10:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 17:09 Benjamin Tissoires
2015-02-27 10:22 ` Daniel Martin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADscph1hyBDGS1Eh9_MSbZfE2sLy+SH+eC0wSNC+LEEt8WtFMg@mail.gmail.com \
    --to=consume.noise@gmail.com \
    --cc=aduggan@synaptics.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®