From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69498C433F5 for ; Wed, 16 Feb 2022 02:43:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343826AbiBPCnx (ORCPT ); Tue, 15 Feb 2022 21:43:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240774AbiBPCnw (ORCPT ); Tue, 15 Feb 2022 21:43:52 -0500 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7988FBA49; Tue, 15 Feb 2022 18:43:40 -0800 (PST) Received: by mail-ej1-x643.google.com with SMTP id d10so1308684eje.10; Tue, 15 Feb 2022 18:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EDJssklYQD1n4k3ObsN0bw+9i+I4dsggbJJR//VLJ20=; b=Zl1xm3D354LVEdk6A1RDC5V8EuHE+coeR6zi4f0ARUyC12YBR5vOArEE//4Cxtn5dO qvndiWQPdZjG/DshCt1bSFTLc3Uaw/nW6gR5jGrwlVvJ4nt74WaIuvevEnojDkK43bZu fnq2ND1g5TP0M5VqS0orFL5ClL2EHaeOu6aPBtOgTE8Oy7Rhrfj41XoFk6vyzX/TrWxS wsBGMaDKnQlYQm3SViOfnND/9w1pqDBt31O+4A40ijW1hj8rjwMVDkmzAtt11XC6cuZW NHEwGGp3PQefrt8IjH1Qhk6UFcphAIMTHBsbc1r8Vy1eYQK0FUA5NSfCl0h+hQZjtj1B gfng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EDJssklYQD1n4k3ObsN0bw+9i+I4dsggbJJR//VLJ20=; b=XWFemS6nOlz5cmPfIqG4iW4g+LOUPP2UcGeIyKLNUp9LiJT92cxk+QJbEANztztPKO 7aQ2I9zZ0Ez0UdSos1qfbBofFlDROcbIz5z5YCHSBhza+RY2k180+lgiiRs37D+LiFAC UxpChbbCuolR/XSHg5bI/GwTxthPyDpwfn1IKcVzzLQYBJ+/G2JHdB8rd+M05XDdgy6T FbWW/exqe0uGwdMRyRAe1cPU4lHYBRMvhXuEUKmJAR0fn6I+gSt/ep8i78Hh4eefLe9g R0R/9J5vVYBXjfsMw8rr9gEVlmbrblvMLDb1iFEJNJgv+Wm0BZiHIHnazjH5hZyNCnxD yQbg== X-Gm-Message-State: AOAM532ZJkUnuU4zfzZAPI7p+SPGl/+Y2NSWhdXj3g3eUzMjAIqVUnBQ yRAuDDOVWAcABCrqwS1OgV0sf38iBgqr3RQVSp0= X-Google-Smtp-Source: ABdhPJxkhm7FKRBh+yyBJ1rNwZFW3Xhyw+ayQ2oppPG4d4kbp1nasELqUQ+uZz+N2pXbirXgW6PySSHKLyIXoVl2hko= X-Received: by 2002:a17:906:4cd2:b0:6c8:7a90:9c7 with SMTP id q18-20020a1709064cd200b006c87a9009c7mr612436ejt.439.1644979419568; Tue, 15 Feb 2022 18:43:39 -0800 (PST) MIME-Version: 1.0 References: <20220215112812.2093852-1-imagedong@tencent.com> <20220215112812.2093852-2-imagedong@tencent.com> In-Reply-To: From: Menglong Dong Date: Wed, 16 Feb 2022 10:38:28 +0800 Message-ID: Subject: Re: [PATCH net-next 01/19] net: tcp: introduce tcp_drop_reason() To: David Ahern Cc: Eric Dumazet , Jakub Kicinski , David Miller , Steven Rostedt , Ingo Molnar , Hideaki YOSHIFUJI , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Menglong Dong , Talal Ahmad , Kees Cook , Ilias Apalodimas , Alexander Lobakin , Kumar Kartikeya Dwivedi , Antoine Tenart , Sebastian Andrzej Siewior , Paolo Abeni , Yunsheng Lin , Arnd Bergmann , Yajun Deng , Roopa Prabhu , Willem de Bruijn , Vasily Averin , Cong Wang , Luiz Augusto von Dentz , LKML , netdev , bpf , flyingpeng@tencent.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 16, 2022 at 2:47 AM David Ahern wrote: > > On 2/15/22 10:34 AM, Eric Dumazet wrote: > >> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c > >> index af94a6d22a9d..e3811afd1756 100644 > >> --- a/net/ipv4/tcp_input.c > >> +++ b/net/ipv4/tcp_input.c > >> @@ -4684,10 +4684,19 @@ static bool tcp_ooo_try_coalesce(struct sock *sk, > >> return res; > >> } > >> > >> -static void tcp_drop(struct sock *sk, struct sk_buff *skb) > >> +static void tcp_drop_reason(struct sock *sk, struct sk_buff *skb, > >> + enum skb_drop_reason reason) > >> { > >> sk_drops_add(sk, skb); > >> - __kfree_skb(skb); > >> + /* why __kfree_skb() used here before, other than kfree_skb()? > >> + * confusing...... > > > > Do not add comments like that if you do not know the difference... > > > > __kfree_skb() is used by TCP stack because it owns skb in receive > > queues, and avoids touching skb->users > > because it must be one already. > > and it bypasses kfree_skb tracepoint which seems by design. Do you mean it shouldn't be traced here? According to my understanding, __kfree_skb() was used in the beginning as skb->users aren't touched by TCP. Later, tcp_drop() was introduced to record drop count to the socket. Considering the skb is indeed dropped and no other event is triggered, is it ok to trigger the kfree_skb tracepoint? Thanks! Menglong Dong