From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD179C433F5 for ; Thu, 21 Oct 2021 17:35:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C7856135A for ; Thu, 21 Oct 2021 17:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231905AbhJURiA (ORCPT ); Thu, 21 Oct 2021 13:38:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231281AbhJURh4 (ORCPT ); Thu, 21 Oct 2021 13:37:56 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4479EC061764 for ; Thu, 21 Oct 2021 10:35:39 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id x27-20020a9d459b000000b0055303520cc4so1250905ote.13 for ; Thu, 21 Oct 2021 10:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=fbDFAc+mDq/fVlQikhm/5WQdU+2NWEk3ZHERoK3qaZA=; b=VBX5aufNkoMTHFbOeGP+BrNRxy6MhOc+43NPA0e5hUPwm9iWg/SsllI1Hq9Jf1+q7p 3HcV/SKBuJnEHelkApbMambF9Q9KZQTRN/6BEeQVzVE1TOq6F2O6GHlAlLHtU4ow2K6P nWnYDrKsVlcUsa1XWYewK+/SxVlnZH4fPyUWI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=fbDFAc+mDq/fVlQikhm/5WQdU+2NWEk3ZHERoK3qaZA=; b=AzGwFTwFdIsrJjdsOqta7JlYbtrZJoKUSUQAt+31SMQ3wj9o8aGh8MdrMc8uiQfZ2o r8ZeOc/qHvkZYbdiRFJRvzIEBjoelcdz819ep+oVYy8TG1lQHerr3B1zZjSi+9lV+AuD oUcta6kjynldNHVuH/LmEyB7mPr7RUGR2On/R+ZuzVVOgWimY8oF7L/W14iULaJBneFa 9xTYtuMOlfP6+kMGL6E85wbhD9SkySiZQCeV2iPubIBmZdZ3pZajczIUpPS4yF8SlzhV YiQC/REVjKe0rEVZCpqODjlpO7qsjh0A5LSuemzTd0qyHHWGj/AGyLXGXE3rSvyDsUbG bY7Q== X-Gm-Message-State: AOAM530PQHbjlyZnV9omL6YV/+qMPvafkf7LOrNiDnJhGZVcfFgGXkhI mEOFE2ea8UDkUyh/42kntosDX9Xr18zgkNk2cIdkvQ== X-Google-Smtp-Source: ABdhPJzjOv9nA1sQ7Cd9uU8D7zcDzSeZPBApL3N+RjvJrY2ioR8BM3fhxRdxBOH/LurEUUwnPniIQrdfx5D/FoBW03Q= X-Received: by 2002:a05:6830:4187:: with SMTP id r7mr5956450otu.126.1634837738629; Thu, 21 Oct 2021 10:35:38 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 21 Oct 2021 10:35:38 -0700 MIME-Version: 1.0 In-Reply-To: <1634711785-25351-1-git-send-email-quic_c_sanm@quicinc.com> References: <1634711785-25351-1-git-send-email-quic_c_sanm@quicinc.com> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 21 Oct 2021 10:35:38 -0700 Message-ID: Subject: Re: [PATCH] phy: qcom-snps: Correct the FSEL_MASK To: Andy Gross , Bjorn Andersson , Doug Anderson , Kishon Vijay Abraham I , Matthias Kaehlcke , Sandeep Maheswaram , Vinod Koul , Wesley Cheng Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sandeep Maheswaram (2021-10-19 23:36:25) > The FSEL_MASK which selects the refclock is defined incorrectly. > It should be [4:6] not [5:7]. Due to this incorrect definition, the BIT(7) > in USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON1 is reset which keeps PHY analog > blocks ON during suspend. > Fix this issue by correctly defining the FSEL_MASK. > > Signed-off-by: Sandeep Maheswaram Any Fixes tag? > --- > drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c b/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c > index ae4bac0..28459a1 100644 > --- a/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c > +++ b/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > * Copyright (c) 2020, The Linux Foundation. All rights reserved. > + * Copyright (c) 2021, Qualcomm Innovation Center, Inc. All rights reserved. I never thought I'd see this again! :) > */ > > #include > @@ -33,7 +34,7 @@ > > #define USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0 (0x54) > #define RETENABLEN BIT(3) > -#define FSEL_MASK GENMASK(7, 5) > +#define FSEL_MASK GENMASK(6, 4) > #define FSEL_DEFAULT (0x3 << 4) > > #define USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON1 (0x58)