From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1CD7C433FE for ; Fri, 20 May 2022 00:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343932AbiETATj (ORCPT ); Thu, 19 May 2022 20:19:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235833AbiETATh (ORCPT ); Thu, 19 May 2022 20:19:37 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A94A954B0 for ; Thu, 19 May 2022 17:19:36 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id s18-20020a056830149200b006063fef3e17so4577106otq.12 for ; Thu, 19 May 2022 17:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=irN92Flw/oZRU+x5GvQi4pA44xQS8ZN3dr1edb8S6XU=; b=HGmiyVOkhBJDmzZbHsBdDQPMTdh7tlbynY1O+Qm52VOxPAropp+cPDETfpDtPt48DU RODqSYH756xQHht++4zfJUAYHURG5zrONEB57fC7jMMRVH1lzKqL+ZLe78X8Q/kitsqq 03/FqjDCO9oFUM9RdDZ5MiVcmYH08mkXqcoac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=irN92Flw/oZRU+x5GvQi4pA44xQS8ZN3dr1edb8S6XU=; b=LOSUecLJMYCeXcQlJqrdqlp5FRn2oH0sKvbko9wIA1hvNsTvbjH32B0szODlPtx/0c 4Zg4NiIhq49aWEpqZkqxPYGHsN+ofsBQfGjy7DgPEWGGZWjRkCRjyUH+2dwDuPJIu1vA MA8hPo9qo47gHISNHNS5BG+AzeWrnUncWnZPcSu8cYEYVdWJiX2e8QJL+UYhLrPmM6yk +/FptMADJTpxtR9YukMTH7T1hvqyVLJv9oKH7B6s0rforJg8mi/T+WdqWkClIM8YSMNB 2wYhSk7a6Or6xsP2/P+nEqI0LyMkS8Stp21O3sYRNANO2pq7U/R3M/VNbdId+66JbqI2 XUqQ== X-Gm-Message-State: AOAM531XtxJVomvLtauNVAfq2ZzpKaWZIoOkqKcYg9vimL9UCBrmfhtA fxYFMAo+UgqVj3+k0QZCPuW0ycKpb5bI1CqQpcUewQ== X-Google-Smtp-Source: ABdhPJym/G8+304YgHxkp02EOBkIdEUGSXWtylPSqsACNEbDFVSAvLIxO87X9cqUpNTs6/nLv8CeLcHqq7+/vchVze4= X-Received: by 2002:a9d:63cd:0:b0:606:9e7f:79f8 with SMTP id e13-20020a9d63cd000000b006069e7f79f8mr2963568otl.77.1653005975978; Thu, 19 May 2022 17:19:35 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 19 May 2022 17:19:35 -0700 MIME-Version: 1.0 In-Reply-To: <1653001902-26910-2-git-send-email-quic_khsieh@quicinc.com> References: <1653001902-26910-1-git-send-email-quic_khsieh@quicinc.com> <1653001902-26910-2-git-send-email-quic_khsieh@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Thu, 19 May 2022 17:19:35 -0700 Message-ID: Subject: Re: [PATCH v6 1/3] phy: qcom-edp: add regulator_set_load to edp phy To: Kuogee Hsieh , agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org, daniel@ffwll.ch, dianders@chromium.org, dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org Cc: quic_abhinavk@quicinc.com, quic_aravindh@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Kuogee Hsieh (2022-05-19 16:11:40) > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c > index cacd32f..78b7306 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -87,14 +87,19 @@ struct qcom_edp { > > struct clk_bulk_data clks[2]; > struct regulator_bulk_data supplies[2]; > + int enable_load[2]; > }; > > static int qcom_edp_phy_init(struct phy *phy) > { > struct qcom_edp *edp = phy_get_drvdata(phy); > int ret; > + int i; > > - ret = regulator_bulk_enable(ARRAY_SIZE(edp->supplies), edp->supplies); > + for (i = 0; i < 2; i++) Use ARRAY_SIZE(edp->supplies)? > + regulator_set_load(edp->supplies[i].consumer, edp->enable_load[i]); > + > + ret = regulator_bulk_enable(2, edp->supplies); Why is ARRAY_SIZE() usage removed? > if (ret) > return ret; >