From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C08C3A7F51 for ; Thu, 16 Jul 2026 07:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784186343; cv=none; b=nGsyrdID38gsGHk7RJhUKNZgkj1WPozXcv3hrcAcPLrJJ3Azs4gw+LfeoeiJid7xT0UUmJc65y7znAqe7HxM5LPbYRvVoJpyQ0/TgXo0wDADu+bGD2sykocNvCmiKlnzyUNMklbmpCoiR9xJyDzS1Q187BkhfdF3ZBEw3ZpkWMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784186343; c=relaxed/simple; bh=fOAMhjymr0HuW7O9quoODk2Oyap/IUy5eOd+FbzQGjU=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=jbG7Tq/qN5f033AHa+q677Rtr7cW2pq4/sygoXTb7OyczOYo5B8WMP+H+DyxKE2KKKwJu43R7ZzKpgXs5dl/4iiCHoHQJz/CUys7rjr+33AZg+4BdjJyYV193qmQjLWESMCBnv4t0SCOyIOT/pdEqysMTg5prrjDkQXuL9WqupY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=xYlWaYFV; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xYlWaYFV" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784186334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e0Cqe9wZyAorHO9Apqkn6iG4Y086abXyLT/7HbiS3Po=; b=xYlWaYFVJGa1UvPVb6IUDQsVYt3ElDdtU8J/l+MJTmd3appLU5/HzPxcmUP8XHpfMKVsYI 1r4ce/8gIdvAcn3joF7uBzqsQZMZTVyolraJ4aqjis+iuzSbMGlUhfWH598LOhKldibsjT YY5OlbIpoJ31RmnW1odhaKvhz5ImSmg= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH 10/17] mm/mm_init: factor out pfn_to_zone() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <178409212285.638342.15278486348627006171.b4-review@b4> Date: Thu, 16 Jul 2026 15:18:35 +0800 Cc: Muchun Song , Andrew Morton , Oscar Salvador , David Hildenbrand , linux-mm@kvack.org, Vlastimil Babka , Lorenzo Stoakes , Michal Hocko , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <20260702093821.2740183-1-songmuchun@bytedance.com> <20260702093821.2740183-11-songmuchun@bytedance.com> <178409212285.638342.15278486348627006171.b4-review@b4> To: Mike Rapoport X-Migadu-Flow: FLOW_OUT > On Jul 15, 2026, at 13:08, Mike Rapoport wrote: > >> pfn_to_zone() in sparse-vmemmap.c duplicates the zone lookup logic in >> __init_deferred_page(). >> >> Move it to mm_init.c, declare it in mm/internal.h, and reuse it from >> __init_deferred_page() instead of open-coding the zone walk there. > > Heh, this should be a preparatory patch instead of duplicating > pfn_to_zone in sparse-vmemmap in an earlier patch ;-) Make sense. I'll adjust the patch order to introduce pfn_to_zone() before patch 7. Muchun, Thanks. > > -- > Sincerely yours, > Mike. >