mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Renninger <trenn@suse.de>
Cc: eric.piel@tremplin-utc.net, vojcek@tlen.pl, dsdt@gaugusch.at,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, Lin Ming <ming.m.lin@intel.com>,
	lenb@kernel.org, robert.moore@intel.com, hpa@zytor.com
Subject: Re: [PATCH] ACPI: Implement overriding of arbitrary ACPI tables via initrd
Date: Fri, 23 Mar 2012 17:15:37 -0700	[thread overview]
Message-ID: <CAE9FiQW-dNhZGYdpGEwsUbSG9okPyM-JR50GaASSLvAR0nBt8A@mail.gmail.com> (raw)
In-Reply-To: <CAE9FiQVFd=Zef2bH_3MinLEV_V+cEShrmRTe7Sr8HT2R46yHHw@mail.gmail.com>

On Fri, Mar 23, 2012 at 1:54 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>> --- a/arch/x86/mm/init.c
>> +++ b/arch/x86/mm/init.c
>> @@ -391,6 +391,12 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>>         *   - relocate_initrd()
>>         * So here We can do PAGE_ALIGN() safely to get partial page to be freed
>>         */
>> +#ifdef CONFIG_ACPI_INITRD_TABLE_OVERRIDE
>> +       if (acpi_initrd_offset)
>> +               free_init_pages("initrd memory", start - acpi_initrd_offset,
>> +                               PAGE_ALIGN(end));
>> +       else
>> +#endif
>
> table already get copied to allocated ram, So you don't need to keep
> the portion in initrd range.
>
>>        free_init_pages("initrd memory", start, PAGE_ALIGN(end));
>>  }

oh, i missed it. that is offset

change following would be more clean?

 +#ifdef CONFIG_ACPI_INITRD_TABLE_OVERRIDE
 +       /* offset back to free acpi tables */
 +       if (acpi_initrd_offset)
 +               start -= acpi_initrd_offset,
 +#endif

Yinghai

  reply	other threads:[~2012-03-24  0:15 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23 14:29 Thomas Renninger
2012-03-23 15:51 ` Thomas Renninger
2012-03-23 20:05 ` H. Peter Anvin
2012-03-24  1:42   ` Thomas Renninger
2012-03-24  2:01     ` H. Peter Anvin
2012-03-24  3:02       ` Thomas Renninger
2012-03-24  4:40         ` H. Peter Anvin
2012-03-24  4:43         ` H. Peter Anvin
2012-03-24  4:50           ` Yinghai Lu
2012-03-24  4:58             ` H. Peter Anvin
2012-03-24  9:24           ` Borislav Petkov
2012-03-24 18:49             ` H. Peter Anvin
2012-03-25  8:54               ` Borislav Petkov
2012-03-26  1:36                 ` H. Peter Anvin
2012-03-26 14:21                   ` Konrad Rzeszutek Wilk
2012-03-26  0:45           ` Thomas Renninger
2012-03-26  1:25             ` H. Peter Anvin
2012-03-26 14:19               ` Thomas Renninger
2012-03-26 14:46                 ` H. Peter Anvin
2012-03-26 14:51                   ` Thomas Renninger
2012-03-27  4:15                     ` H. Peter Anvin
2012-03-27  4:46               ` Peter Stuge
2012-03-27  6:18                 ` H. Peter Anvin
2012-03-24 18:42       ` Konrad Rzeszutek Wilk
2012-03-24 19:15         ` H. Peter Anvin
2012-03-24 19:17           ` Konrad Rzeszutek Wilk
2012-03-24 19:44             ` H. Peter Anvin
2012-03-24 22:21             ` H. Peter Anvin
2012-03-24 22:44               ` H. Peter Anvin
2012-03-25  9:25                 ` Borislav Petkov
2012-03-25 23:29                   ` H. Peter Anvin
2012-03-25  4:17               ` H. Peter Anvin
2012-03-25  9:07                 ` Borislav Petkov
2012-03-23 20:54 ` Yinghai Lu
2012-03-24  0:15   ` Yinghai Lu [this message]
2012-03-24  1:05   ` Yinghai Lu
2012-03-24  1:22     ` Thomas Renninger
2012-03-24  1:26   ` Thomas Renninger
2012-03-24  4:41     ` Yinghai Lu
2012-03-26  0:45       ` Thomas Renninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE9FiQW-dNhZGYdpGEwsUbSG9okPyM-JR50GaASSLvAR0nBt8A@mail.gmail.com \
    --to=yinghai@kernel.org \
    --cc=dsdt@gaugusch.at \
    --cc=eric.piel@tremplin-utc.net \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=robert.moore@intel.com \
    --cc=trenn@suse.de \
    --cc=vojcek@tlen.pl \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®