From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA6313271FD for ; Fri, 17 Jul 2026 06:37:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.170 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784270226; cv=pass; b=j4jgCVR3CVNNY5/ospeXSZlp8ct71HoD079ZINi/j2rhXpWimyspP+pg0Opcx4SnkputozemAQMJFR9dNoFnsnndHiwbnAiy6hDFnDMd2YqgvqPGn6yvGOo/pSJeYVhZMPlteiIhuni3dhIYfArL2ZYQIBf3huH9/5Sj/Sc0w3w= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784270226; c=relaxed/simple; bh=FQcK5JUiP/gXgDsJI8Rp9EcrkBL1pDWQ/i2WTxSogpM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=lugB39+CpzgH8yly6eTYMUMcq5zJFGSviv1LUg1iWFmplK+1MhyGj7TUTjzSWDB7ZYFniN6XRUc6FC27tvWoWvTNHBoS8Sh1aO0zS4l+ydzv2rAkGgZ2CogwYrxPYRdwvqWU44Vdf6TjjI6pKqbksrnwuQyzodW0hlYmc1v2/Vk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PRBcmkdp; arc=pass smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PRBcmkdp" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-81e8c68c0cdso9815417b3.2 for ; Thu, 16 Jul 2026 23:37:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784270223; cv=none; d=google.com; s=arc-20260327; b=TNuaqYb0EKtO40qouKzHzf7/EDpouCP7XrQTHVzetjXQt1IrdLelK2oRtwUJ6jBPRc HEciWsavfpEYDZos2G0GYykifYjnsiYs5xUDcW35WhqjrN/bmKYyKg3v4AwNUB+i2ucz 4eQMfG8KDg4w8kYcTaGxPXO+OyBsdADOzq05d9t6lvEMvg/BBtJp3BaEd6vZpzIr4wS1 H/S9mrb/eALn37jVTmva0h8Ih0uG5gc7Orm6tPi53MOxCBec22jDIytTp+y8B31QzS+U TyYGfarcLbeVwh84uoi0p21XduIi6Wd2CRpTARN9SadMTEYFkY3HEQ2KidwlWe93ByQB hNhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=3lqzO3SUkfmfUH/INNl0EQx6vlwhEsJxA+B0h08XZOg=; fh=sj+35ZvNVReUvzKSxo96Xm5qkFkISVhP7nWpDdQ+zV8=; b=ga2VlElSLJlsZhyymqgYPkZKSYnzlPyHeoUGm2T5vRlyVgivWTG23NDtRzL/94h6Hz ALR7hvqllJ4FMJyd1ABXDpBborShMtHmqVS7KDjgnv56E/fXIQzB2ZH+40giw3Pn1efK t8xuICHUppnpPnj9GuE6HgXboMea8+Tn2MLfLwYHczHlu0fB7ArztlfHlY6taJjOqNFh x3jSnrrd1f+pemPVbGuojxRRF0YqXpnfo0q8QyF8YcXRiuMdhhnF4ccG6OetMHfppY1p xOweguz0xN5Df1vT3ZdrcPgqK4LNNBbv3SEGBroBcgDnUUMly2+dcMjqo2YB5Vfl4sTE u4og==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784270223; x=1784875023; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=3lqzO3SUkfmfUH/INNl0EQx6vlwhEsJxA+B0h08XZOg=; b=PRBcmkdp67sBv5/pEIvXidXyFL4xZF9kBIDVRK6tfDRx0LGOQ0W1xOH82kXbVwLuZU 7elACLDKep4S6yiOa6LpH+Vh05Yq1tIGXLPWmulKFC3CRCRGsY2EfQS+8Dc21bLBq/IT 7NLGWShl6bJTPx8rhKQjBrUnygNwogm+wzIMcRR3w19EoYxIN6OeRs91KFwpWuu0ySq3 krd3Dad1iRbEUY9hbTWNdofBUJoRnn056vNOq6tzTFSXuKm5MNdmhoqBul7uhUoqd8Wy JeIueL5w+1aGR8YmrJkPC6hAB3HhhemI+BNUsiLau5fturTngvbYg8/gYWQt50WIvf3R bmdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784270223; x=1784875023; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3lqzO3SUkfmfUH/INNl0EQx6vlwhEsJxA+B0h08XZOg=; b=kChy2Rx/reLn2z5QDp18NuOQm9GWWj+cdU+9LqRNFkrbs4JD44jlwnuwSDPO4ZieFl if0XSO3IeUrEvVXPNBpmdv0B/av6RSw7zfVto+4DX66QDYqmwm6orBAoRSbr348IJ09x Oi744klKUAdrOs/QVzq4jnIkk1G2l8W8noj5g/JpzjGqAgv6JBBtLm64chjhnJm1/goq hVYRY8hk0ewh88vyTWSZXBLQB3GIiWedZoTt9htlnZiVtS+2hjTSa0vlF8vGg5qKOehU np6O8m180grDNn7NV/QQbW0gaxH7RXl24wnjxgoJiwCaMekH+F5yYnEhjz6mcpXipOOd RREA== X-Forwarded-Encrypted: i=1; AHgh+Rr4dahdFA6thNEOunFkbZiWDB5ngN8Z3jvh1KE5TzH504nFBT65W/QvnF+T+dXix8VDW/JVJFfUy4wGAzA=@vger.kernel.org X-Gm-Message-State: AOJu0YxiT18dhOK31MdwwW3jdGSP0y+g+bM1AcJBZcllPK/QhQF6ewqb gjCTA/GPQc8pNDMETb9yovsfndOwVct++rTIfHZickGqALZ7sE0JmFzTy3fWbtJC3soj97FdmhW p1xyKKT07eDhdkau+RICEhgwybqkN1As= X-Gm-Gg: AfdE7cmbdi45cN7iDB4toDhYs7EMaJOOnRMI0B6J+KM/ASgpCAXj9SIunanwQUrbRv6 Nek2try5JtUy0mlx8wQoxazNsxWtKbhp6u2if2pR7JCDBrC2CadyWipDSlwpVy1PaasPIrTnV7m Po1xqo41esB0Qdc7J1pXgMWkE2Lw4lf/eZPbNGMb3DtCn5b+rXfvYssiSCqKHve0caOgFfWV9eB 2vvXHEiJUxucxiZI4HOveLNsxKn9a12SL4MkWdsl5AQuxRoT3Y7uUsw3DkKH3FGYxb6UNcdrwcM ms2gLDQsuB0xxorRUhhSgXobZwBNFA== X-Received: by 2002:a05:690e:448a:b0:664:bb15:ca76 with SMTP id 956f58d0204a3-6683bd56f54mr268674d50.5.1784270223565; Thu, 16 Jul 2026 23:37:03 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260715200834.8486-1-royalnet026@gmail.com> <20260715200834.8486-3-royalnet026@gmail.com> <3b5092d0-f132-4335-a3a2-b7f9de55d8e9@collabora.com> In-Reply-To: <3b5092d0-f132-4335-a3a2-b7f9de55d8e9@collabora.com> From: Igor Paunovic Date: Fri, 17 Jul 2026 08:36:51 +0200 X-Gm-Features: AUfX_mybSprLSrIZJBIZmysGtwxzPOlgLX5e-x5hgjboIL5B6eY2-4dKT3CXgYI Message-ID: Subject: Re: [PATCH v2 2/2] media: synopsys: hdmirx: add HDMI audio capture support To: Dmitry Osipenko Cc: Mauro Carvalho Chehab , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-media@vger.kernel.org, kernel@collabora.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Dmitry, > Audio capture should be stopped when the codec removed and > hdmirx_audio_shutdown() stops the audio_work. The v1 was good here, > Sashiko bot should be wrong. You're right -- the worker is only armed while a capture stream is active (from hw_params()), and hdmirx_audio_shutdown() already stops it with cancel_delayed_work_sync() when the stream closes. The extra flag clear and final cancel in remove() were redundant, so I'll restore the v1 teardown in v3. > I'd like to see rest of the patches (I2S and etc) to test this patch > before giving ack. The enablement I test with on the Orange Pi 5 Plus is small: enable i2s7_8ch (the RX-only I2S interface dedicated to HDMI RX) and add a simple-audio-card that links it to the HDMI RX codec DAI 0, with the codec as bitclock/frame master. I originally planned to send the dts part separately through the rockchip tree, but for testing it belongs with the series -- I'll include it in v3. If Rock 5B is more convenient for you to test on, the same two additions apply there; I can add that variant as well, compile-tested only since I don't have the board. v3 will then contain: the remove() revert, the ACR local renames plus a byte-packing comment and the get_dai_id stub removal (both from the bot's v2 review, already discussed in that subthread), and the dts enablement. Thanks for taking the time to test! Igor On Fri, Jul 17, 2026 at 1:08=E2=80=AFAM Dmitry Osipenko wrote: > > 15.07.2026 23:08, Igor Paunovic =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > @@ -2788,6 +3058,16 @@ static void hdmirx_remove(struct platform_device= *pdev) > > struct device *dev =3D &pdev->dev; > > struct snps_hdmirx_dev *hdmirx_dev =3D dev_get_drvdata(dev); > > > > + /* > > + * Clear the streaming flag first so a running worker cannot re-a= rm > > + * itself, then tear down the codec (which stops any active strea= m) > > + * before the final cancel. > > + */ > > + WRITE_ONCE(hdmirx_dev->audio_streaming, false); > > + if (hdmirx_dev->audio_pdev) > > + platform_device_unregister(hdmirx_dev->audio_pdev); > > + cancel_delayed_work_sync(&hdmirx_dev->audio_work); > > + > > Audio capture should be stopped when the codec removed and > hdmirx_audio_shutdown() stops the audio_work. The v1 was good here, > Sashiko bot should be wrong. > > I'd like to see rest of the patches (I2S and etc) to test this patch > before giving ack. > > -- > Best regards, > Dmitry