From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DED6C83F15 for ; Mon, 28 Aug 2023 20:48:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233536AbjH1Ura (ORCPT ); Mon, 28 Aug 2023 16:47:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232573AbjH1UrY (ORCPT ); Mon, 28 Aug 2023 16:47:24 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8870011A for ; Mon, 28 Aug 2023 13:47:21 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b9f0b7af65so54340181fa.1 for ; Mon, 28 Aug 2023 13:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1693255640; x=1693860440; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4xC6lZ6BMGGGW970pla1pAI2sfTG4MPU4nqIiCLcvow=; b=CmJOHJeAi+FAllIu7mvMkI3Iw3qdaWZLSF0qzx9zfGZYgxz9uPAbHCMJMQrPqrhFj0 KWeXH+ttc5aH7ccZ+UJaf3jHQMOWYAT5c46DexbD0zt+r1ZFFmJyh6KgkB2HVr+rI4Uy 2lWK86r/GvtQYZ7t5O9dMvjaxjhRvejyDsOrw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693255640; x=1693860440; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4xC6lZ6BMGGGW970pla1pAI2sfTG4MPU4nqIiCLcvow=; b=H8OIA8ZA4XInPzVui8xHmfO9f6B0fbiFLQlwjIDX5E9iHmL0N6tHZkwfNycKfn3mMp F7fNOYhZOJqJdegY1OA/I/ju5JmxbEU6xBxDIvJXmAt8iex/7cI6ePwbD70IGMxx0XHL WX01TwnFoCWuNq11ykXF4AUhZ8bFvgyijz8Sn7cfWDYu8UlI6nChmseSHn+ohxtxVVtY k+dQ21rFLwkN6DVdW46AAwXsa+u77L1gFuxSEBMfpoyCmEwTJ3/Xcz5NpjF4hijt9lEb LszYi0vIn4xYSNyg3EeDa0ukUzS8OtX/9EE7vHzcbdiaS8EwiaVQ8s+IO6YQPj0/U2m1 o5IQ== X-Gm-Message-State: AOJu0YyD4d9962VuY0QmRT4qOGSUmjrqZ3Kitw3BXWAQy5RIpxyyIzp8 xXEcwZJW3gt8PnUea3RoDGC/N7LqsDVdPgSBp2u8Kw== X-Google-Smtp-Source: AGHT+IGsERbihRzk13LRMf+4HVqatcZ5uGgRwfk/ClbcDnRaTlozyXs+625uI3DQf2agtAGhbV0EYasI15L27f9m5yU= X-Received: by 2002:a2e:3210:0:b0:2bc:d43c:8607 with SMTP id y16-20020a2e3210000000b002bcd43c8607mr14283630ljy.14.1693255639638; Mon, 28 Aug 2023 13:47:19 -0700 (PDT) MIME-Version: 1.0 References: <8792da20-a58e-4cc0-b3d2-231d5ade2242@paulmck-laptop> <24e34f50-32d2-4b67-8ec0-1034c984d035@paulmck-laptop> <20230825232807.GA97898@google.com> <2681134d-cc88-49a0-a1bc-4ec0816288f6@paulmck-laptop> <20230828133348.GA1553000@google.com> <142b4bff-6a2e-4ea0-928c-3cfe9befa403@paulmck-laptop> In-Reply-To: From: Joel Fernandes Date: Mon, 28 Aug 2023 16:47:07 -0400 Message-ID: Subject: Re: [PATCH V4 2/2] rcu: Update jiffies in rcu_cpu_stall_reset() To: Huacai Chen Cc: paulmck@kernel.org, Thomas Gleixner , Z qiang , Huacai Chen , Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Boqun Feng , Ingo Molnar , John Stultz , Stephen Boyd , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Sergey Senozhatsky , rcu@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Binbin Zhou Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Huacai, On Mon, Aug 28, 2023 at 11:13=E2=80=AFAM Huacai Chen wrote: > [...] > > > > > [Huacai] > > > I also think the original patch should be OK, but I have another > > > question: what will happen if the current GP ends before > > > nr_fqs_jiffies_stall reaches zero? > > > > Nothing should happen. Stall detection only happens when a GP is in > > progress. If a new GP starts, it resets nr_fqs_jiffies_stall. > > > > Or can you elaborate your concern more? > OK, I will test your patch these days. Maybe putting > nr_fqs_jiffies_stall before jiffies_force_qs is better, because I > think putting an 'int' between two 'long' is wasting space. :) That's a good point and I'll look into that. Meanwhile I pushed the patch out to my 6.4 stable tree for testing on my fl= eet. Ideally, I'd like to change the stall detection test in the rcutorture to actually fail rcutorture if stalls don't happen in time. But at least I verified this manually using rcutorture. I should also add a documentation patch for stallwarn.rst to document the understandable sensitivity of RCU stall detection to jiffies updates (or lack thereof). Or if you have time, I'd appreciate support on such a patch (not mandatory but I thought it would not hurt to ask). Looking forward to how your testing goes as well! thanks, - Joel