From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D70BC433DB for ; Fri, 5 Mar 2021 04:42:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA6906500C for ; Fri, 5 Mar 2021 04:42:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbhCEEmW (ORCPT ); Thu, 4 Mar 2021 23:42:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbhCEEmV (ORCPT ); Thu, 4 Mar 2021 23:42:21 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC6C5C061574; Thu, 4 Mar 2021 20:42:21 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id ch11so1161890pjb.4; Thu, 04 Mar 2021 20:42:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sRNaARziWpdqgv5qPE7EO6MMM4gH8cDorYzBCKaT2e0=; b=Wv1Wnxv4O5gVM94Wr8aZWa/vyesVTkFDbgyDcu5+0TzRNv8LkaEPefRejIL8FiOxzu RyFC0JV7EAherJuzU2zO+5wzckP0537s5HZqGD8LE0AHptnbXi7JSrmhOjtIyhtcO3N6 dv1GgkqlHFeqUaph8++8I23POQYMFdcT3Ld3gxt5Zoe9EMgITZZsJ7O5Rt1b7Mel1/tA OOkweQL1+BGbi0x62Q+XZ5ey4FAo0lF7LsliBsK7YDtXnxV0Lb4CkibvrSMp5tPKsX4N AzgPuIRB0XA35f1oH3WxcPG30G6jlX20ttB9b3N8h1iJ3LxMlaeY50FNJOWwQYrD3LaV 9rBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sRNaARziWpdqgv5qPE7EO6MMM4gH8cDorYzBCKaT2e0=; b=FQ3MmxnuaNMYob1sWHFKDULiolJcciSumT23oHF9JwNdX908xk+p/fjGnDVcM7D318 s5hg0m3u/Ceh1HOfgAkagGC2KL/zxx+7xkCqQzVnA5VCtC+5ATtS108J5tmuwDf3Qd5l 493lgqGAlif5cvrcx1+9YOQcmyxkd2FZdrTgZZEFvIJqX4d638uvNNSjA0sm1n2yMIfp Hz98K2U1NRZ9OPpRi4GvQqH5a6uMkNVq1CAF4DG7FJ8NtxJEHBq8gUVM/qxkkgsYTDEb bkALSctn126Db3YR9NjnG1hLz5ZK5I1x+4tB7VdUGM7fFmMXu1IooajjquLyZeMAkGmV Sa5g== X-Gm-Message-State: AOAM5324I2vfgbHj2mdt03/mlRuwpv0JRmzHg5w3kX/JnscqF6LQgcM2 vhnmVDZPUBIH+Rb+xUoIFkmwFz9YoSyzJG8vBwA= X-Google-Smtp-Source: ABdhPJxo5aAGpZWUQR1IHj+Z1tlqOXFtdvVRTXfvxVb+sBTxR+V+DKzMpV+DH/0vsMWbuc4umVhiXzpJPN5/O0u26yU= X-Received: by 2002:a17:90a:dc08:: with SMTP id i8mr7902926pjv.153.1614919341422; Thu, 04 Mar 2021 20:42:21 -0800 (PST) MIME-Version: 1.0 References: <20210225053204.697951-1-lzye@google.com> <1b315e2cd02f4017cc746909088cc8bc1a39024e.camel@hadess.net> In-Reply-To: From: Roderick Colenbrander Date: Thu, 4 Mar 2021 20:42:10 -0800 Message-ID: Subject: Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller. To: Chris Ye , Benjamin Tissoires Cc: Bastien Nocera , =?UTF-8?Q?=C5=81ukasz_Patron?= , Benjamin Valentin , Lee Jones , =?UTF-8?Q?Olivier_Cr=C3=AAte?= , Sanjay Govind , Andrzej Pietrasiewicz , linux-input , lkml , trivial@kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (resend in plain text) +benjamin in a more explicit way Hi Chris, I see the need for the Record button. I wonder what makes sense from the Linux kernel perspective. For DualShock 4 and DualSense there is a Share button too (it introduced it). For DualShock 4 that was mapped to 'Select' I think per Linux gamepad spec. For DualSense in 5.12 we did the same... Though if there is a true 'Record' button we want to use moving forward. Maybe we still want to change the button definition for DualSensein 5.12 while we can... It would be good to get some consensus on these buttons. Thanks, Roderick On Thu, Mar 4, 2021 at 6:25 PM Chris Ye wrote: > > Hi Bastien, just want to follow up again on this. I've checked again > with the Xbox team that the "Share button" is given for the product, > the HID usage profile and mapping to RECORD is what Xbox team expects > and they want the same mapping for USB. > > Thanks! > Chris > > > On Tue, Mar 2, 2021 at 3:57 PM Chris Ye wrote: > > > > Hi Bastien, > > The "Share button" is a name Microsoft calls it, it actually has > > HID descriptor defined in the bluetooth interface, which the HID usage > > is: > > consumer 0xB2: > > 0x05, 0x0C, // Usage Page (Consumer) > > 0x0A, 0xB2, 0x00, // Usage (Record) > > Microsoft wants the same key code to be generated consistently for USB > > and bluetooth. > > Thanks! > > Chris > > > > > > On Tue, Mar 2, 2021 at 1:50 AM Bastien Nocera wrote: > > > > > > On Thu, 2021-02-25 at 05:32 +0000, Chris Ye wrote: > > > > Add "Share" button input capability and input event mapping for > > > > Microsoft Xbox One controller. > > > > Fixed Microsoft Xbox One controller share button not working under USB > > > > connection. > > > > > > > > Signed-off-by: Chris Ye > > > > --- > > > > drivers/input/joystick/xpad.c | 9 ++++++++- > > > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/input/joystick/xpad.c > > > > b/drivers/input/joystick/xpad.c > > > > index 9f0d07dcbf06..0c3374091aff 100644 > > > > --- a/drivers/input/joystick/xpad.c > > > > +++ b/drivers/input/joystick/xpad.c > > > > @@ -79,6 +79,7 @@ > > > > #define MAP_DPAD_TO_BUTTONS (1 << 0) > > > > #define MAP_TRIGGERS_TO_BUTTONS (1 << 1) > > > > #define MAP_STICKS_TO_NULL (1 << 2) > > > > +#define MAP_SHARE_BUTTON (1 << 3) > > > > #define DANCEPAD_MAP_CONFIG (MAP_DPAD_TO_BUTTONS > > > > | \ > > > > MAP_TRIGGERS_TO_BUTTONS | > > > > MAP_STICKS_TO_NULL) > > > > > > > > @@ -130,6 +131,7 @@ static const struct xpad_device { > > > > { 0x045e, 0x02e3, "Microsoft X-Box One Elite pad", 0, > > > > XTYPE_XBOXONE }, > > > > { 0x045e, 0x02ea, "Microsoft X-Box One S pad", 0, XTYPE_XBOXONE > > > > }, > > > > { 0x045e, 0x0719, "Xbox 360 Wireless Receiver", > > > > MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360W }, > > > > + { 0x045e, 0x0b12, "Microsoft X-Box One X pad", > > > > MAP_SHARE_BUTTON, XTYPE_XBOXONE }, > > > > { 0x046d, 0xc21d, "Logitech Gamepad F310", 0, XTYPE_XBOX360 }, > > > > { 0x046d, 0xc21e, "Logitech Gamepad F510", 0, XTYPE_XBOX360 }, > > > > { 0x046d, 0xc21f, "Logitech Gamepad F710", 0, XTYPE_XBOX360 }, > > > > @@ -862,6 +864,8 @@ static void xpadone_process_packet(struct usb_xpad > > > > *xpad, u16 cmd, unsigned char > > > > /* menu/view buttons */ > > > > input_report_key(dev, BTN_START, data[4] & 0x04); > > > > input_report_key(dev, BTN_SELECT, data[4] & 0x08); > > > > + if (xpad->mapping & MAP_SHARE_BUTTON) > > > > + input_report_key(dev, KEY_RECORD, data[22] & 0x01); > > > > > > > > /* buttons A,B,X,Y */ > > > > input_report_key(dev, BTN_A, data[4] & 0x10); > > > > @@ -1669,9 +1673,12 @@ static int xpad_init_input(struct usb_xpad > > > > *xpad) > > > > > > > > /* set up model-specific ones */ > > > > if (xpad->xtype == XTYPE_XBOX360 || xpad->xtype == > > > > XTYPE_XBOX360W || > > > > - xpad->xtype == XTYPE_XBOXONE) { > > > > + xpad->xtype == XTYPE_XBOXONE) { > > > > for (i = 0; xpad360_btn[i] >= 0; i++) > > > > input_set_capability(input_dev, EV_KEY, > > > > xpad360_btn[i]); > > > > + if (xpad->mapping & MAP_SHARE_BUTTON) { > > > > + input_set_capability(input_dev, EV_KEY, > > > > KEY_RECORD); > > > > > > Is there not a better keycode to use than "Record"? Should a "share" > > > keycode be added? > > > > > > I couldn't find a share button in the most recent USB HID Usage Tables: > > > https://www.usb.org/document-library/hid-usage-tables-121 > > > > > > > + } > > > > } else { > > > > for (i = 0; xpad_btn[i] >= 0; i++) > > > > input_set_capability(input_dev, EV_KEY, > > > > xpad_btn[i]); > > > > > >