From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941177AbcIHWPS (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Sep 2016 18:15:18 -0400
Received: from mail-lf0-f68.google.com ([209.85.215.68]:33823 "EHLO
        mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932233AbcIHWPQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2016 18:15:16 -0400
MIME-Version: 1.0
In-Reply-To: <bac9d45e-8978-be16-b9a6-ba6cb5a6b6f0@infradead.org>
References: <1473356083-14601-1-git-send-email-kraigatgoog@gmail.com>
 <1473366347-142493-1-git-send-email-kraigatgoog@gmail.com> <bac9d45e-8978-be16-b9a6-ba6cb5a6b6f0@infradead.org>
From: Craig Gallek <kraigatgoog@gmail.com>
Date: Thu, 8 Sep 2016 18:15:11 -0400
X-Gmail-Original-Message-ID: <CAEfhGixi3BY5btXkowdNkCruxhiXSDGWOaFcdLV033_cmO2Kxg@mail.gmail.com>
Message-ID: <CAEfhGixi3BY5btXkowdNkCruxhiXSDGWOaFcdLV033_cmO2Kxg@mail.gmail.com>
Subject: Re: [PATCH v3] genirq: Machine-parsable version of /proc/interrupts
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        David Decotigny <decot@google.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 8, 2016 at 6:00 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 09/08/16 13:25, Craig Gallek wrote:
>> From: Craig Gallek <kraig@google.com>
>>
>> Add struct kobject to struct irq_desc to allow for easy export
>> to sysfs.  This allows for much simpler userspace-parsing of
>> the information contained in struct irq_desc.
>>
>> Note that sysfs is not available at the time of early irq initialization.
>> These interrupts are accounted for using a postcore_initcall callback.
>>
>> Examples:
>>   /sys/kernel/irq/18/actions: i801_smbus,ehci_hcd:usb1,uhci_hcd:usb7
>>   /sys/kernel/irq/18/chip_name:       IR-IO-APIC
>>   /sys/kernel/irq/18/hwirq:           18
>>   /sys/kernel/irq/18/name:            fasteoi
>>   /sys/kernel/irq/18/per_cpu_count:   0,0
>>   /sys/kernel/irq/18/type:            level
>>
>>   /sys/kernel/irq/25/actions: ahci0
>>   /sys/kernel/irq/25/chip_name:       IR-PCI-MSI
>>   /sys/kernel/irq/25/hwirq:           512000
>>   /sys/kernel/irq/25/name:            edge
>>   /sys/kernel/irq/25/per_cpu_count:   29036,0
>>   /sys/kernel/irq/25/type:            edge
>
> Thanks for the update.
>
> One concern:
>
> This per_cpu_count is for online CPUs only.
> How does this help when the online CPUs change?
>
> E.g., above could be for CPUs 1 and 5.
> The next time that it is read it could be for CPUs 0 and 3.
> Seems that it could be confusing even for software reading it.

Thanks for the feedback. I imagine most use cases for this will simply
add up all the values to obtain a total.  There's not a lot of use for
the individual elements unless you additionally know something about
the CPU id layout, interrupt pinning, and/or CPU online state.  The
/proc/interrupts interface has this same issue, but additionally uses
column headers.  There's really know way to give a similar consistent
view of all of this data using multiple sysfs files.  Given this lack
of atomicity, across files, I don't think it's unreasonable for the
counter order to change when the system's online CPUs change.

The only alternative I could imagine would be to include a header row
in this file listing the CPU ids as a parallel list.  I think this
goes against the standard sysfs file format, though...