From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f50.google.com (mail-dl1-f50.google.com [74.125.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC322347BA8 for ; Tue, 20 Jan 2026 13:43:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.82.50 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768916592; cv=pass; b=kxKYNXdGsRsWnldRLEkta0jZ/JM4w5msw6U3mFDaGoov7g+m22odDhnqT/mjujLC0zVUcIRXYHU+Xr8y+BSi6NXRD7bnV4hwhH5hJJ149e/2an/10LzK+JA5dTkIq37nzQ1xWhQmDowNJsAV88liXk7cKapIix3Qu3rE2OAqmkM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768916592; c=relaxed/simple; bh=x9mgi3TL0eDGl2pTGxPI5X6I1yeHKcio4o8DKGeuzng=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=rqgXGnZ7DYo1i2a2MB4dnKmTS9nDl1hqM7mSHCvtsQWkwNzkDbcxEEZnlIPesZ2lnxmf0DQiBXBkWhdSko4VR2WAvszBo1qTZdPdxyQhYvVKhThTUIrJ9KqZycUTOYeXEFVbUWsTt7T2yy70l83et58R9t2ULlwn0lee0lUbrRE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ngKGSC5x; arc=pass smtp.client-ip=74.125.82.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ngKGSC5x" Received: by mail-dl1-f50.google.com with SMTP id a92af1059eb24-121a0bcd364so6728985c88.0 for ; Tue, 20 Jan 2026 05:43:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1768916588; cv=none; d=google.com; s=arc-20240605; b=lDZEJ5wIHdk84I9VHT3gmaZ3ur7DIieNNoTwL0Nm1xW4uypCQXWZUzXFkT/JK5ziRp aihDnbfSjn9ww/fN9dYLbSrVCv8MFJhFLHSafR+K60SPFNyC+7pEr3qdj9W6pTVRT1Di 2Yk3ae43L7iVaQlzExBU4SVWZ9uacHe4F9obRM2WhbXoVjtogeEuX838A9/0X8u1EvRU i6+MM4X/Id1ph4Lesey4oU72CJV0LRc6NlwhkkVe0K3I9Xqqz9ma831rQaNpARqrA+Rf 1+U8qwKbSI0RaL2YR7CQ3c79x3PXLDU/QjoBmrv88DbldEhfNvGwI/oDEkI5iS11XheH egFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=x9mgi3TL0eDGl2pTGxPI5X6I1yeHKcio4o8DKGeuzng=; fh=4+oWrt5SZ1MK+xcysr4t9BJpuxKj2YogaJonmzycLRs=; b=dQQ4f09Z+TnNsNJ7K2N4CMMR8zPS8TMfKj29l2hxE4WNnKSmi2qaXWnTF7oD80PqKJ 9AR9XLk8nE1REC1U/aq3Rq0xLbSNup99p3X/x6t5qtlystQnxpYe3h6sl8tzfqUF8ZnU nHwYSGrRdmjmS2LGMf9CCiT+uiTAvo/OTyRG+5w2XB3xk05QbGeQ2ApMcejaOi0CIqXg t1NwI/XnjVfCeXsOUlpfft4DGcaj0H6Ymur8bvD0XLaf41akoQ2cRISxr9YSw6UShTV5 GWLHYLBRj2Il1cuplCR3kXnz8SBl7Aixbkv7rJVOKrp69L8FRBs5ZqtypnL00XWmqG6j Zn3Q==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768916588; x=1769521388; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x9mgi3TL0eDGl2pTGxPI5X6I1yeHKcio4o8DKGeuzng=; b=ngKGSC5xMF8tRwT2TwE0rPr9Lgn0cmAkq0DyDfJEAlObFu3edAjs+bcOn7C6C2f4NN DgfVfn7aeLCsSWjEIm5Dlg6XPhzVgs+qcsW5SjO78SfsdsBVondNdOaM44EYmQ28v9Z3 bw4XULFKtdi81TxrMX0s4+W5i6oisJkNQHnHgZS2Bbg03fg7iXTaXO3dKp+V8gA9nr2h yiiwXKNgDLkEpJdMGrzWIR6b2y3+8X6ZjBbvDNwWrSYFZ0FK3TtSuvxXzsen6JHu7KGc aDJzE5v4JHmXAsjl536ADCT0oHQ65D0hf0gCgeiwM3YrFE2HMaOWFRtM3/QtSsKE9Auu N/zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768916588; x=1769521388; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=x9mgi3TL0eDGl2pTGxPI5X6I1yeHKcio4o8DKGeuzng=; b=SnULQX6aTNCfcg10o/lcj0UwugnKaUqNjH7c1Y3m9HZ8kaGP2IhuhZfkHiOAei8Myt BPoxjcWeI7lUo5AlhIEjOrvQ7hG2P3uj/Dk972ge0Z9olCSjMg4Me+ycJ5iiIkIxsYwY w+omc7+uQI+4dVHYLKwRx5ZaYlWsrAXOCrFBkcP2pc0c2O8opjxBYLTwFD8KncuBHqTP HzvA2TSac9hmhYCSRO1ibKvTclmCuitWO881CRRPUEsRGfyf/Erm8IE/G9ak6A8iJvAA Nr2QNic6kbshhQcZuaYdeX/JfTSKblIwbNCEsDaRurW8sgTrlZEPHAalNxKxwupOiNc0 0x4Q== X-Forwarded-Encrypted: i=1; AJvYcCXyA8vVDTdNkQt/Le/OnxE35mmlszkea9Yv2kUuSImsg2X0BIVnxAZjU/3Q5cyaMUQcs/+DWnsR17kN+wk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyya87YfU4hHBfzwcOCaExFNT8Gg4Tp0AjB/MytlsD+Shayw/Mr edjcDsj9AP+ynUEgBbKjwbFjOvJh3uYWZxy87OsJ5AEQHyDXpNBbAsIZ07+MqXTO9oJNUR9O1D2 VJecqfnbRLuxQkPEE/f+3Qjoh9nYImeg= X-Gm-Gg: AY/fxX7V/tKJlN25hCrsNVCC0tAnJC7rOgKkmXlWdU4gg6cNbqZjdH0Yquop4ymHG3Y virFc/o8J583mMut0OH3+hOP9zkbOrxstYPGoZ6vGETxUUlakg+kfZ0Bm9+/Avdvz/jG4mJP8c9 WBppi1rFCn/i1c7Nb6jLmd/bif0cYok58jgTLSs9I3y1l4jZ1O/El7bWvXbgrgNIAVNP5A8GkFe vKMqYLNRTcqL6K1WPKYm+AstVssylXXgd4nGNtcdf5h03YCofTb54NKAAYp08+d5bxgf1AtjZAk jYHGfMETekJlo9GHw7ffjas4CQShzsyJvsDiBke+N3Qi787W2WQNqiBk3w/XenEERTYDFpiLHJh Q7mD2gVWjgQ== X-Received: by 2002:a05:7022:6b8c:b0:119:e56c:18a6 with SMTP id a92af1059eb24-1244a7257a4mr10880097c88.14.1768916586232; Tue, 20 Jan 2026 05:43:06 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260120115923.3463866-1-khristineandreea.barbulescu@oss.nxp.com> <20260120115923.3463866-11-khristineandreea.barbulescu@oss.nxp.com> In-Reply-To: From: Daniel Baluta Date: Tue, 20 Jan 2026 15:45:46 +0200 X-Gm-Features: AZwV_QiPrjYIgkrWuZvZ77hO6EmYEBB8e53YvqXAvD3NoIb32l_6NmOignEguN0 Message-ID: Subject: Re: [PATCH v8 10/10] pinctrl: s32cc: set num_custom_params to 0 To: Bartosz Golaszewski Cc: Khristine Andreea Barbulescu , Alberto Ruiz , Christophe Lizzi , devicetree@vger.kernel.org, Enric Balletbo , Eric Chanudet , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, NXP S32 Linux Team , Pengutronix Kernel Team , "Vincent Guittot devicetree @ vger . kernel . org" , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Larisa Grigore , Lee Jones , Shawn Guo , Sascha Hauer , Fabio Estevam , Dong Aisheng , Jacky Bai , Greg Kroah-Hartman , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 20, 2026 at 2:26=E2=80=AFPM Bartosz Golaszewski wrote: > > On Tue, 20 Jan 2026 12:59:22 +0100, Khristine Andreea Barbulescu > said: > > From: Andrei Stefanescu > > > > The `num_custom_params` was not set to 0 and the pinctrl_desc structure > > was not initialized with 0. This would result in errors when parsing > > pinconf properties from the device tree. > > > > Shoudn't this come as first in the series and with a Fixes tag? Hi Khristine, The entire series could use a better patch reordering to arrange the code as follows: * Bug fixes * Code refactorization or API changes * Device tree bindings * Driver implementation * DTS changes