From: Bjorn Helgaas <bhelgaas@google.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] PCI: add generic device into pci_host_bridge struct
Date: Mon, 27 Feb 2012 16:00:15 -0700 [thread overview]
Message-ID: <CAErSpo7MFajXaQe52gXdVjaMLRU2Cpcu88QjM+Mw_22bArwF7w@mail.gmail.com> (raw)
In-Reply-To: <CAE9FiQWgjSSXQgi=xsK8em4pWtXy5vUq2vtNazX3Hurq2CUmBQ@mail.gmail.com>
On Mon, Feb 27, 2012 at 3:55 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Mon, Feb 27, 2012 at 2:24 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>>>
>>> for every bus will have ->bridge, and that is device pointer. to pci
>>> bridge dev.
>>>
>>> for root bus, there is not pci bridge for that. So create_root_bus
>>> allocate local dummy one.
>>>
>>> that dummy device will be bus->dev's parent.
>>>
>>> Now pci_host_bridge is added, and it is allocated, so just put the
>>> struct device into that pci_host_bridge.
>>>
>>> and use pci_host_bridge->dev as parent of root bus->dev's parent.
>>
>> What's the device passed in to pci_create_root_bus()? Why is that
>> different than the root bus dev's parent?
>
> ia64 and x86 doesn't pass that.
>
> arch/ia64/pci/pci.c: pbus = pci_create_root_bus(NULL, bus,
> &pci_root_ops, controller,
> arch/powerpc/kernel/pci-common.c: bus =
> pci_create_root_bus(hose->parent, hose->first_busno,
> arch/sparc/kernel/pci.c: bus = pci_create_root_bus(parent,
> pbm->pci_first_busno, pbm->pci_ops,
> arch/x86/pci/acpi.c: bus = pci_create_root_bus(NULL,
> busnum, &pci_root_ops, sd,
> drivers/parisc/dino.c: dino_dev->hba.hba_bus = bus =
> pci_create_root_bus(&dev->dev,
> drivers/parisc/lba_pci.c: pci_create_root_bus(&dev->dev,
> lba_dev->hba.bus_num.start,
>
> sparc, powerpc, parisc have their local ...
>
> so local hose etc's dev ---> allocated dev ---> root bus's dev
>
> this patch change to
>
> local hose etc's dev ---> allocated host bridge's dev ---> root bus's dev
Why do we have a separate dev for the hose and the root bus's dev?
The hose *is* a PCI host bridge.
next prev parent reply other threads:[~2012-02-27 23:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 23:33 [PATCH 0/8] PCI: pci_host_bridge related cleanup Yinghai Lu
2012-02-26 23:33 ` [PATCH 1/8] PCI: Separate host_bridge code out from probe.c Yinghai Lu
2012-02-26 23:33 ` [PATCH 2/8] x86, PCI: have own version for pcibios_bus_to_resource Yinghai Lu
2012-02-27 17:34 ` Bjorn Helgaas
2012-02-26 23:33 ` [PATCH 3/8] x86, PCI: Fix memleak with get_current_resources Yinghai Lu
2012-02-26 23:33 ` [PATCH 4/8] PCI: make pci_host_bridge more robust Yinghai Lu
2012-02-27 17:44 ` Bjorn Helgaas
2012-02-26 23:33 ` [PATCH 5/8] PCI: add generic device into pci_host_bridge struct Yinghai Lu
2012-02-27 17:57 ` Bjorn Helgaas
2012-02-27 19:08 ` Yinghai Lu
2012-02-27 19:17 ` Bjorn Helgaas
2012-02-27 20:49 ` Yinghai Lu
2012-02-27 22:24 ` Bjorn Helgaas
2012-02-27 22:55 ` Yinghai Lu
2012-02-27 23:00 ` Bjorn Helgaas [this message]
2012-02-26 23:33 ` [PATCH 6/8] PCI: add host bridge release support Yinghai Lu
2012-02-26 23:33 ` [PATCH 7/8] x86, PCI: break down get_current_resource() Yinghai Lu
2012-02-26 23:33 ` [PATCH 8/8] x86, PCI: add host bridge resource release for using _CRS Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErSpo7MFajXaQe52gXdVjaMLRU2Cpcu88QjM+Mw_22bArwF7w@mail.gmail.com \
--to=bhelgaas@google.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®