From: Bjorn Helgaas <bhelgaas@google.com>
To: David Miller <davem@davemloft.net>
Cc: jesse.brandeburg@gmail.com,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
netdev <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
bjorn.helgaas@hp.com
Subject: Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines
Date: Fri, 3 Jan 2014 17:00:42 -0700 [thread overview]
Message-ID: <CAErSpo7TJXTCxpFKWXLTaHmqXXnYQdnpNeWt+cehSaES2Jh30w@mail.gmail.com> (raw)
In-Reply-To: <20140103.185607.1380379872647540168.davem@davemloft.net>
On Fri, Jan 3, 2014 at 4:56 PM, David Miller <davem@davemloft.net> wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> Date: Fri, 3 Jan 2014 15:15:57 -0700
>
>> However, I do raise my eyebrows a bit at drivers that poke around in
>> the PCIe capability. I would prefer to have PCI core interfaces that
>> handle that instead. But I haven't seen Jeff's changes yet.
>
> The changes just read the link status to interpret the speed at which
> the PCI-E link is running at.
Several drivers want to do that. It'd be nice if somebody abstracted
that out somehow. Jacob added pcie_get_minimum_link() which is
similar. But maybe Jeff needs something more in this case.
In any case, it's not a blocker for this patch.
Bjorn
next prev parent reply other threads:[~2014-01-04 0:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 12:36 Jeff Kirsher
2014-01-03 0:21 ` David Miller
2014-01-03 21:53 ` Jesse Brandeburg
2014-01-03 22:15 ` Bjorn Helgaas
2014-01-03 23:56 ` David Miller
2014-01-04 0:00 ` Bjorn Helgaas [this message]
2014-01-04 0:30 ` David Miller
2014-01-04 1:27 ` Jeff Kirsher
2014-01-04 1:48 ` David Miller
2014-01-04 1:51 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErSpo7TJXTCxpFKWXLTaHmqXXnYQdnpNeWt+cehSaES2Jh30w@mail.gmail.com \
--to=bhelgaas@google.com \
--cc=bjorn.helgaas@hp.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®