From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752677Ab2IRRNq (ORCPT ); Tue, 18 Sep 2012 13:13:46 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:52379 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113Ab2IRRNp (ORCPT ); Tue, 18 Sep 2012 13:13:45 -0400 MIME-Version: 1.0 In-Reply-To: <1347657078-32230-2-git-send-email-thierry.reding@avionic-design.de> References: <1347657078-32230-1-git-send-email-thierry.reding@avionic-design.de> <1347657078-32230-2-git-send-email-thierry.reding@avionic-design.de> From: Bjorn Helgaas Date: Tue, 18 Sep 2012 11:13:23 -0600 Message-ID: Subject: Re: [PATCH 1/2] ARM: pci: Keep pci_common_init() around after init To: Thierry Reding Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 14, 2012 at 3:11 PM, Thierry Reding wrote: > When using deferred driver probing, PCI host controller drivers may > actually require this function after the init stage. > > Signed-off-by: Thierry Reding > --- > arch/arm/kernel/bios32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c > index 2b2f25e..7288093 100644 > --- a/arch/arm/kernel/bios32.c > +++ b/arch/arm/kernel/bios32.c > @@ -423,7 +423,7 @@ static int pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin) > return irq; > } > > -static void __init pcibios_init_hw(struct hw_pci *hw, struct list_head *head) > +static void __devinit pcibios_init_hw(struct hw_pci *hw, struct list_head *head) Shouldn't we just remove __init completely, since Greg KH is in the process of removing __devinit? > { > struct pci_sys_data *sys = NULL; > int ret; > @@ -472,7 +472,7 @@ static void __init pcibios_init_hw(struct hw_pci *hw, struct list_head *head) > } > } > > -void __init pci_common_init(struct hw_pci *hw) > +void __devinit pci_common_init(struct hw_pci *hw) > { > struct pci_sys_data *sys; > LIST_HEAD(head); > -- > 1.7.12 >