From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758659Ab3ICSJx (ORCPT ); Tue, 3 Sep 2013 14:09:53 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:35345 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754471Ab3ICSJv (ORCPT ); Tue, 3 Sep 2013 14:09:51 -0400 MIME-Version: 1.0 In-Reply-To: <20130903003958.GA6855@localhost> References: <20130902195056.GB32628@leaf> <9976.1378132260@warthog.procyon.org.uk> <1378138205.1953.66.camel@joe-AO722> <20130902181510.GA29787@leaf> <20130902181856.GB29787@leaf> <20130902153945.6d7e510c@samsung.com> <1378148367.1953.98.camel@joe-AO722> <13834.1378155023@warthog.procyon.org.uk> <1378156296.1953.117.camel@joe-AO722> <20130903003958.GA6855@localhost> From: Bjorn Helgaas Date: Tue, 3 Sep 2013 12:09:31 -0600 Message-ID: Subject: Re: [Ksummit-2013-discuss] [PATCH] checkpatch: Add comment about updating Documentation/CodingStyle To: Fengguang Wu Cc: Joe Perches , "ksummit-2013-discuss@lists.linuxfoundation.org" , Wang Shilong , "linux-kernel@vger.kernel.org" , Andy Whitcroft , Linus Torvalds , Mauro Carvalho Chehab Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 2, 2013 at 6:39 PM, Fengguang Wu wrote: > Thanks! Yes I'm now running checkpatch these days because some people > suggested to me that some of the checkpatch warnings do help catch > real bugs. > > However I do try to avoid upsetting people with maybe-subjective > warnings. A checkpatch report will only be sent when a small fraction > of error types are detected. Comments are very welcome on how to > improve this list: How hard would it be to make this configurable per-git tree? I think the robot is quite useful and I don't push branches very often, so I'd probably be OK with just getting all the checkpatch warnings along with the build warnings and filtering the noise myself. But I know other people have different styles and opinions. > MEMSET > IN_ATOMIC > UAPI_INCLUDE > MALFORMED_INCLUDE > SIZEOF_ADDRESS > KREALLOC_ARG_REUSE > EXECUTE_PERMISSIONS > ERROR:BAD_SIGN_OFF > LO_MACRO > HI_MACRO > CSYNC > SSYNC > HOTPLUG_SECTION > INDENTED_LABEL > INLINE_LOCATION > STORAGE_CLASS > USLEEP_RANGE > UNNECESSARY_CASTS > ALLOC_SIZEOF_STRUCT > KREALLOC_ARG_REUSE > USE_FUNC > LOCKDEP > EXPORTED_WORLD_WRITABLE > WHITESPACE_AFTER_LINE_CONTINUATION > MISSING_VMLINUX_SYMBOL > NEEDLESS_IF > PRINTF_L > > Once the decision is made to send a checkpatch error/warning, the > report email will use the triggering error (the one that matters) as > the email subject, with the complete output of checkpatch.pl included > in email body. > > Thanks, > Fengguang > _______________________________________________ > Ksummit-2013-discuss mailing list > Ksummit-2013-discuss@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-2013-discuss