From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B122285C4A for ; Tue, 28 Oct 2025 02:19:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761617944; cv=none; b=d6rPJiw/n22/moqwlV1Tl6NrWBmINmOXwRjs0zBUhk9GLMusArdV4k/ph9houK7RvFULTu7W7NzS6JUlG7HRRJZdwVU50MmOvd/gMKkSGQQUjzNdonyOfvxYZqlgn0VVpsch8LFh6GhkVe/bXBpoqWRb1OtaAqXFcbo2FshysFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761617944; c=relaxed/simple; bh=wUrzYZVlpyiPMeDu/2DVjoebFrvXatkNqm72yhlCLN0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=grdiprl0GfMP6a9QBApK9KLXtz9CaYLrF5NJiu2X+St81Ow54jJOEGXl4qpVGq7DdRH5825BKaYcSbhXtMXuGJSN/hi+fjWw3O31KVlPoC3x7TpO4noJr/dMGEA0LHxQLOs3hHNqEqWNlH5Hq/ojtQ2jYT6f4emRh7EkXpIiXZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UD5tX09z; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UD5tX09z" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-63c2d72582cso8737903a12.1 for ; Mon, 27 Oct 2025 19:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761617941; x=1762222741; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AN510ZMpd18wGhePif0lPafM6Nb9iWSBr18OTXAbR0A=; b=UD5tX09zJILmIhXmscaJo5ceODhWhEzxTlH7+x8WFVMnF+hrwS+B54xQ6Oe9LDMJ0N R+3+dCWkP/Wb7NiUVCgSVrcwCyn0G98gojXmmTR/3hwru3L2WPXBsCSm/kbfP4zDIUAD t2eap7aF2SlQKRkpzA8ndMiAvsg3EYb9URzbmhhIbgf1eve9XRoj32z0oa5no0MvctXL Euus6v5rNCCc8P6hy2betWW4JlJVjWTiiPLHIlNmFSqrFyuhqLDPJCNumw5qeDeb5m4W +zZlXtl6tsz0uW5FKWh0S+bv1E0i2zQFxtODZ7eMhjm0t0qEuo3DFIPQI4LdRtfv0WMR Ifdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761617941; x=1762222741; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AN510ZMpd18wGhePif0lPafM6Nb9iWSBr18OTXAbR0A=; b=R6srV8V1zRAXDfV4pDG64Yku3KXwZHCO/D7YR6Xv8rLyn35NdCAdCZUFSzL17rsK+K 0rBUYDb5J9qj1xOa5EBAQ9jZ16DpLtIEio+A3lnR93smSlDg/+3vazc8LB+tsmhOLoOT JdhzL4MjtT1sIdBIzeAanizItlnQJvekPlKdSuEDSVVD6P3dETmtMMts3Yz37Ub2aB9b rAVCZGI6e7fSEAnFmXGZnC4BAodWUtqkLwJvK0cAdD3WWwwhcY7LIf1XWdy+AsyfOFOT lje8nIFXAET9Xit9aVhmL/J05qEoE2jyIbo1VbVMMPkKOz8lc9XRkirg+UNbwJVwI6cb /XMQ== X-Forwarded-Encrypted: i=1; AJvYcCWXkgEKx3uYTqXCuKL6oaMblbZDYsdY9XDggaX1XAN0gbg51JzF61co+H+yYhB2ktVrHgEMR3iET17pBAc=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ7ksFYmCju/58N/LB6KRZI8GmOLqBjM1DiQtUSBagAk9wnrbY 9HGdXPs3e3H2Ppjbxp1VtU5ESLNXu/+uaZFwfWYy5KXcd2LYp2dFudo1xCMPFXoQO5xqcoglpsG iXx6/0xTTzmYc5XN2m9SpS8oUiZcTNlY= X-Gm-Gg: ASbGncsvlnT5goXlFn68qfKcgqXLkocuR+9WwtffRGwWWFBTrudVby1A84wjQR5/5DJ w3Ox2W07vwi3cCCGSdL3e6aJBcoT+INKQWMqX9s8wdggt2IqcCTNESEH1h641OMhae50QCtjZxq YNqD9rAO7VnMSdI2HxY1vyXrA/9GIkc7l28PHH09yDh+oPLK7oiQCAud2RNNMZGUup7p5MCmX5J PXONvCunJ87az953xursQOtPb1zqmYaCn045ncoAmswZXHQVcq5vs2s+q55wPqTxJUYIGEB X-Google-Smtp-Source: AGHT+IFaeiMil37TfUWLDdiI45hMGvdiKJDEANP666ZOSHDxzSK6WS0C1Hplz9vcdJS1CTShLHgekTPjcP6/7Z0vX1Y= X-Received: by 2002:a05:6402:5113:b0:634:7224:c6b5 with SMTP id 4fb4d7f45d1cf-63ed8266d91mr1744511a12.28.1761617940813; Mon, 27 Oct 2025 19:19:00 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251027135423.3098490-1-dolinux.peng@gmail.com> <20251027135423.3098490-2-dolinux.peng@gmail.com> <6e7ef94cb4e2d7fbc82676b2af1a165cac620aae.camel@gmail.com> In-Reply-To: <6e7ef94cb4e2d7fbc82676b2af1a165cac620aae.camel@gmail.com> From: Donglin Peng Date: Tue, 28 Oct 2025 10:18:48 +0800 X-Gm-Features: AWmQ_bkDfsyvvmcYCiAEQKQCeupP_Qvm5g2X7LvMYt4ywV38fGg4BM6et1J8JJ0 Message-ID: Subject: Re: [RFC PATCH v3 1/3] btf: implement BTF type sorting for accelerated lookups To: Eduard Zingerman Cc: ast@kernel.org, Andrii Nakryiko , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Alan Maguire , Song Liu , pengdonglin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 28, 2025 at 3:06=E2=80=AFAM Eduard Zingerman wrote: > > On Mon, 2025-10-27 at 21:54 +0800, Donglin Peng wrote: > > [...] > > Question to Andrii, I think. > It looks a bit asymmetrical, that there is btf_check_sorted() in > libbpf, but library does not provide comparison or sorting function. > Wdyt? > > > +static void btf_check_sorted(struct btf *btf, int start_id) > > +{ > > + const struct btf_type *t; > > + int i, n, nr_sorted_types; > > + > > + n =3D btf__type_cnt(btf); > > + if (btf->nr_types < BTF_CHECK_SORT_THRESHOLD) > > + return; > > + > > + n--; > > + nr_sorted_types =3D 0; > > + for (i =3D start_id; i < n; i++) { > > + int k =3D i + 1; > > + > > + if (btf_compare_type_kinds_names(&i, &k, btf) > 0) > > + return; > > + > > + t =3D btf_type_by_id(btf, k); > > + if (!str_is_empty(btf__str_by_offset(btf, t->name_off))) > > + nr_sorted_types++; > > + } > > + > > + t =3D btf_type_by_id(btf, start_id); > > + if (!str_is_empty(btf__str_by_offset(btf, t->name_off))) > > + nr_sorted_types++; > > + > > + if (nr_sorted_types < BTF_CHECK_SORT_THRESHOLD) > > + return; > > Nit: Still think that this is not needed. It trades a couple of CPU > cycles for this check and a big comment on the top, about why > it's needed. Thanks, I will remove it in the next version. > > > + > > + btf->nr_sorted_types =3D nr_sorted_types; > > +} > > [...]