From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21252385D8B for ; Wed, 8 Jul 2026 22:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.214.179 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783551215; cv=pass; b=tZEDC79NExEb10yUGjqGztX7OH4W1C5gOAkBAiXHnPDQZEO5WZmD6HDG5d8mAan/c0c+1cBatm80bAfvysNJudxKe9Leafyw5JlRyWn8D0nq9qxNt3IsbePAjIFTnBES/x6WQ7P23LMfZq5OxxrO5M22PNNjPEYsX35ow55nLWM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783551215; c=relaxed/simple; bh=qmdyhWlXpg0lnc4mJROaYhc0UiwrQT/6yd0jZXWQguU=; h=From:In-Reply-To:References:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=Fnjvkn7Jf3mZAbYS1x7IrO5Y5V2uGfbMYenALEshSSHjmK5+FKkbjV9yM/sLeVIU3uf2pOGv987reFU/TKUSPBRAZ0eSAtwg7NQ2b7CtB4QajoZSb/M4CInnR786Og0SV6ib+bfyT7c/BHOqEuw/tXPPlNGn0Ny1Udqu9W493HA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=O0ntrqPG; arc=pass smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="O0ntrqPG" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cc8e87f29bso10259555ad.2 for ; Wed, 08 Jul 2026 15:53:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783551213; cv=none; d=google.com; s=arc-20260327; b=ByAcK597GXOimwCq5wITV82bMWdvzazCd8O9bpe5c1+jujSYlUw6362nEGD1j9VFUy S2jqbIZhPfdunxOI0uncjL34eQGtd/q9XU1zsop8yqUoDVfuUlrSc7thZeoyFsTM8KSt pR60xah/gWZ4nDsNYKRPO7XCBfWv+H2hkDeuJuhYQpw6EWxUUnNC7evlBw6Ls9KtQPOd TiAHnhLCC4gV20zEiCmNOSmPMmdWv5+8Ux6QrZIxFym32VrJoYL3LiLVuepQIsCCEhz7 heGB5b1T1N1YPAQbvFC2ElLgQrxHiZ1UBhlYlzk05HEMitzaaVa6xyzEmUKT/ZPDdHmE DPnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:dkim-signature; bh=VpsmLVfJoWBAFXap/hXzRXdwAmXfNn02DeflvzyEpPg=; fh=Wy7IOXqgWpY9nHOSDuXy/QSKR665agZqifkOxQKiP0I=; b=MOetr96D9Yj7BeeICO5RZFsyQg5Vdx8f+/XRn5AGIG/qNqO6GoJkyAlQZDpeBIpv26 k9oL2sB2vJ75yOQOUJEVbeVQWfTpKM2+RwCYrsjH0Oc2K32vnKO+7ZwD0lRcg6TqIJq1 kqmQSt2SeO+Ofi+AtOIt+2PQ4xkFxRd2KdbY382XPmTRUhdO6tNfffI20Mtm1e4lvwIy V1NzBaYqEt27kqoTrZW13WJWJjzftq5cT7fvkDgiS1G+2bmhJq0tGU02w74laELtPZtk t9DD8iHBm9CZWy9OjHZVc9fyMMX83CUaixtTzpwJptaCLdgi7Z45qy7p5xIBfMhkl3Ds 2ckw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783551213; x=1784156013; darn=vger.kernel.org; h=content-type:cc:to:subject:message-id:date:mime-version:references :in-reply-to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VpsmLVfJoWBAFXap/hXzRXdwAmXfNn02DeflvzyEpPg=; b=O0ntrqPGXoaraeiLI9IG7wl3UGGbHjadxj+8mxz3lRfNw6EdrvoSMObnvpVl47vSmT XIl4TJ0Wy8EoamRT7/YusgmOHEls0DsJZjcGSnjHj2AKMxLBdsaw7QadiZ9lIBNXi4hX VJfSQezGFl0bbJ2vN+3f+HxodjN4wzmVT1oTgT5kDOPk3hVAbe6RgvzCw54WQKjA1VTO Zh65ZmoopauWXC2C7H7owG7sfk8l6j+iyCGnJV2EW6Am6vWnYML9p/2RASvw9JVfbkoT diKJg2kgBsK7Q7POpIoIVtebby5uiCuV9/0dLIZyJJrJ9fM8xZ29Y2Vs4zthMS1Ic3l0 maxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783551213; x=1784156013; h=content-type:cc:to:subject:message-id:date:mime-version:references :in-reply-to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VpsmLVfJoWBAFXap/hXzRXdwAmXfNn02DeflvzyEpPg=; b=lXs4dVF+uGFmc+kLwkcG6qjuiRAkUWr2iJyu0bHUaeS47mV9si5NtWRZA+l253OZ8k 3DNgTgdqNg6EFjgfgGj9kkrWZgCvvC2IlpsL2oonY6+hrt8o2zPvy6lVQ2tvDgEC9a3L 1PW0hNfYJ8Vvru1sz6COU26VHlXibUTqsjjmC7OOp37Tanuz02AAzE2yrf5Ngmb0ZNuy Kkbcjc3ddLnyP/hf7GLOIMTmmNYKeXTZf+hgjLtVT3slXjV8yheiEviLWLlHd3Q9o+3m ObcfbsKOBbN/ovtQ0OB7mHBaDfhfhaSoiJ5ofYWpJ/gs4L0zKAKq9e/Svcr2jbWAvRyN vfoQ== X-Forwarded-Encrypted: i=1; AHgh+RpU1kFQzhoD9dqB8Tzen/bZ/QjotdKzsridy08Ll6G3KJn0K2eFPpGitmK22YhW7fGVKyHiu2IrHgkN5a0=@vger.kernel.org X-Gm-Message-State: AOJu0YwIZxmByNeM1slI/+YZfaWbzBz4BWCGYeSfXhVoVY34dVjZo8Ze nt8+FmQbXr8p91e1/DIFLLCQjhipaDHxdWxtFqFjoYGqI0NCugRt9Apmck1fGkh1MidzIEkKY40 /0YotDh91R26fSjv/x6t2/qrE00UF5+Ohy1gsUE0FstTUQhsW+FXGDQC1 X-Gm-Gg: AfdE7cn4QbTSJCAPc8on/kEsmnWj+cA+QSxBDP7qdajaI1iNkXAJ9vSep8gUcCETMsR UpDgOucqe9ef0M2kgKk/DLXI/N290ZG3PSqkE4tU7j0fszoencSujHEba/8StISSrzAOQOlilfs tpVGbXOF7fmPrEeTNqo+jrCGmlYlXLC6C1Qyv/Wuc3KRKj7OauSm2QQv+cizhoT4X0pXjiaBjIr 6kuVDwAPmE4IvI99iKKXKGy0MFuzapUZgj0CWg/Su/mdInFDlaL1Tsj4dLT8S81HysKQ65ypqar jg6nnougnzaLSG4hCQd/Kfw4d253U9hzZx5FTQ09SZKxMMY271WUcaafz48= X-Received: by 2002:a05:6a21:4910:b0:3bf:aff8:f572 with SMTP id adf61e73a8af0-3c0bd06a68emr5556584637.32.1783551212907; Wed, 08 Jul 2026 15:53:32 -0700 (PDT) Received: from 176938342045 named unknown by gmailapi.google.com with HTTPREST; Wed, 8 Jul 2026 15:53:32 -0700 Received: from 176938342045 named unknown by gmailapi.google.com with HTTPREST; Wed, 8 Jul 2026 15:53:31 -0700 From: Ackerley Tng In-Reply-To: <20260630222607.497895-11-seanjc@google.com> References: <20260630222607.497895-1-seanjc@google.com> <20260630222607.497895-11-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 8 Jul 2026 15:53:31 -0700 X-Gm-Features: AVVi8Cc4QkzH7H57bOEy1Erexnjx9xcY60lAN_V3_1EbN2LzwTFi4SD7BSMfVik Message-ID: Subject: Re: [PATCH v3 10/12] KVM: SEV: Forcefully invalidate SNP VMSA if its backing gmem page is zapped To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Hyunwoo Kim , Tom Lendacky , Michael Roth , =?UTF-8?B?SsO2cmcgUsO2ZGVs?= , Fuad Tabba Content-Type: text/plain; charset="UTF-8" Sean Christopherson writes: > > [...snip...] > > @@ -1902,6 +1905,7 @@ struct kvm_x86_ops { > void *(*alloc_apic_backing_page)(struct kvm_vcpu *vcpu); > int (*gmem_prepare)(struct kvm *kvm, kvm_pfn_t pfn, gfn_t gfn, int max_order); > #ifdef CONFIG_HAVE_KVM_ARCH_GMEM_INVALIDATE > + void (*gmem_invalidate_range)(struct kvm *kvm, struct kvm_gfn_range *range); > void (*gmem_reclaim_memory)(kvm_pfn_t start, kvm_pfn_t end); > #endif I suggested CONFIG_HAVE_KVM_ARCH_GMEM_RECLAIM_MEMORY before looking at this patch. Considering this, it seems like gmem_invalidate_range is a true invalidation request and .gmem_reclaim_memory is too late for invalidation as you explained in the commit message of the renaming patch. Perhaps the new .gmem_invalidate_range should take over CONFIG_HAVE_KVM_ARCH_GMEM_INVALIDATE, and .gmem_reclaim_memory should use a new CONFIG_HAVE_KVM_ARCH_GMEM_RECLAIM_MEMORY? Are they both invalidations in your opinion? If we're clumping SNP configs together, CONFIG_HAVE_KVM_ARCH_GMEM_PREPARE is also only enabled by SNP... > > [...snip...] >