From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f47.google.com (mail-dl1-f47.google.com [74.125.82.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EDFE3B7B64 for ; Wed, 24 Jun 2026 13:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.82.47 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782308680; cv=pass; b=MlqooqDP/uF+5+2QimyLVhXSDK9miD/Xqw6RYe8DDvtc8vrqPqHAjJvcePbQjfouszWWZwF3egCnCZoi1nXIyRBsPGKigcDZPcTAfA1tKr3ttfFgzLDVLVFLgBVG8Ww08+vaeKWAj3cyPVswqpqOdgudOhxcysTPfGaddLuBzH4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782308680; c=relaxed/simple; bh=qwRcQ/ClJ9JG4ryGwIJuvq/o3tliB127/9EJbI1JGOU=; h=From:In-Reply-To:References:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=GK5Sf33WDdXMvUmJIT8axJvMoO+2o+Yka33Jdi61HqpkS84eR6KVxtEOB9jRlJbKCXGussMCvsWF+cQLkRtiakPcZSqyYTyRhuUa9/UNGJbQU90WLrXT+o0Qr1QWDrp04L88c8sgXw54SPUwWS08Kn3W12YD697j/vzro80Yzhs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=arPYaw0m; arc=pass smtp.client-ip=74.125.82.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="arPYaw0m" Received: by mail-dl1-f47.google.com with SMTP id a92af1059eb24-13981833e13so1254448c88.1 for ; Wed, 24 Jun 2026 06:44:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782308678; cv=none; d=google.com; s=arc-20240605; b=YRXHtGCGhs+A8RlA0RdDg1pWSo5FuPXAcASw1TLgJ8J1C0hHyb18mLwWWHLJ3kcqjC vFIVi011p7WQ+n3Z8QrJ/nfpiXq/TuonVTsd63G1Btuj4/2ze+F8UAdZ5nAgciH0qtcS 24G6VJxRG+fYsc9gRAmwCHMglkVKhPyflH74HDKZgtS7DthvpNkrH6HIYrtXdud0dKbH Np+pco21mdADGYCc2OkANRCArwBfwUTUBImr3iZnH8JJiBxq1dzUIZvebA0YBZdKG8UI 9Sup5Y3taQ72pxDhNNL5uesIbH2cCwcYhqrjnIybVXtTQXMDVNnuLsVh0KBOSOIif9VI iIyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:dkim-signature; bh=OMYX25sMe8BokvDqBMKpyH1gjAy6dHukDWPb7UeMT1Q=; fh=2dJRVqyyX17WaLQtKMwnidzt0XxloPYFVN4PHYSKEmE=; b=FisOg2lJoWtDX4637z4QPCZgZTT1AQvb2Pa20JBffwsseDqCeUh+974Nv0r67bmXf5 yKY6+Z5iMBnstjTgxEhGUqf+xrfBAuuDFV61TXhmAuHu1/JqvcDNpPSvYW3Kworm6fDx hJgjTjKdTVaZlIBxApG4AGnkE5nV4vhOrbpAVXMZiTfOWdfBn+wegQ/fSDrThBJ1RPS2 g3zBvE7U+qkKVlBGgT8w0h7M/shokRCyWGnXHpzbAjfaMQpyolxiTSrQ4zrKyTW7fPRn BpOem2ufU857boN0WtQIf0k2ZOk30yaevyhFma9Rl2TtoKVVr3FC2YtPx8Mhwfc/AIc6 yLNA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782308678; x=1782913478; darn=vger.kernel.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=OMYX25sMe8BokvDqBMKpyH1gjAy6dHukDWPb7UeMT1Q=; b=arPYaw0meVRjPYrgms4OkOLXFt/8P2iuU67wri+g544HgClaDMzfIAQhy6BtPLeVh4 2nSTG1S1xNZsTnS+t2dJfwbJ/WtjWp5jPYDuti7YH+wZSG1d0uJTdBdqVugF0F1GJqlm mz+2HQHL4z1TPCf9je/KZBzz5f+CiZiX0tyQKqwTjW/ln09HIuiZ6YRJDPKI20kCZR91 3HAt6Csj4wOcpZv/Cji3sdK5CsaAUxp9ekhKCOUF/PICHIw1Igqy4Ciu3GdgYIPHK4QH H/WjUDgtm4HpMCfS4bUR0sZrBlSONDoE9rG/SPXL+VDaKdXX8ycoZFH0P8eihDqUY/Hr qBSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782308678; x=1782913478; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OMYX25sMe8BokvDqBMKpyH1gjAy6dHukDWPb7UeMT1Q=; b=C3zFtIReJC6O4JbsCWEtzZKqEItpBNmZmYmb8NnV6HYAgSZ5MDr9aYJEwEBkd2Ctlr PbV74e87TJ1jwhwgx9eNzohgvrFjmN7yn0qxGWqnF0PL/XGNwZxWnY3EVfCF/KRLwBBK I2ZfER62pCuwY6Sw6WoEUc/lYVJaLt8+Fe8+goHlvbglGDzgAzCndiS5wgf9uPYjv2md TvhPzoeKNexdRwRKa9+z75aMphFnEatB4LfBaFrbHkh7QKpSWZP6G8LGKnr7bzm4xC6s Jcuxt2Q8OVqquAQ6koazZlA7QVFfMqjxGynG1rGMxb2zq7dm5j36X5es1LYgwH/Iq8Yf Tvcw== X-Forwarded-Encrypted: i=1; AFNElJ8Uh3yQ0xv8GfrmgoSVIjciE284L8hFsICVkb2sxNuJVa6OkN9cpaYhc1eWPo87sEip2lVlyeWrxb7SYTQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxJBeZ9bPfqnG51+nv9f+OLXCUsXYEVSDEnoDDzD5TTq0fuBpEH lquOedcN2yBij0V9vOV8GQwafvU8dsPBH7IGfluxvB0JmpoyL/ecOpCi/ZuMSArO1+Qou83DD5u 3vuXGDSd2G43FEAvIUWdlZ7fOn/y0FFAaNWLPdLAf X-Gm-Gg: AfdE7clxjdclB0bIgnUI7kspQF4dJf7j+XPx6QLkcODi16MBnbECl6/pUJ4Jfyxr80e PYndkFdEwnyt0OSciwXqz5Zol0WzeVFFBfwYx5njz5VnJBgngtR02RU4ZocU5ThDqDBS+PpFylK WH1IfxCIqa5T8qw+NVBWIxbFYpfV2DGc9Fn4bCDj3RUBaFxeEgOoqgnOd8GGlxUPZmx9vyHcsq6 ve4L2wu1KdgDPtam20m5F/svljqGXGg45geQ8CTLJYENlFYF6UB+506zFDU8lWANI28kUpSfXaw H8j0otJ5Yy4Y4ZtZBGJxTyui52ey X-Received: by 2002:a05:7022:ec0e:b0:137:eb26:10d with SMTP id a92af1059eb24-139c5b99857mr4976083c88.0.1782308676421; Wed, 24 Jun 2026 06:44:36 -0700 (PDT) Received: from 176938342045 named unknown by gmailapi.google.com with HTTPREST; Wed, 24 Jun 2026 06:44:35 -0700 Received: from 176938342045 named unknown by gmailapi.google.com with HTTPREST; Wed, 24 Jun 2026 06:44:35 -0700 From: Ackerley Tng In-Reply-To: <96fb369d-dbff-4ed6-b1f9-0ce63d7d4ed0@linux.intel.com> References: <20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com> <20260618-gmem-inplace-conversion-v8-7-9d2959357853@google.com> <96fb369d-dbff-4ed6-b1f9-0ce63d7d4ed0@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 24 Jun 2026 06:44:35 -0700 X-Gm-Features: AVVi8Ce7qJauzHB_wQ4GZOmMbMs8hfgU2sTfkjTDTjUh6bKjOQAsxLqy1nK_op4 Message-ID: Subject: Re: [PATCH v8 07/46] KVM: Rename memory attribute APIs to prepare for in-place gmem conversion To: Binbin Wu Cc: aik@amd.com, andrew.jones@linux.dev, brauner@kernel.org, chao.p.peng@linux.intel.com, david@kernel.org, jmattson@google.com, jthoughton@google.com, michael.roth@amd.com, oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com, rick.p.edgecombe@intel.com, rientjes@google.com, shivankg@amd.com, steven.price@arm.com, tabba@google.com, willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com, forkloop@google.com, pratyush@kernel.org, suzuki.poulose@arm.com, aneesh.kumar@kernel.org, liam@infradead.org, Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , Shuah Khan , Vishal Annapurve , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Youngjun Park , Qi Zheng , Shakeel Butt , Kiryl Shutsemau , Baoquan He , Jason Gunthorpe , Vlastimil Babka , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Binbin Wu writes: > > [...snip...] > >> +static inline bool kvm_mem_range_is_private(struct kvm *kvm, gfn_t start, >> + gfn_t end) >> +{ >> + return kvm_range_has_vm_memory_attributes(kvm, start, end, >> + KVM_MEMORY_ATTRIBUTE_PRIVATE, >> + KVM_MEMORY_ATTRIBUTE_PRIVATE); >> } > > This function is added, but never used in this patch series. > Is it intended to be called only when CONFIG_KVM_VM_MEMORY_ATTRIBUTES is > enabled? > Thank you for catching this! I think in some earlier revision this was meant to be used from the guest_memfd populate flow. I think the version of kvm_gmem_range_is_private in this revision is good because it is symmetric. If conversion is enabled, call the gmem range-has-attributes function, and if conversion is disabled, use the VM range-has-attributes function. Sean, if no new revision is needed would you be able to drop kvm_mem_range_is_private() while you're pulling it in? >> >> [...snip...] >>