From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Xianwei Zhao <xianwei.zhao@amlogic.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: amlogic: a9: Add IR controller support
Date: Wed, 8 Jul 2026 22:02:57 +0200 [thread overview]
Message-ID: <CAFBinCBQ+g8Kr2tL9ob9PvTakGrtwH3qZWjEy-ytGiufGUEieg@mail.gmail.com> (raw)
In-Reply-To: <74fc6cfe-f844-4cbb-bc1e-0ad96af37040@amlogic.com>
On Wed, Jul 8, 2026 at 4:39 AM Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>
> Hi Martin,
> Thanks for your review.
>
> On 2026/7/8 03:33, Martin Blumenstingl wrote:
> > Hi Xianwei Zhao,
> >
> > On Mon, Jul 6, 2026 at 4:43 AM Xianwei Zhao via B4 Relay
> > <devnull+xianwei.zhao.amlogic.com@kernel.org> wrote:
> > [...]
> >> + func-ir-in {
> >> + remote_pins: group-remote-pins {
> > Can we keep the established naming:
> > $ git grep remote_input_ao_pins arch/arm64/boot/dts/amlogic/ | wc -l
> > 37
> >
> > I'm worried that adding IR blaster/output support at some point will
> > then lead to confusion.
> >
> Will do. I will rename remote_input_ao_pins.
I'm also happy with remote_input_d_pins or however the datasheet calls
this pin/function (seeing that A9 has AO, C, D and TEST pins in the
always-on domain).
The part that's important for me: include "input" in the name (so it's
clear that this is IR input, not IR output).
prev parent reply other threads:[~2026-07-08 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 2:43 [PATCH 0/2] ir: support IR for Amlogic A9 SoC Xianwei Zhao via B4 Relay
2026-07-06 2:43 ` [PATCH 1/2] dt-bindings: media: meson6-ir: Add Amlogic A9 IR compatible Xianwei Zhao via B4 Relay
2026-07-06 6:59 ` Krzysztof Kozlowski
2026-07-07 19:26 ` Martin Blumenstingl
2026-07-06 2:43 ` [PATCH 2/2] arm64: dts: amlogic: a9: Add IR controller support Xianwei Zhao via B4 Relay
2026-07-07 19:33 ` Martin Blumenstingl
2026-07-08 2:39 ` Xianwei Zhao
2026-07-08 20:02 ` Martin Blumenstingl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCBQ+g8Kr2tL9ob9PvTakGrtwH3qZWjEy-ytGiufGUEieg@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox