From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89C4C39B94C for ; Tue, 16 Jun 2026 07:45:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.180 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781595924; cv=pass; b=Y0tk4OU0l0JkUrcyN81jnfmEF4XfvAOlM8ifxKCw+gbOfj2l9JwVIhNSE4SBglhP8wDK1XOhAPI1NFIAS/ivBCMM3QIfDiKv61Ug2hwjmtqWssGL00T4B/oVgFlzdgS9oMw0CbT2gY4iUpgNMkL0cfra/v089OIaDjYKY7EaMLY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781595924; c=relaxed/simple; bh=/o2igankPbB1v37OJbLF8aUrEdpEP7CODhoZ32CJ03Y=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=CvCCB2g5SUEo6BP9geglj48OhKt1ePVFSbtGSdfwPhYLscIoF+3ToaoiRchDVJ/+uJDaOa2/vCEJWeOYKSJNmOkQH6iv449CDiDMecyR2TYgPewRgU3VfANP62ayPfZ2ZGfmrOFdffsXIvjwZMiMPDas9LrDm9ypy5pAW5k1zRg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a8/bZM/f; arc=pass smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a8/bZM/f" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-7fd8446a1cdso1628837b3.1 for ; Tue, 16 Jun 2026 00:45:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1781595922; cv=none; d=google.com; s=arc-20240605; b=N3TWN+5bCXnIGJNRclLiPyY60Gnds4V6r1I9N6xLIt1jn33yQuuVjhHc0wqrJ+QBwm HaKG9LuaHerikmSyE3FApa3AHAD3xTbPP4JSRw19gJy9uiz0bVfxfx8yg3ruKEsIzHy8 y46hVYjEYGOcr59zA+07eU+TjVxEFGDYWyWrsiKahlgcGvRUV/PUpNsqFOH3NUchLVXg HozXbIAUq6OQ7jH9KOI7s218RmNVM6ACjLNC4sgHiLP9k1FixPTx29HBSIKDJofBWXfZ +dDnxEoG8jb+j4gjfkD1a+db/MHY30RtJEByfbDGQhNMj580RoI4MOoOVa7J7H/UjHzn m6Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=/o2igankPbB1v37OJbLF8aUrEdpEP7CODhoZ32CJ03Y=; fh=Rjqt6AJOvF2wAeIX6HPG4k5Y39/VZXq1i4cYpWtce6M=; b=RyOA78B8k0k/0fbT6LtS7Gt44TXtXvDQqZ8YDuNrtnWoH7vE5gvuaycI4Reqta/ga8 DL+0bn3HsI+yVoK43X7ylf5c8lTTCqkKSe6ClC6PiMMb7GLHp/ikI48wmZhL0mYGKk48 7JtdAHt6agFI38f3pnyIozth+vA43mbdLUvmXImB88VmeAt0+2t5VQKIeBGITzcyT+D3 Ip1b8nc5DSL0RWr9oFj5HWDzK34zl1+OG1TI1EXfamUstibkgi3zhE+xZrI2/ZNBA/Zn L1N8xxvg5oVUPLsBdDwSWh4/rP4TgJerXQOXOthBdKLrcNY+MbOlxhEcQDHgNkWxkJZD +tAg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781595922; x=1782200722; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/o2igankPbB1v37OJbLF8aUrEdpEP7CODhoZ32CJ03Y=; b=a8/bZM/fh04skRt/ZqAzs1wiX3xZ5pALnMy1U8UOyNiOzA/YekcHFcBZGkBWSr3nSL XMPwsPoj+KFJR6oRxFev/ZhYmMJV5OANk8+cOxmXc3/8xUULtyCtvZA01BW+V4i6OHKU sghQ9Xsncg36uL2L1usmWlPvyurrZBPENeZ5nchmMnf4guGg6fYK16UVlQ83EByG6FRn fW0NH4de3cYWWYAeAV02dARM3ByIfGKpsEDyIK+BeWs5iU/X3iY8QL+ptIm+Qd9F18jh rRnB4Qtv4R6Cs/WyKUCwdTbwnNkV0wEoVx2xBPOLhMEjwcLGKbBGMLkSmRCnbqCj9ZKa 2GEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781595922; x=1782200722; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/o2igankPbB1v37OJbLF8aUrEdpEP7CODhoZ32CJ03Y=; b=FNAUPdmwUep42s4KkEMGuTZwQuidc7/DSUOGc2hbE3dfdWk20whvj91/YYR3VUtnVb 5JWChma0GYPAEiV6PzyBy806uSOUX7TVoBWnRb2jr4/drdmmBJk11EJT5v46qWSlBK7F PF0MXqPSyI7ciPsRDDKtqFjvvK/4jonQ4UwSyz44SVV2biP2XKKcazZrZubE14Hq642m m2XAE209/qukgSWBDV3f86NZOzKnwfZgbUTiY3FA9xQIC5qvLCchNyEZ7zQmf0Ee8D1D R3WxBV5gpa7XyVziozW3sxX6z8qJgPVt1HrKU7Vvvw1To51NWdNtIsmS6+gDNJvKvpJW wdXA== X-Forwarded-Encrypted: i=1; AFNElJ8H+qG869pQC4LBFUlsLY71gzmkIUxElEAO1ND65lswlsGrlR0MavvXdC4CtOdT3VKs3OaPgxwJTkhX2wc=@vger.kernel.org X-Gm-Message-State: AOJu0YyalBIDRBtduRjGlk1sMf1OEnCMnT3Sg2FvlZxP0XMszquzbFiF MhZExwMvnLhAqVha3fWhE1qTy+buIqyyfT/lJK/t8BxSW+BLrSsIgdHhKGJZO+GpYh8COOCJZ9p UUP/BMWKtOL5jU3onfbMz+gBoTfqan0Kg4OnahvM= X-Gm-Gg: Acq92OGD9l0S/FuizzVhLdIYTmW8DR0+ra81dScGqy7uobHLGS8no7RqNBGfw6V+mva A8xfIamhmCPYz/9rfWRvOMktN6T1yOtr8i2MADixu0SQNRrLTjwiqjcfaNWBpEIcOfRFSZMupFP X2NQIPVaGckW47EuP0AGgkn5nyqKlIPaHw3jLGuh2hbHvsvDAMcljv9fF8CVrFgYUrHPrlXJiFJ FxaWgzD8gd8b+X5W+gbpJBgnAZx9Io9El9sipoyUs9XOXVAyX3ZehaxKAym5WSoYUhj2ft8FfdT p+R4csRBcQ== X-Received: by 2002:a05:690c:e351:b0:7f4:fad5:2087 with SMTP id 00721157ae682-7fd00461af2mr23925877b3.38.1781595922438; Tue, 16 Jun 2026 00:45:22 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260614053345.64053-1-zzzccc427@gmail.com> <84ecad6e-4072-46e5-a2ab-3dbfe5c48476@linux.alibaba.com> In-Reply-To: <84ecad6e-4072-46e5-a2ab-3dbfe5c48476@linux.alibaba.com> From: Cen Zhang Date: Tue, 16 Jun 2026 15:45:10 +0800 X-Gm-Features: AVVi8CdYG-qO-zaqe7kNb_m3dk8AtPh4RzffqOg6YLyEN1cZtVREaW2mecTt2FQ Message-ID: Subject: Re: [PATCH] ocfs2/cluster: reject local node clears while heartbeat runs To: Joseph Qi Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, Mark Fasheh , Joel Becker , Heming Zhao Content-Type: text/plain; charset="UTF-8" Hi Joseph, > Seems a simple fix for this issue is also clearing cluster->cl_has_local > in the same path? Thanks for your review. Yes, clearing cluster->cl_has_local in that path is needed. I updated the patch to do that. While checking this path again, I found that clearing cl_has_local alone does not cover the running heartbeat thread case. After local=0, o2nm_this_node() still returns O2NM_MAX_NODES, which has the same value as O2NM_INVALID_NODE_NUM, and the heartbeat thread can still use that value for hr_slots[] or for the final node undepend path. So in v2 I kept the local node number stable in the heartbeat region once the region starts, used that stored node for heartbeat I/O and teardown, and also cleared cl_has_local in o2nm_node_local_store() as you suggested. I will send v2 shortly. Best regards, Cen Zhang