From: Uros Bizjak <ubizjak@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/hweight: Fix and improve __arch_hweight{32,64}() assembly
Date: Mon, 10 Mar 2025 22:25:15 +0100 [thread overview]
Message-ID: <CAFULd4byd1v26FVJFEWedPCvpCSsSKUj0PKz8gOzdfMqdcOoAQ@mail.gmail.com> (raw)
In-Reply-To: <Z89ImJlHFLJUDhFM@gmail.com>
On Mon, Mar 10, 2025 at 9:16 PM Ingo Molnar <mingo@kernel.org> wrote:
>
>
> * Uros Bizjak <ubizjak@gmail.com> wrote:
>
> > a) Use ASM_CALL_CONSTRAINT to prevent inline asm that includes call
> > instruction from being scheduled before the frame pointer gets set
> > up by the containing function, causing objtool to print a "call
> > without frame pointer save/setup" warning.
> >
> > b) Use asm_inline to instruct the compiler that the size of asm()
> > is the minimum size of one instruction, ignoring how many instructions
> > the compiler thinks it is. ALTERNATIVE macro that expands to several
> > pseudo directives causes instruction length estimate to count
> > more than 20 instructions.
> >
> > c) Use named operands in inline asm.
> >
> > More inlining causes slight increase in the code size:
> >
> > text data bss dec hex filename
> > 27261832 4640296 814660 32716788 1f337f4 vmlinux-new.o
> > 27261222 4640320 814660 32716202 1f335aa vmlinux-old.o
>
> What is the per call/inlining-instance change in code size, measured in
> fast-path instruction bytes? Also, exception code or cold branches near
> the epilogue of the function after the main RET don't fully count as a
> size increase.
>
> This kind of normalization and filtering of changes to relevant
> generated instructions is a better metric than some rather meaningless
> '+610 bytes of code' figure.
>
> Also, please always specify the kind of config you used for building
> the vmlinux.
Sorry, this just slipped my mind. x86_64 defconfig - I'll note this in
the revised commit entry.
BTW: The difference between old and new number of inlined __sw_hweight
calls is: 367 -> 396. I'll try to analyze this some more.
Thanks,
Uros.
prev parent reply other threads:[~2025-03-10 21:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 20:08 Uros Bizjak
2025-03-10 20:12 ` Borislav Petkov
2025-03-10 20:35 ` Uros Bizjak
2025-03-10 20:42 ` Ingo Molnar
2025-03-10 20:44 ` Borislav Petkov
2025-03-10 20:54 ` Uros Bizjak
2025-03-10 21:07 ` Borislav Petkov
2025-03-10 21:18 ` Uros Bizjak
2025-03-10 21:34 ` Borislav Petkov
2025-03-10 21:00 ` Ingo Molnar
2025-03-10 20:16 ` Ingo Molnar
2025-03-10 21:25 ` Uros Bizjak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4byd1v26FVJFEWedPCvpCSsSKUj0PKz8gOzdfMqdcOoAQ@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®