From: Brendan Higgins <brendanhiggins@google.com>
To: Daniel Latypov <dlatypov@google.com>
Cc: davidgow@google.com, linux-kernel@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH v2 2/2] kunit: tool: delete kunit_parser.TestResult type
Date: Tue, 14 Dec 2021 16:44:29 -0500 [thread overview]
Message-ID: <CAFd5g44qB7emcsV_QCtddUcFdoxVUpzoY_fgmRARfDwS3byNMA@mail.gmail.com> (raw)
In-Reply-To: <20211214192612.134306-2-dlatypov@google.com>
On Tue, Dec 14, 2021 at 2:26 PM Daniel Latypov <dlatypov@google.com> wrote:
>
> The `log` field is unused, and the `status` field is accessible via
> `test.status`.
>
> So it's simpler to just return the main `Test` object directly.
>
> And since we're no longer returning a namedtuple, which has no type
> annotations, this hopefully means typecheckers are better equipped to
> find any errors.
>
> Signed-off-by: Daniel Latypov <dlatypov@google.com>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Looks good. Thanks for the rebase!
next prev parent reply other threads:[~2021-12-14 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 19:26 [PATCH v2 1/2] kunit: tool: use dataclass instead of collections.namedtuple Daniel Latypov
2021-12-14 19:26 ` [PATCH v2 2/2] kunit: tool: delete kunit_parser.TestResult type Daniel Latypov
2021-12-14 21:44 ` Brendan Higgins [this message]
2021-12-14 21:43 ` [PATCH v2 1/2] kunit: tool: use dataclass instead of collections.namedtuple Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFd5g44qB7emcsV_QCtddUcFdoxVUpzoY_fgmRARfDwS3byNMA@mail.gmail.com \
--to=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®