From: Brendan Higgins <brendanhiggins@google.com>
To: Daniel Latypov <dlatypov@google.com>
Cc: davidgow@google.com, linux-kernel@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH 2/5] kunit: drop unused intermediate macros for ptr inequality checks
Date: Fri, 21 Jan 2022 17:12:26 -0500 [thread overview]
Message-ID: <CAFd5g46vj-+SyXP-B+AVZ58aNbD2weRCQ63tDG=HfBn3dttbUQ@mail.gmail.com> (raw)
In-Reply-To: <20220118223506.1701553-3-dlatypov@google.com>
On Tue, Jan 18, 2022 at 5:35 PM Daniel Latypov <dlatypov@google.com> wrote:
>
> We have the intermediate macros for KUNIT_EXPECT_PTR_GT() and friends,
> but these macros don't exist.
>
> I can see niche usecases for these macros existing, but since we've been
> fine without them for so long, let's drop this dead code.
>
> Users can instead cast the pointers and use the other GT/LT macros.
>
> Signed-off-by: Daniel Latypov <dlatypov@google.com>
Oh, whoops, I didn't even realize we were missing those variants.
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
next prev parent reply other threads:[~2022-01-21 22:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 22:35 [PATCH 0/5] kunit: decrease layers of assertion macros Daniel Latypov
2022-01-18 22:35 ` [PATCH 1/5] kunit: make KUNIT_EXPECT_EQ() use KUNIT_EXPECT_EQ_MSG(), etc Daniel Latypov
2022-01-21 7:21 ` David Gow
2022-01-21 22:10 ` Brendan Higgins
2022-01-18 22:35 ` [PATCH 2/5] kunit: drop unused intermediate macros for ptr inequality checks Daniel Latypov
2022-01-21 7:21 ` David Gow
2022-01-21 22:12 ` Brendan Higgins [this message]
2022-01-18 22:35 ` [PATCH 3/5] kunit: reduce layering in string assertion macros Daniel Latypov
2022-01-21 7:21 ` David Gow
2022-01-21 22:13 ` Brendan Higgins
2022-01-18 22:35 ` [PATCH 4/5] kunit: decrease macro layering for integer asserts Daniel Latypov
2022-01-21 7:21 ` David Gow
2022-01-21 22:17 ` Brendan Higgins
2022-01-18 22:35 ` [PATCH 5/5] kunit: decrease macro layering for EQ/NE asserts Daniel Latypov
2022-01-21 7:21 ` David Gow
2022-01-21 22:25 ` Brendan Higgins
2022-01-21 22:25 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd5g46vj-+SyXP-B+AVZ58aNbD2weRCQ63tDG=HfBn3dttbUQ@mail.gmail.com' \
--to=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®