From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC7BC19759 for ; Thu, 1 Aug 2019 21:43:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 378C5206B8 for ; Thu, 1 Aug 2019 21:43:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="S/P5gz+a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732107AbfHAVn6 (ORCPT ); Thu, 1 Aug 2019 17:43:58 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:41508 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731433AbfHAVn4 (ORCPT ); Thu, 1 Aug 2019 17:43:56 -0400 Received: by mail-pl1-f193.google.com with SMTP id m9so32644779pls.8 for ; Thu, 01 Aug 2019 14:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tRJWWqPxe4v7OGh5SzFgwfV47CyOeIABo0H7U+M+pdg=; b=S/P5gz+a9jUw7SwOiz84JEbZSB3baAlVLSphUNs8eZlN3ZPowtpH0MpNodRchncDaL h/pwktm3ZoMM5ur9uIqRsyskaBqjhXhPvxaJG//b32Uphj0PG1ynA9CUTm1TW0sAsjm6 HvrHFAepLSyokzes/1ht5wjMSnlrEgSRbO09yXW02SG1IbAd8mAQKhoiLKJYr6VkLWg+ 7rO55CqVAf6utB/oO5cCFpNjfcdHsW2PZ6e5nZCbdexwb5KuZDKGxSTHr3F16NHksaHQ xyoTxMhvtaSYfpReQiXJpspTpAAqnNeKDN71dNMH70NnoXLk5zU84jZ89voAQsdAyikW 53ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tRJWWqPxe4v7OGh5SzFgwfV47CyOeIABo0H7U+M+pdg=; b=pnGcuUIjb+z+M2TWRMkKUoiMmi5qP4OoROstbW0FSXN3lHrg2V53OzJzMuxM87jLRR 1l2RanKZV/tGiQbyHUCen9ytCLIk3OWqB0rsRWZB4XZYlFzmQaaCJQGs9/0OZlhlUeAs ajOpsuTF9u7tUG2HX886hG4eUnqm8H3VQ+YMmbdCz0XiVuuajkx8lnB0ZyWRedpjPewV rVf8QZpvSHgYNm9Zai0385QbDY6/boAw+slgQK0YzZxVJvBVQd9hQXIV6rYdIWTs2TNz I9JrqxRcWSak2c6G9+Rrl3f0pdgmoUIUd5KnsBheen+WI3uYdJuvCBksK/ZpR5ZT4+Ap zx0g== X-Gm-Message-State: APjAAAWGmAlQgXyoL4iv4VT4zCK7yDutn/lE0YL4pjci+zaU5QB61l0+ +d++fhWJ/fFCslCTBUVEqS7qfe52nRbTMrHTbPpAig== X-Google-Smtp-Source: APXvYqyQJ3oYuIkR4HxnjqcvX8HB7OCTCVhJ4Fku+hNPqOUYjGToK6i2G0j1xWhCd4v39RwFH1V7C/0k5dVHTOnW45I= X-Received: by 2002:a17:902:347:: with SMTP id 65mr32846391pld.232.1564695834770; Thu, 01 Aug 2019 14:43:54 -0700 (PDT) MIME-Version: 1.0 References: <20190716175021.9CA412173C@mail.kernel.org> <20190719000834.GA3228@google.com> <20190722200347.261D3218C9@mail.kernel.org> <20190722235411.06C1320840@mail.kernel.org> <20190724073125.xyzfywctrcvg6fmh@pathway.suse.cz> <20190726083148.d4gf57w2nt5k7t6n@pathway.suse.cz> <20190801211447.6D3D7206A2@mail.kernel.org> In-Reply-To: <20190801211447.6D3D7206A2@mail.kernel.org> From: Brendan Higgins Date: Thu, 1 Aug 2019 14:43:42 -0700 Message-ID: Subject: Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger To: Stephen Boyd Cc: Petr Mladek , Jeff Dike , Kevin Hilman , Logan Gunthorpe , Michael Ellerman , Daniel Vetter , Amir Goldstein , Frank Rowand , Steven Rostedt , Kees Cook , David Rientjes , kunit-dev@googlegroups.com, Kieran Bingham , Peter Zijlstra , Randy Dunlap , Joel Stanley , Luis Chamberlain , Rob Herring , shuah , wfg@linux.intel.com, Greg KH , Julia Lawall , linux-nvdimm , dri-devel , linux-um@lists.infradead.org, Sasha Levin , "Theodore Ts'o" , Richard Weinberger , Dan Carpenter , Knut Omang , Josh Poimboeuf , Masahiro Yamada , Timothy Bird , John Ogness , devicetree , "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, linux-kbuild , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 1, 2019 at 2:14 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-01 11:59:57) > > On Thu, Aug 1, 2019 at 11:55 AM Brendan Higgins > > wrote: > > > > > > On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek wrote: > > > > > > > To be honest I do not fully understand KUnit design. I am not > > > > completely sure how the tested code is isolated from the running > > > > system. Namely, I do not know if the tested code shares > > > > the same locks with the system running the test. > > > > > > No worries, I don't expect printk to be the hang up in those cases. It > > > sounds like KUnit has a long way to evolve before printk is going to > > > be a limitation. > > > > So Stephen, what do you think? > > > > Do you want me to go forward with the new kunit_assert API wrapping > > the string_stream as I have it now? Would you prefer to punt this to a > > later patch? Or would you prefer something else? > > > > I like the struct based approach. If anything, it can be adjusted to > make the code throw some records into a spinlock later on and delay the > formatting of the assertion if need be. That's a fair point. > Can you resend with that > approach? I don't think I'll have any more comments after that. Cool, will do. Thanks!