From: Jinrong Liang <ljr.kernel@gmail.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Like Xu <like.xu.linux@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
Aaron Lewis <aaronlewis@google.com>,
David Matlack <dmatlack@google.com>,
Vishal Annapurve <vannapurve@google.com>,
Wanpeng Li <wanpengli@tencent.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Jinrong Liang <cloudliang@tencent.com>,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] KVM: selftests: Add tests for pmu event filter
Date: Mon, 22 May 2023 11:33:51 +0800 [thread overview]
Message-ID: <CAFg_LQVfECWsmcSXJWnnyJK5mZAbjdCTX-RXP3aoDAECTspqkA@mail.gmail.com> (raw)
In-Reply-To: <20230420104622.12504-1-ljrcore@126.com>
Jinrong Liang <ljr.kernel@gmail.com> 于2023年4月20日周四 18:46写道:
>
> From: Jinrong Liang <cloudliang@tencent.com>
>
> From: Jinrong Liang <cloudliang@tencent.com>
>
> Hi,
>
> This patch set adds some tests to ensure consistent PMU performance event
> filter behavior. Specifically, the patches aim to improve KVM's PMU event
> filter by strengthening the test coverage, adding documentation, and making
> other small changes.
>
> The first patch replaces int with uint32_t for nevents to ensure consistency
> and readability in the code. The second patch adds fixed_counter_bitmap to
> create_pmu_event_filter() to support the use of the same creator to control
> the use of guest fixed counters. The third patch adds test cases for
> unsupported input values in PMU filter, including unsupported "action"
> values, unsupported "flags" values, and unsupported "nevents" values. Also,
> it tests setting non-existent fixed counters in the fixed bitmap doesn't
> fail.
>
> The fourth patch updates the documentation for KVM_SET_PMU_EVENT_FILTER ioctl
> to include a detailed description of how fixed performance events are handled
> in the pmu filter. The fifth patch adds tests to cover that pmu_event_filter
> works as expected when applied to fixed performance counters, even if there
> is no fixed counter exists. The sixth patch adds a test to ensure that setting
> both generic and fixed performance event filters does not affect the consistency
> of the fixed performance filter behavior in KVM. The seventh patch adds a test
> to verify the behavior of the pmu event filter when an incomplete
> kvm_pmu_event_filter structure is used.
>
> These changes help to ensure that KVM's PMU event filter functions as expected
> in all supported use cases. These patches have been tested and verified to
> function properly.
>
> Thanks for your review and feedback.
>
> Sincerely,
> Jinrong Liang
>
> Previous:
> https://lore.kernel.org/kvm/20230414110056.19665-1-cloudliang@tencent.com
>
> v2:
> - Wrap the code from the documentation in a block of code; (Bagas Sanjaya)
>
> Jinrong Liang (7):
> KVM: selftests: Replace int with uint32_t for nevents
> KVM: selftests: Apply create_pmu_event_filter() to fixed ctrs
> KVM: selftests: Test unavailable event filters are rejected
> KVM: x86/pmu: Add documentation for fixed ctr on PMU filter
> KVM: selftests: Check if pmu_event_filter meets expectations on fixed
> ctrs
> KVM: selftests: Check gp event filters without affecting fixed event
> filters
> KVM: selftests: Test pmu event filter with incompatible
> kvm_pmu_event_filter
>
> Documentation/virt/kvm/api.rst | 21 ++
> .../kvm/x86_64/pmu_event_filter_test.c | 239 ++++++++++++++++--
> 2 files changed, 243 insertions(+), 17 deletions(-)
>
>
> base-commit: a25497a280bbd7bbcc08c87ddb2b3909affc8402
> --
> 2.31.1
>
Polite ping.
Should I post version 3 to fix the problem of two "From: Jinrong Liang
<cloudliang@tencent.com>"?
Thanks
next prev parent reply other threads:[~2023-05-22 3:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 10:46 Jinrong Liang
2023-04-20 10:46 ` [PATCH v2 1/7] KVM: selftests: Replace int with uint32_t for nevents Jinrong Liang
2023-05-25 16:23 ` Sean Christopherson
2023-04-20 10:46 ` [PATCH v2 2/7] KVM: selftests: Apply create_pmu_event_filter() to fixed ctrs Jinrong Liang
2023-05-25 17:44 ` Sean Christopherson
2023-04-20 10:46 ` [PATCH v2 3/7] KVM: selftests: Test unavailable event filters are rejected Jinrong Liang
2023-05-25 17:46 ` Sean Christopherson
2023-04-20 10:46 ` [PATCH v2 4/7] KVM: x86/pmu: Add documentation for fixed ctr on PMU filter Jinrong Liang
2023-05-25 17:56 ` Sean Christopherson
2023-04-20 10:46 ` [PATCH v2 5/7] KVM: selftests: Check if pmu_event_filter meets expectations on fixed ctrs Jinrong Liang
2023-05-25 18:11 ` Sean Christopherson
2023-04-20 10:46 ` [PATCH v2 6/7] KVM: selftests: Check gp event filters without affecting fixed event filters Jinrong Liang
2023-05-25 18:12 ` Sean Christopherson
2023-04-20 10:46 ` [PATCH v2 7/7] KVM: selftests: Test pmu event filter with incompatible kvm_pmu_event_filter Jinrong Liang
2023-05-24 23:50 ` Sean Christopherson
2023-05-25 2:19 ` Jinrong Liang
2023-05-25 15:55 ` Sean Christopherson
2023-05-22 3:33 ` Jinrong Liang [this message]
2023-05-22 15:02 ` [PATCH v2 0/7] KVM: selftests: Add tests for pmu event filter Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFg_LQVfECWsmcSXJWnnyJK5mZAbjdCTX-RXP3aoDAECTspqkA@mail.gmail.com \
--to=ljr.kernel@gmail.com \
--cc=aaronlewis@google.com \
--cc=bagasdotme@gmail.com \
--cc=cloudliang@tencent.com \
--cc=corbet@lwn.net \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=vannapurve@google.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®