mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch: tile: kernel: unaligned.c: Cleaning up uninitialized variables
Date: Sun, 8 Jun 2014 19:17:58 +0200	[thread overview]
Message-ID: <CAFo99gbK8dsbMVDmef8MuJ3Ed6Lz0FPrMCm86ycMPTV+8gBO0w@mail.gmail.com> (raw)
In-Reply-To: <5393BF61.5010306@tilera.com>

Hi Chris

So uint max was a better default value.
Yeah, good it came into use. The main thing that the code got a proper review :)


Kind regards
Rickard Strandqvist


2014-06-08 3:41 GMT+02:00 Chris Metcalf <cmetcalf@tilera.com>:
> On 5/31/2014 7:00 PM, Rickard Strandqvist wrote:
>>
>> There is a risk that the variable will be used without being initialized.
>>
>> This was largely found by using a static code analysis program called
>> cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist<rickard_strandqvist@spectrumdigital.se>
>> ---
>>   arch/tile/kernel/unaligned.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> Thanks!  Taken into the tile tree with some slight modifications (initialize
> variables to -1 not 0, and remove the resulting dead code in find_regs).
>
> --
> Chris Metcalf, Tilera Corp.
> http://www.tilera.com
>

      reply	other threads:[~2014-06-08 17:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-31 23:00 Rickard Strandqvist
2014-06-08  1:41 ` Chris Metcalf
2014-06-08 17:17   ` Rickard Strandqvist [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFo99gbK8dsbMVDmef8MuJ3Ed6Lz0FPrMCm86ycMPTV+8gBO0w@mail.gmail.com \
    --to=rickard_strandqvist@spectrumdigital.se \
    --cc=cmetcalf@tilera.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®