From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753668AbcASMcT (ORCPT ); Tue, 19 Jan 2016 07:32:19 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35778 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbcASMcP (ORCPT ); Tue, 19 Jan 2016 07:32:15 -0500 MIME-Version: 1.0 In-Reply-To: <20160119094150.GA4991@red-moon> References: <1453134965-6125-1-git-send-email-gkulkarni@caviumnetworks.com> <1453134965-6125-6-git-send-email-gkulkarni@caviumnetworks.com> <569D23AF.9050503@gmail.com> <20160119094150.GA4991@red-moon> Date: Tue, 19 Jan 2016 18:02:13 +0530 Message-ID: Subject: Re: [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware From: Ganapatrao Kulkarni To: Lorenzo Pieralisi Cc: David Daney , Will Deacon , Bjorn Helgaas , Ganapatrao Kulkarni , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-pci@vger.kernel.org, linux-ia64@vger.kernel.org, linux-metag@vger.kernel.org, linuxppc-dev , linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-arch@vger.kernel.org, Catalin Marinas , Grant Likely , Leif Lindholm , rfranz@cavium.com, Ard Biesheuvel , "msalter@redhat.com" , Rob Herring , Steve Capper , Hanjun Guo , Al Stone , Arnd Bergmann , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Rafael J. Wysocki" , Len Brown , Marc Zyngier , tony.luck@intel.com, fenghua.yu@intel.com, james.hogan@imgtec.com, Benjamin Herrenschmidt , "tglx@linutronix.de" , mingo@redhat.com, hpa@zytor.com, x86@kernel.org, Jon Masters , Robert Richter , Prasun Kapoor Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2016 at 3:11 PM, Lorenzo Pieralisi wrote: > On Tue, Jan 19, 2016 at 11:28:56AM +0530, Ganapatrao Kulkarni wrote: >> On Mon, Jan 18, 2016 at 11:11 PM, David Daney wrote: >> > On 01/18/2016 08:36 AM, Ganapatrao Kulkarni wrote: >> >> >> >> update numa_node of device associated with pci bus. >> >> moved down devm_kzalloc to allocate from node memory. >> >> >> >> Signed-off-by: Ganapatrao Kulkarni >> >> --- >> >> drivers/pci/host/pci-host-generic.c | 9 ++++++--- >> >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> >> >> diff --git a/drivers/pci/host/pci-host-generic.c >> >> b/drivers/pci/host/pci-host-generic.c >> >> index 5434c90..0e1ce06 100644 >> >> --- a/drivers/pci/host/pci-host-generic.c >> >> +++ b/drivers/pci/host/pci-host-generic.c >> >> @@ -215,11 +215,9 @@ static int gen_pci_probe(struct platform_device >> >> *pdev) >> >> const struct of_device_id *of_id; >> >> struct device *dev = &pdev->dev; >> >> struct device_node *np = dev->of_node; >> >> - struct gen_pci *pci = devm_kzalloc(dev, sizeof(*pci), GFP_KERNEL); >> >> + struct gen_pci *pci; >> >> struct pci_bus *bus, *child; >> >> >> >> - if (!pci) >> >> - return -ENOMEM; >> >> >> >> type = of_get_property(np, "device_type", NULL); >> >> if (!type || strcmp(type, "pci")) { >> >> @@ -230,6 +228,11 @@ static int gen_pci_probe(struct platform_device >> >> *pdev) >> >> of_pci_check_probe_only(); >> >> >> >> of_id = of_match_node(gen_pci_of_match, np); >> >> + set_dev_node(dev, of_node_to_nid(np)); >> > >> > >> > This shouldn't be done in individual platform_drivers, but instead in the >> > device probing code. >> > >> > There is code that does this in drivers/of/platform.c and >> > drivers/of/device.c Is that not being called for the pci-host-gweneric >> > devices? If not, we should figure out why, and perhaps attempt to fix it >> > rather than doing it here. >> is it more appropriate to call of_platform_device_create ? > > That's already done to create the platform device by OF core when > populating devices from DT, what David suggested is that you should > add set_dev_node() to core OF code instead of adding it specifically > to the PCI host generic code. This patch was worked on 4.2(inherited to 4.4) to have correct numa_node populated on sysfs. however, on 4.4, OF is fixed to set numa_node(fixed by 56f2de81e020c537f7e35550d13840143cb765cd) This patch (patch #5) is not required and will be dropped. thanks for your comments. > > Lorenzo thanks Ganapat