From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751646AbdFFPEt (ORCPT ); Tue, 6 Jun 2017 11:04:49 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:34104 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbdFFPEr (ORCPT ); Tue, 6 Jun 2017 11:04:47 -0400 MIME-Version: 1.0 In-Reply-To: <1496760340-27959-4-git-send-email-j-keerthy@ti.com> References: <1496760340-27959-1-git-send-email-j-keerthy@ti.com> <1496760340-27959-4-git-send-email-j-keerthy@ti.com> From: Enric Balletbo Serra Date: Tue, 6 Jun 2017 17:04:45 +0200 Message-ID: Subject: Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF To: Keerthy Cc: Tony Lindgren , milo.kim@ti.com, Lee Jones , "linux-omap@vger.kernel.org" , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Keerthy, By change I was looking at this. Some comments below that I think can be applied to all patches in this series 2017-06-06 16:45 GMT+02:00 Keerthy : > Currently the driver boots only via device tree hence add a > dependency on OF. > > Signed-off-by: Keerthy > --- > drivers/mfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 75b59f1..2d1425d 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1297,7 +1297,7 @@ config MFD_TPS65090 > > config MFD_TPS65217 > tristate "TI TPS65217 Power Management / White LED chips" > - depends on I2C > + depends on I2C && OF Shouldn't you add || COMPILE_TEST here ? > select MFD_CORE > select REGMAP_I2C > select IRQ_DOMAIN > -- > 1.9.1 > I think you can remove the of_match_device checks in some drivers too i.e: http://elixir.free-electrons.com/linux/latest/source/drivers/mfd/tps65217.c#L330 Regards, Enric