From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2CEE25B09D for ; Sun, 13 Sep 2026 20:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.218.49 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789331853; cv=pass; b=ccDSl8l9GFM8+MU6+97OWOeQHD60LCpJcUFKKPrUgUsdj+kFSv8cPk1ySyaIh5AelB08wgFqIHHMub3iSyiyJ+IiPXY/9oMEecFVYj+P+Je/fsOjOHK1Anu5uXeChMIjXmz7DBAYcBO0YvBWd+HzjX5WY8aAsmFIAGBxMwvRBvI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789331853; c=relaxed/simple; bh=QRlXaDt+1eNu4QjqDmUDrBQ10IBvdIZqZrhkJw9QL2A=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Ht1raN6cZucdks43jUqPGu+t26UE5WOiu33s4JG3bX1Hny/fQ7g57acX5GST78eSvqkLU13Gc2KlTfSvrVdoU5ruvnLp2vQJISN8igym5VRMMJIPt7eD1+F2ZSpggJbmZSKN4ihmuUeExfEsHaWyHOBegYplIvCQfluuY+8Dkx4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m5H5xcDU; arc=pass smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m5H5xcDU" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-c262204cc80so363157766b.3 for ; Sun, 13 Sep 2026 13:37:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789331850; cv=none; d=google.com; s=arc-20260327; b=pibytS1j7bT0t3h17jNrbC4WQXcwB8c6xSyRPS6Dj9YEBzKrGPgXMKKTEhEIoacQBz 25yMtr6NZ4pEAcHZorydIoiymgaQyNbANWMbEdFogtKQqztn6Y7YFFa0KVQaTKJxhKMD Ug1B2Xbz7lJ+4TLdHxOSNSPNQh6plste25W1e/zqhFiahAVWvcrZyDJezoFSsNYDIxj2 jH1dovuFyF7u7bkqhBZoYW5qVftLX+ryhXISf3cRkpWfP7H9zwTx+DtY/xNgFgbrw9xi LScoQoYRz6GYPkOgkVuG7tntnzBc2YsAp5J8t8dF3YTJMwgvHhRTuoWzfk8SZ7zz4zxo fWPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=QRlXaDt+1eNu4QjqDmUDrBQ10IBvdIZqZrhkJw9QL2A=; fh=ErGIMNlGthK5jzC06SLMzZBCQvMjIrBDzvjusoxfHmM=; b=f1Lfts7WRPXlXozUSP3t9sLzKc8V3T2bD7tSrhjolR5jPeqkas2DgUTX+dFgYB/fBk rFypk3vpXeiGiRYBqyYW4hhOqZXMHe4+ZCPzD4zoxA1mJwo72XAh78hbl3hTEeNKtLsC fwVmxtWDv1Iwy9cGlhtYPMjiVIMQn22zyTP6g8+/MHtBO8uvneh5OYzKfSyM5hUm+li1 1uL90Y/t2L4upsU0C0+CBu/Vcn0sfp5FktVP5AWLGjEaff6y+avFQ/MlvumJQITK3gLQ gj/VQ4tucgvl6N74aNYot0myYyzzVORXluyO18BKsPDWNIUBxx5uBkt0r7Jh+C8TgtSx 04Iw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789331850; x=1789936650; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QRlXaDt+1eNu4QjqDmUDrBQ10IBvdIZqZrhkJw9QL2A=; b=m5H5xcDUrwwVasUqj64QJsjFN3s1Arc/cnnAzxNf7//rS/LqvRgSAW/AAR/ntc8/yH cnnjRhLtnEMeBmvwd9lPjpboFw2wVTMOEIQzYX7Ed9dbcnZvCrW44ax9hoKsxgBg5DUw zf5o2CSJ3qJXx2qVniaXW7w1mY87bJynfMFpPzRyR1VJoKLrIHmja0NyNsEYfVeJZTjR uZmNBRj+u9vjjn8njjPyMwsKtFugi5jN5Gzg7tpEdgFzsDEU3Zt3qB9MU7mM3psRCiqX uqVPRT74pXYRY78O/SG94h6wuuQgH+PEkmdjEXufjLXANE874AuP8siuTIYjA2h0Uyyi 89Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789331850; x=1789936650; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QRlXaDt+1eNu4QjqDmUDrBQ10IBvdIZqZrhkJw9QL2A=; b=BRUFFv2duTkGwMxFIYFUzS7SOGG7vAWycv2IJJaEDqA4q2qsjPz+8gaO5VNVzJabMP XSxy8owu0hbatPPLiIRp2EjuonrnLdprMHkmcS1j3+D0DktvzC3xZybV2NiqMR/2/ETu 2Q6B709enq0tOP9jCYqIk7+HAOrimUFEZi0SHMfHnPgdTp/l/6tIVInut0wPJ8wcINh5 ZN64MXsLzeinMQC3Apx0eXTPklNVA0LjBJrYFyd05pIqgOhhiegzqqbltQmykcDFVH0P ck0OLBxWdWXpF1NuNjrwvqMky1dPI/ZAZnbwigLP41NEiYYhzBuDDIWAhxpVYOyXmYhH Z+gQ== X-Forwarded-Encrypted: i=1; AKwUvBxsxAIKL7/3qxuswwZOvGpNJoxw+hJuQiHqvKW90mkAshNG4Q/LHgXAfuyqoCMPDJN/YkiAZAkVGcQGhv0=@vger.kernel.org X-Gm-Message-State: AFuF++nSTR1+787Tm6elAA+CHix9ev5yUtWndwzgG7MNyTKV4R4qeU6W tOFnVOsi+4S+ExtO7kDpYKUl6OO48ZxeA1EDC3LYpv2PxVoaXr8B2BmbEIppJOAAp8W4KnmdBOW 5zJ/G+OanJPCCyyEE0QqwDQFN2ArZ+Q== X-Gm-Gg: AYBFou3cHGBaVOhsxgJddhAcXCkr8xWw2aARB1ZUAT5l2boGl2F5uD1xw+X34v+DGVH Fa7+5Ig2b2YuobnnB4X2W319bfJkFAhbIaunLQamIyFa/b/aowax2OADgbl3RCHse5CGt82UCFx Yz5ThEa09nZTELPrxE/R0OJnuVLEudiRL6vTJX/qDrbgBL4lmJdonb0T4F2qMGsB8ytapRpMULR kpNfmn1XPpzT/+40hYy1aPAQ6c2OEts82n//Pd2OZVVQr5BRDGa7tw5nHXiuaPCiguDKZkAu82y adE2+FfBjP0L3/9xsbwASKRk4emvg9A/lnTy3seOyRqVG/H+OiJwLCIicXnmSiSCQZ5o0Al1qP5 7C/WJq8G5mXAoj+4rcvzamA35xI/ZKrSs/w3MvJyjyBs2F0euw5l2zt6RKUC2Feihng== X-Received: by 2002:a17:907:9288:b0:c29:583a:c291 with SMTP id a640c23a62f3a-c29665dc5e1mr700951366b.21.1789331849719; Sun, 13 Sep 2026 13:37:29 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260731161740.44955-1-mhun512@gmail.com> <20260910231400.31919-1-mhun512@gmail.com> <20260913143218.GJ48209@horms.kernel.org> In-Reply-To: <20260913143218.GJ48209@horms.kernel.org> From: Myeonghun Pak Date: Sun, 13 Sep 2026 16:37:17 -0400 X-Gm-Features: AcwNN1WyHHF9rKOVVRVH7Q63v4FKYTOEzfxobu1blNdd3woeEdHWTYWSY1gACZQ Message-ID: Subject: Re: [PATCH v2] net: 8390: pcnet_cs: release PCMCIA window on setup_shmem_window() error To: Simon Horman Cc: Dominik Brodowski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ijae Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for the review. I'll drop the Fixes and stable Cc tags in v3. 2026=EB=85=84 9=EC=9B=94 13=EC=9D=BC (=EC=9D=BC) =EC=98=A4=EC=A0=84 10:32, = Simon Horman =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Thu, Sep 10, 2026 at 07:14:00PM -0400, Myeonghun Pak wrote: > > setup_shmem_window() acquires a PCMCIA memory window using > > pcmcia_request_window(). If pcmcia_map_mem_page() or the subsequent > > ioremap() fails, the function returns without releasing the requested > > window. > > > > pcnet_config() treats shared-memory setup failure as non-fatal and fall= s > > back to setup_dma_config(). Probe can therefore continue while socket > > window 3 and its reserved iomem range remain unnecessarily held for the > > rest of the bound lifetime of the device. pcmcia_disable_device() > > eventually releases the window during teardown. > > > > Route error paths after a successful request through a new release labe= l > > that calls pcmcia_release_window(). Fold the existing buffer-verificati= on > > cleanup into the same path, keeping iounmap() before the window release > > when a mapping exists. Leave the request failure path unchanged. > > > > This issue was identified during our ongoing static-analysis research w= hile > > reviewing kernel code. > > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > Cc: stable@vger.kernel.org > > As pointed out by the AI-Generated review of this patch at > https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260910231400.31919-= 1-mhun512%40gmail.com > This patch seems to be more of a cleanup than a bug fix - as noted above = in > the patch description, the resources are eventually released anyway. > > So I wonder if the Fixes and CC to stable should be dropped. > > > Assisted-by: OpenAI:GPT-5.6 > > Co-developed-by: Ijae Kim > > Signed-off-by: Ijae Kim > > Signed-off-by: Myeonghun Pak > > --- > > Changes in v2: > > - Clarify that the window remains reserved only until device teardown. > > - Make the DMA fallback and continued probe description conditional. > > - Avoid claiming that every request failure leaves no resource held. > > - Restore the surrounding indentation for the new goto statements. > > > > Link: https://lore.kernel.org/netdev/20260731161740.44955-1-mhun512@gma= il.com/ > > The process nit above notwithstanding, this patch looks good to me. > > Reviewed-by: Simon Horman