From: Wenjie Qi <qwjhust@gmail.com>
To: Chao Yu <chao@kernel.org>
Cc: Wenjie Qi <qiwenjie@xiaomi.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v1 07/12] f2fs: cache: use node cache
Date: Mon, 24 Aug 2026 16:57:12 +0800 [thread overview]
Message-ID: <CAGFpFsSiP9_hDj-RgMV2+LZDX2qUquE7XBUP9eeV0ER8eLdgJw@mail.gmail.com> (raw)
In-Reply-To: <234a5bd3-76d1-4fea-bdc4-f1dff01e591b@kernel.org>
Yes, that is the race I meant.
On Mon, Aug 24, 2026 at 3:13 PM Chao Yu <chao@kernel.org> wrote:
>
> On 8/23/26 20:57, Wenjie Qi wrote:
> > Hi Chao,
> >
> >> entry = fn->entry;
> >> f2fs_cache_get(entry);
> >> spin_unlock_irqrestore(&sbi->fsync_node_lock, flags);
> >>
> >> f2fs_cache_wait_writeback(entry);
> >
> > The entry reference keeps the entry allocated, but the waiter does not hold
> > the entry lock. After WRITEBACK is cleared, invalidation can detach the
> > entry and set `entry->cache` to NULL. `f2fs_cache_wait_writeback()` checks
> > and uses `entry->cache` through separate accesses.
> >
> > Does the reference taken here also guarantee that the parent cache remains
> > attached across the wait helper's check and use?
>
> Do you mean race like this?
>
> - f2fs_wait_on_node_caches_writeback
> - f2fs_cache_get
> - f2fs_cache_wait_writeback
> - checked entry->cache, it's valid
> - f2fs_truncate_cache
> - f2fs_do_truncate_cache
> - entry->cache = NULL
> - f2fs_cache_wait_writeback_cond accesses
> invalid entry->cache
>
> Thanks,
next prev parent reply other threads:[~2026-08-24 8:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 3:17 [PATCH v1 00/12] f2fs: introduce metadata cache Chao Yu
2026-08-20 3:17 ` [PATCH v1 01/12] f2fs: cache: implement " Chao Yu
2026-08-20 5:08 ` [f2fs-dev] " Jaegeuk Kim
2026-08-20 5:13 ` Chao Yu
2026-08-23 12:52 ` Wenjie Qi
2026-08-24 7:03 ` Chao Yu
2026-08-20 3:17 ` [PATCH v1 02/12] f2fs: cache: initialize meta cache Chao Yu
2026-08-20 3:17 ` [PATCH v1 03/12] f2fs: cache: introduce shrinker Chao Yu
2026-08-20 3:17 ` [PATCH v1 04/12] f2fs: cache: introduce writeback thread Chao Yu
2026-08-20 5:09 ` [f2fs-dev] " Jaegeuk Kim
2026-08-23 12:54 ` Wenjie Qi
2026-08-24 7:04 ` Chao Yu
2026-08-20 3:17 ` [PATCH v1 05/12] f2fs: cache: use meta cache Chao Yu
2026-08-20 5:11 ` [f2fs-dev] " Jaegeuk Kim
2026-08-23 12:55 ` Wenjie Qi
2026-08-24 7:05 ` Chao Yu
2026-08-20 3:17 ` [PATCH v1 06/12] f2fs: cache: initialize node cache Chao Yu
2026-08-20 3:17 ` [PATCH v1 07/12] f2fs: cache: use " Chao Yu
2026-08-23 12:57 ` Wenjie Qi
2026-08-24 7:13 ` Chao Yu
2026-08-24 8:57 ` Wenjie Qi [this message]
2026-08-23 12:59 ` Wenjie Qi
2026-08-24 7:13 ` Chao Yu
2026-08-20 3:17 ` [PATCH v1 08/12] f2fs: cache: initialize compress cache Chao Yu
2026-08-20 3:17 ` [PATCH v1 09/12] f2fs: cache: use " Chao Yu
2026-08-20 3:17 ` [PATCH v1 10/12] f2fs: cache: support fault injection Chao Yu
2026-08-20 3:17 ` [PATCH v1 11/12] f2fs: cache: introduce tracepoints Chao Yu
2026-08-20 3:17 ` [PATCH v1 12/12] f2fs: cache: show per-cache usage in debugfs Chao Yu
2026-08-24 10:07 ` [PATCH v1 00/12] f2fs: introduce metadata cache Wenjie Qi
2026-08-28 13:01 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGFpFsSiP9_hDj-RgMV2+LZDX2qUquE7XBUP9eeV0ER8eLdgJw@mail.gmail.com \
--to=qwjhust@gmail.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=qiwenjie@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®