From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752563AbcIDDWI (ORCPT <rfc822;w@1wt.eu>);
        Sat, 3 Sep 2016 23:22:08 -0400
Received: from mail-it0-f65.google.com ([209.85.214.65]:34672 "EHLO
        mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751991AbcIDDWF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 3 Sep 2016 23:22:05 -0400
MIME-Version: 1.0
In-Reply-To: <2179bf7c-9878-adf7-da97-2746d5aa3d34@users.sourceforge.net>
References: <566ABCD9.1060404@users.sourceforge.net> <ab4a20b2-16be-c3b2-58a7-fe7db39ab559@users.sourceforge.net>
 <2179bf7c-9878-adf7-da97-2746d5aa3d34@users.sourceforge.net>
From: Julian Calaby <julian.calaby@gmail.com>
Date: Sun, 4 Sep 2016 13:21:01 +1000
Message-ID: <CAGRGNgWXdzvfL4wdM2uQr7DRbJgCuY0O-jRmSGhqfbPBZGS2Aw@mail.gmail.com>
Subject: Re: [PATCH 2/4] sparc: bpf_jit: Move four assignments in bpf_jit_compile()
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: sparclinux <sparclinux@vger.kernel.org>,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "David S. Miller" <davem@davemloft.net>, Rabin Vincent <rabin@rab.in>,
        LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors <kernel-janitors@vger.kernel.org>,
        Julia Lawall <julia.lawall@lip6.fr>,
        Paolo Bonzini <pbonzini@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Markus,

On Sun, Sep 4, 2016 at 2:38 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 3 Sep 2016 17:45:28 +0200
>
> Move the assignments for four local variables a bit at the beginning
> so that they will only be performed if a corresponding memory allocation
> succeeded by this function.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  arch/sparc/net/bpf_jit_comp.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/sparc/net/bpf_jit_comp.c b/arch/sparc/net/bpf_jit_comp.c
> index ced1393..a927470 100644
> --- a/arch/sparc/net/bpf_jit_comp.c
> +++ b/arch/sparc/net/bpf_jit_comp.c
> @@ -362,10 +362,10 @@ do {      *prog++ = BR_OPC | WDISP22(OFF);                \
>
>  void bpf_jit_compile(struct bpf_prog *fp)
>  {
> -       unsigned int cleanup_addr, proglen, oldproglen = 0;
> -       u32 temp[8], *prog, *func, seen = 0, pass;
> -       const struct sock_filter *filter = fp->insns;
> -       int i, flen = fp->len, pc_ret0 = -1;
> +       unsigned int cleanup_addr, proglen, oldproglen;
> +       u32 temp[8], *prog, *func, seen, pass;
> +       const struct sock_filter *filter;
> +       int i, flen = fp->len, pc_ret0;
>         unsigned int *addrs;
>         void *image;
>
> @@ -385,6 +385,10 @@ void bpf_jit_compile(struct bpf_prog *fp)
>         }
>         cleanup_addr = proglen; /* epilogue address */
>         image = NULL;
> +       filter = fp->insns;
> +       oldproglen = 0;
> +       pc_ret0 = -1;
> +       seen = 0;
>         for (pass = 0; pass < 10; pass++) {
>                 u8 seen_or_pass0 = (pass == 0) ? (SEEN_XREG | SEEN_DATAREF | SEEN_MEM) : seen;

This is utterly pointless, why?

If you were moving the assignments on declaration onto separate lines
at the top of the file then ok, but why all the way down here?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/