From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C35364ADD87 for ; Wed, 29 Jul 2026 14:09:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.167.179 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785334160; cv=pass; b=fQL08Dk8fXvn+I1E7f87uNt4DxYQNIKDAZajIC2CK/AEwaJaiJ2Gds/5G22lueBjRGFG6mvbIzOHbGYDNz+8YfeekvK3aFW8gfvZ2mbT6Rsz9/P1bJUEOFOKj7KiHpDqDiC65RYH1zns88h7I6btf78o9QJo1nfwGwXXcSJiff0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785334160; c=relaxed/simple; bh=MNYoGZus+xhWAqSQfFrGzVLud6+ETt1Gl8AwDyHWw3Y=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=S+Fe6t+rQzk90kO5o38RlsfSXTp1n41EFN4/EDBRzdlprO9HD45VCctUSMAvoF7sEyTPYyyJL4dMEdkvNLlKehxToHAMib+VbXbboMyJH+sjU9zgyFyS0SZq3SEKc59t8961ygQ8RiThAsW52fqc46kJOUjjT6lIIa9ItA+7ADc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a+BVeJH0; arc=pass smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a+BVeJH0" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-486db28a56fso31911b6e.1 for ; Wed, 29 Jul 2026 07:09:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1785334158; cv=none; d=google.com; s=arc-20260327; b=TxpgqoCr61ZbPgC6TOadkQhTiqPayydjdry2W6CKddjZeMmS8Vtc66xfPVqzjzTl9t PC8zh8HZtVsVGydINbcjKh7CvYA+Q4XMzyuPFu4X/t9NC9QsJG3f69KtLiulZXOvxosv TD8A2KNJpIQOMZQG8Xl9WI1EAmpzf002uocdTY2Zix62SOc+GpZZI8X3UWTpJDduVXNV bJ2lT6ELt15QN21gqALaOVQtH23QehTgcmYdt/SKuf0OanJJxgf5XN//xxfP5+NS7NQt BDsy9dgy3xKlr26T8CD41sf8JrNT06FgSxiMSzgUDF1vf7hGmToXM9cj7Dl3QLSaU8a5 nKPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=MNYoGZus+xhWAqSQfFrGzVLud6+ETt1Gl8AwDyHWw3Y=; fh=tsdTrSJWDqjAzpDLrs74ReyZmZ2H9iPFMSxNfswvLoE=; b=KWSN2itZ8vM87Hw6t1q7+w50gB0QS51XDEZh1Jo1KeSA/U1i6DgxIRaB3aLxfXE5wY PuqVYdEvBRSbXKdanXlSzwWyfK8Q6qbydfXOLnFm3P/i3s8W63cmnGEnWjBv+Qk5A3bT IMtAsOTkGRcbhbO8iy8JEGAWHRNXOwzLPJpnmhEX1DUrSBYFuW2eu+CiTGk3mH9V/F6J hFawgR3jBUDENViqG+s4TQ6X6WUVjnxGTnN8Vt9iA36dvlSBOFZo7WAtmMViWpNxtW0w uFdfGDsC+sMaJByEKPgvlhJ4qNtcH5ImW8D6CXUr3lNuWHecfegQCEEZUsXkHVxDLmI1 TU3g==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785334158; x=1785938958; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MNYoGZus+xhWAqSQfFrGzVLud6+ETt1Gl8AwDyHWw3Y=; b=a+BVeJH0swPnXPjmlh1xkm+p77vkP4+S8S76QWh1ErNvZMcc07UqtUQ3egE4vFVkCL h8CE+VxhFpK/vEhejst1khby3oZPOwWJI1ZTOpxM3LWvvJ0Hyv2+aTICkKC8V27U62Tv ZUCNPlgRAMRqLXsxWj30/auWB0/+jkshLWXw+obMRICsI1DyWDpjMZKQNh33VhmbJT9k VOWe8SMS8/Z35uq71T8WIhTNfUbiKH4xhTeLfvsvM4kO7Bp7jVtuvqbCARn4kJy5HIPm u9pxNQx/UDk1pfKayowSZ0V0lE1N4YJcplMBDiP9HcV25KdIcK3l6W0whuy1VkU9VJuk H4KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785334158; x=1785938958; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MNYoGZus+xhWAqSQfFrGzVLud6+ETt1Gl8AwDyHWw3Y=; b=bTBTVPW49YY+OgT36DHy2fLnCyMcTvoFTa8Ma+1uUVnIuoZVZ50DpvmRMORLRsDHzk lig4Jxz9DSoC56AjzyLs8BAcTg0NEo8vJAx4ObiI1lcLzCIwCc7k6lFXAVdIcAel7MSt 4RXz+Uq+biSLMXXbowXHjWNwfIJIkQC0hpI0G8B2VPecoLOidej29VRan+phmVExjzm3 9T5B9pQKm1NOz+WI0d9AhGfhxGKtmLgj2+YQ5jZTxZD+TCSguwaytLrpDyn30rEVBr/e 7NGdei8d3cnuRPw4LRm+XOEHXwSsPI1xXuN9arcuRdaMQCXqRlzagbBxMpeREv8yM6Th sDKQ== X-Forwarded-Encrypted: i=1; AHgh+Rr2+rIpvzv2f3DljmiHGRdF6tS04Fkt1E/Lsk9EKSNDLIjjt/dSnwDUKLPkqvAE5S6owhc0IhxaqPRUBM4=@vger.kernel.org X-Gm-Message-State: AOJu0YxWt11N6NzmBfY7rikJxGyQihEuAzYd203cXf5/4y1ITxaqDLOZ 3C+0JaikPCx9uYNyyx2AOQkZeowphgm3EkbavQdHJZRhbAs5oepXx4L0/Z3SBjI2Mzv/dVCNlgo kuD2R0G2yK5R2ARfRzpRs8KEcFLUrUsowNuMEPts= X-Gm-Gg: AR+sD10p7fNmsWUoMwL0tkjX2j0teb/Zzy047BvjM0G7nDHxLMhiD5ECMTRnZEVqxog EAQ5Xsk4N7Drbn+ThUwca0RzoW8yEioxyH0LqnP+32OlMgNT7xas64Hsk6aVa47uAxUe33ZilW8 TdTBRY2lUymP71yf0xC9EsvD2vphhoVwKuZLrreavQLzQfi1Sc5j6YuKeoYhI606hCVum7CVfJq bufUGKN9mNeIv1MPuhdt9+s5Q+8wW1VkMlCSymPTXoU2A33Tbs3ooNHksmmSdWnhSWoS3yV3Gfa f+JuTYvGmciTs5t0loY3HlJZ6odZ4uHb/Vba4VRhGAxCek8McbWq6qurEp71 X-Received: by 2002:a05:6808:3010:b0:4a4:82b:2a35 with SMTP id 5614622812f47-4ad5b78e2d1mr2703607b6e.1.1785334157515; Wed, 29 Jul 2026 07:09:17 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260724-netconsole_move_more_final-v1-0-a5f7691db81c@debian.org> <20260724-netconsole_move_more_final-v1-9-a5f7691db81c@debian.org> In-Reply-To: <20260724-netconsole_move_more_final-v1-9-a5f7691db81c@debian.org> From: Gustavo Luiz Duarte Date: Wed, 29 Jul 2026 15:09:05 +0100 X-Gm-Features: AUfX_mzZ3PUhekmsXFQ0GhvstJao6iMRguXZQhDbh2v4p8cX4LL9_QkGlFWf1tg Message-ID: Subject: Re: [PATCH net-next 9/9] netconsole: move netpoll_wait_carrier() as netcons_wait_carrier() To: Breno Leitao Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, asantostc@gmail.com, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 24, 2026 at 4:05=E2=80=AFPM Breno Leitao wr= ote: > > netpoll_wait_carrier() waits for the egress device carrier during > netconsole setup. Its only caller, netcons_netpoll_setup(), already > lives in netconsole. Move the function into drivers/net/netconsole.c, > drop EXPORT_SYMBOL_GPL() and remove the prototype from . > > Rename it to netcons_wait_carrier() for the netcons_ prefix. It now reads > the timeout through netpoll_get_carrier_timeout(), since carrier_timeout > stays in netpoll to keep the netpoll.carrier_timeout parameter. > > Signed-off-by: Breno Leitao Reviewed-by: Gustavo Luiz Duarte