From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753669AbaBYWkM (ORCPT ); Tue, 25 Feb 2014 17:40:12 -0500 Received: from mail-pd0-f171.google.com ([209.85.192.171]:34788 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbaBYWkJ convert rfc822-to-8bit (ORCPT ); Tue, 25 Feb 2014 17:40:09 -0500 MIME-Version: 1.0 In-Reply-To: References: <1393287245-4549-1-git-send-email-mcgrof@do-not-panic.com> <1393294265.6823.154.camel@deadeye.wl.decadent.org.uk> <20140224.235343.1936318499491821387.davem@davemloft.net> <2446186.I4KkJ8Hjdb@lenovo> From: Florian Fainelli Date: Tue, 25 Feb 2014 14:39:28 -0800 Message-ID: Subject: Re: [PATCH] net: kdoc struct net_device flags and priv_flags To: "Luis R. Rodriguez" Cc: David Miller , Ben Hutchings , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-02-25 14:19 GMT-08:00 Luis R. Rodriguez : > On Mon, Feb 24, 2014 at 9:37 PM, Florian Fainelli wrote: >> Le lundi 24 février 2014, 23:53:43 David Miller a écrit : >>> They are visible to userspace via sysfs. >> >> In /sys/class/net/*/flags, although we are lacking quite a lot of documentation >> for the exported attributes there. > > I only see dev->flags there, I don't see any toggle capability for > priv_flags. Let me know if you find anywhere that userspace lets a > user toggle private flags, I just don't see it. You are right, those are dev->flags, not priv_flags, sorry about that. > > I'll extend the documentation for a v2 with the sysfs attribute stuff. Thanks! -- Florian