From: Kees Cook <keescook@chromium.org>
To: Sasikantha babu <sasikanth.v19@gmail.com>
Cc: Serge Hallyn <serge.hallyn@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
James Morris <james.l.morris@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] prctl: Removed redunant assignment of "error" to zero
Date: Wed, 30 May 2012 08:07:53 -0700 [thread overview]
Message-ID: <CAGXu5jKFnTyb7WBVP1xc444B90P3uOdhKt5PZGSfHBdWOiTNrQ@mail.gmail.com> (raw)
In-Reply-To: <1338371703-28858-1-git-send-email-sasikanth.v19@gmail.com>
On Wed, May 30, 2012 at 2:55 AM, Sasikantha babu
<sasikanth.v19@gmail.com> wrote:
> Just setting the "error" to error number is enough on failure and
> It doesn't require to set "error" variable to zero in each switch case, since
> it was already initialized with zero
This looks fine. Can you include an additional clean up in this? It
looks like PR_SET_NAME and PR_GET_NAME both 'return 0' instead of
using 'break' like all the rest.
-Kees
--
Kees Cook
Chrome OS Security
prev parent reply other threads:[~2012-05-30 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 9:55 Sasikantha babu
2012-05-30 15:07 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jKFnTyb7WBVP1xc444B90P3uOdhKt5PZGSfHBdWOiTNrQ@mail.gmail.com \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sasikanth.v19@gmail.com \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®